Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349903 - [patch] genkernel-3.4.10.908 iscsi option fails with open-iscsi-2.0-871
Summary: [patch] genkernel-3.4.10.908 iscsi option fails with open-iscsi-2.0-871
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Genkernel Maintainers
URL: https://code.launchpad.net/bugs/600953
Whiteboard:
Keywords: Inclusion
Depends on: 314575
Blocks:
  Show dependency tree
 
Reported: 2010-12-27 22:10 UTC by Rob MacKinnon
Modified: 2011-04-09 03:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
open-iscsi-2.0.871.3-r1.ebuild (open-iscsi-2.0.871.3-r1.ebuild,2.58 KB, text/plain)
2010-12-27 22:19 UTC, Rob MacKinnon 		Details
files/open-iscsi-2.0.871.3-r1-iscsi_sysfs.patch (open-iscsi-2.0.871.3-r1-iscsi_sysfs.patch,436 bytes, patch)
2010-12-27 22:22 UTC, Rob MacKinnon 		Details | Diff
updated with bug number documentation (open-iscsi-2.0.871.3-r1.ebuild,2.58 KB, text/plain)
2010-12-27 22:23 UTC, Rob MacKinnon 		Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob MacKinnon 2010-12-27 22:10:40 UTC 
Under genkernel-3.4.10.908 /etc/genkernel.conf, does not reflect latest version of working open-iscsi.  While building, returns the following error:

/var/tmp/genkernel/6480.26436.24287.27453/open-iscsi-2.0.871.3/usr/iscsi_sysfs.c:879: undefined reference to `S_ISDIR'
iscsi_sysfs.o: In function `iscsi_sysfs_get_sid_from_path':
/var/tmp/genkernel/6480.26436.24287.27453/open-iscsi-2.0.871/usr/iscsi_sysfs.c:618: undefined reference to `S_ISDIR'
/var/tmp/genkernel/6480.26436.24287.27453/open-iscsi-2.0.871/usr/iscsi_sysfs.c:618: undefined reference to `S_ISLNK'
collect2: ld returned 1 exit status
make[1]: *** [iscsid] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/var/tmp/genkernel/6480.26436.24287.27453/open-iscsi-2.0.871.3/usr'
make: *** [user] Error 2

To fix would require a version bump on /etc/genkernel.conf for open-iscsi-2.0.871.3 and attached patch per LP:600935 (https://code.launchpad.net/bugs/600953)

Also, attached updated ebuild for versioning goodness.
Comment 1 Rob MacKinnon 2010-12-27 22:19:59 UTC 
Created attachment 258222 [details]
open-iscsi-2.0.871.3-r1.ebuild
Comment 2 Rob MacKinnon 2010-12-27 22:22:12 UTC 
Created attachment 258224 [details, diff]
files/open-iscsi-2.0.871.3-r1-iscsi_sysfs.patch
Comment 3 Rob MacKinnon 2010-12-27 22:23:54 UTC 
Created attachment 258225 [details]
updated with bug number documentation

Sorry for the spam :L
Comment 4 Sebastian Pipping gentoo-dev 2011-01-05 23:08:25 UTC 
PS: Adding keyword "Inclusion" and "[patch] " prefix to better show this bug's nature in searches...
Comment 5 Stefan Behte (RETIRED) gentoo-dev Security 2011-02-08 16:20:02 UTC 
The problem is that the open-iscsi version is old. Can you try the newer verison from #314575?
Comment 6 Sebastian Pipping gentoo-dev 2011-02-08 17:19:48 UTC 
FYI an easy way to get iscsi 2.0-872 is emerging genkernel-3.4.12.6-r1 that I just added.  Please report back, if that fixes your problem.
Comment 7 Fabio Erculiani (RETIRED) gentoo-dev 2011-03-22 07:08:26 UTC 
872 doesn't compile either. A simple genkernel --iscsi all would have spotted that before committing ;-). Will post the build output in a few hours.
Comment 8 Xake 2011-03-22 07:20:48 UTC 
(In reply to comment #7)
> 872 doesn't compile either. A simple genkernel --iscsi all would have spotted
> that before committing ;-). Will post the build output in a few hours.

On my computer 872 compiles (using genkernel-3.4.14).
Comment 9 Fabio Erculiani (RETIRED) gentoo-dev 2011-03-22 07:23:06 UTC 
Error is the same listed here:
http://bugs.gentoo.org/show_bug.cgi?id=340425#c6
Comment 10 Fabio Erculiani (RETIRED) gentoo-dev 2011-03-22 07:25:50 UTC 
(In reply to comment #8)
> On my computer 872 compiles (using genkernel-3.4.14).

Maybe because you don't have openslp installed?
Comment 11 Fabio Erculiani (RETIRED) gentoo-dev 2011-03-22 07:34:21 UTC 
Yeah, adding -lslp to compiler flags fixes it.
Also, openslp is an automagic dep and should be handled via a USE flag in open-iscsi ebuild.