Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 336390 - app-portage/gentoolkit-dev: echangelog could sort the changed files a little
Summary: app-portage/gentoolkit-dev: echangelog could sort the changed files a little
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 411301
  Show dependency tree
 
Reported: 2010-09-07 21:31 UTC by Michał Górny
Modified: 2013-05-10 20:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-09-07 21:31:24 UTC 
It looks like echangelog is listing the changes files unsorted in the ChangeLog entries. This could lead to a monster like that:

+  07 Sep 2010; Michał Górny (sedzimir) <gentoo@mgorny.alt.pl>
+  +files/0001-Append-miniupnpc-specific-flags-to-CFLAGS.patch,
+  -miniupnpc-1.4.20100609.ebuild, +files/0002-Respect-LDFLAGS.patch,
+  +miniupnpc-1.4.20100609-r1.ebuild,
+  +files/0003-Move-non-used-and-non-installed-test-executables-to-.patch,
+  -files/miniupnpc-1.4.20100609-cflags.diff,
+  +files/0004-Move-minixml-validation-test-to-check-target.patch,
+  +files/0005-Build-upnpc-static-only-on-AmigaOS-or-everything-tar.patch,
+  +files/0006-Support-disabling-static-library-install-through-LIB.patch:

I think that this particular entry would look much better if AUX files were displayed after the ebuilds, one after another. In other words, I suggest implementing some kind of ordering there, probably lexical with relative path as the first key, and the filename as the second one.
Comment 1 Christian Ruppert (idl0r) gentoo-dev 2010-10-23 15:15:20 UTC 
Should be fixed in revision 819. Please verify.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-10-23 15:29:21 UTC 
Hm, I guess it's too late to note that but I would appreciate if the ordering matched one used in egencache [1].

I'll try to test it today, thanks.

[1] http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob;f=bin/egencache;h=783cfc428ab750ff31d3cfe59c4f82d8b1c1affb;hb=HEAD#l472
Comment 3 Christian Ruppert (idl0r) gentoo-dev 2010-10-23 17:08:48 UTC 
(In reply to comment #2)
> Hm, I guess it's too late to note that but I would appreciate if the ordering
> matched one used in egencache [1].
> 
> I'll try to test it today, thanks.
> 
> [1]
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blob;f=bin/egencache;h=783cfc428ab750ff31d3cfe59c4f82d8b1c1affb;hb=HEAD#l472
> 

The current sort mechanism is the same as in portage. At least it was the same some time ago, I've never checked it again for changes.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-10-25 19:26:53 UTC 
+*stk11xx-2.1.0 (25 Oct 2010)
+
+  25 Oct 2010; Michał Górny <mgorny@gentoo.org>
+  +files/stk11xx-v4l_compat_ioctl32.diff, +stk11xx-2.1.0.ebuild, +metadata.xml:
+  Import from the Sunrise overlay per bug #178946. Thanks to Krzysztof Magusiak
+  for his effort.

I don't think that's exactly what I expected it to be. IMO the ebuilds should come before files/.
Comment 5 Christian Ruppert (idl0r) gentoo-dev 2011-02-25 20:53:06 UTC 
Finally fixed in -9999.
Comment 6 Christian Ruppert (idl0r) gentoo-dev 2013-05-10 20:37:17 UTC 
This should be fixed in app-portage/gentoolkit-dev-0.2.8.2. Please test.