I saw that pine was updated. Please, update the pine-maildir ebuild too...
Considering http://www.idefense.com/advisory/09.10.03.txt and GLSA 200309-10, shouldn't this be marked as a security issue and getting a higher severity than just enhancement?
Ok... since nobody ever cared too much about pine-maildir, I gave up and installed plain pine with courier-imap... :P
Looks like I will do the same, especially since nobody is at least commenting on this. BTW, I think you should maybe add the keyword SECURITY; this is a security issue i would say.
I personally need the maildir support. Please update the pine-maildir ebuild.
Created attachment 18893 [details, diff] Update of line numbers in pine-maildir-4.56 Try this update of pine-maildir-4.56. Copy and rename ebuild and files as appropriate to your PORTAGE_OVERLAY dir.
Still no new ebuild for pine-maildir and I can't get Anders patch to apply. Any suggestions (short of throwing pine-maildir away)?
I'd try to apply it, but to what should I do that? pine? pine-maildir? which version?
Tobias: At what stage did it complain? I did as follows. Edited /usr/portage/distfiles/pine-maildir-4.56. The result is the attachment above. Save it as pine-maildir-4.58 in /usr/portage/distfiles. Now you can either just rename the 4.56 ebuild to 4.58, but it will of course be deleted the next time you sync, or put it in your PORTAGE_OVERLAY, which I did. Verify that make.conf is edited appropriately, and don't forget that the overlay has the same hierarchy as the normal portage tree. I also had to copy the /usr/portage/net-mail/pine-maildir/files directory to the portage overlay. If you chose the rename alternative above, this shouldn't be necessary. Create a new digest. And then it was just to emerge pine-maildir.
Anders: The only attachment to this ticket is a diff, not an Ebuild. And I couldn't quite figure out to which file it should be applied. FWIW, it's definetly no ebuild (which you seem to hint at). Maybe you accidentally uploaded the wrong file? From the file: <pre> diff -Nur pine4.50/README.maildir pine4.50-maildir/README.maildir ... diff -Nur pine4.53/imap/src/osdep/unix/Makefile pine4.50-maildir/imap/src/osdep/unix/Makefile ... </pre>
The patch he provided is to be applied to the maildir patch that is downloaded when you emerge pine-maildir to /usr/portage/distfiles/pine-maildir-4.56. I'm applying it now and checking if it works. I'll report back when I'm done.
You know those dialog boxes that come up when you press a button like "Are you sure you want to post this comment? Yes/No" ? Those dialogs were invented for people like me. What I should have said before was that the file provided by Anders should be _saved_as_ /usr/portage/distfiles/pine-maildir-4.58. The ebuild will apply this patch to the pine source of version 4.58. As Anders said you'll have to generate a digest, but after you've done that pine-maildir-4.58 emerges without problems. The digest file I made contains: MD5 6135222a12f06b2dfceea5c1b736891e pine4.58.tar.bz2 2837321 MD5 cd1bd3137b8bcc3ddd71ff3e8e73a5eb pine-maildir-4.58 46382 Please verify for security before using it. Now if only bug #23232 could be solved as well, I could start using it. =(
Now that I got my tiny brain around to what Anders meant ;) I have tried the same and updated to pine-4.58 including maildir support. So far, everything seems peachy.
Side question: Is pine-maildir need to be a separate package? I've got a new pine ebuild that supports the maildir USE flag. Can this be all rolled into one package? The reason I bring this up is that I've added a bunch more functionality to the pine ebuild (i.e. IPV6, UTF8, passfile, new chappa patch, etc). I would really hate to duplicate all this effort into another package when a simple USE flag can suffice for maildir support. Opinions?
I'd /love/ to see this integrated into the main pine ebuild by USE flag.
Welp, it all builds with USE="kerberos maildir ipv6 ssl passfile ldap" so I'll commit it all later today.
Please give the new pine ebuild a try. Unmerge old pine-maildir and emerge pine-4.58-r3. Make sure you have "maildir" in your USE flags. Report back on your successes, failures, rants, and general opinions. :)
Ebuild dies with an error in line 140, might be caused by the line just containing "die" ;-) After removing that line it was installed without problems, unfortunately I wasn't able to get it to work with my maildir yet (at least not in the 5 min I had).
The die() call has been removed. Please post your findings about the maildir functionality. I don't have a way of testing it myself, so anything you find will be greatly appreciated.
I have compiled it OK, and it does read maildir format. There was one problem that stumped me, though. The path (or name, rather) to the users' maildir is hard coded, and in my patch, as well as the 4.56 patch, the name is .maildir, whilst it in your patch is Maildir. Hence the two byte difference in file size. The ebuild digest command didn't want to play nice with me, so I tried to copy my .maildir to Maildir and that worked. I don't know whether there is an official stance that the name should be Maildir, and I don't remember to what qmail defaults, if at all maildir. Anyway, I think that this might be the problem that vorlon had.
Ah! thanks for the explanation. Volron, is this what you're noticing? I honestly don't know enough about maildir to say with any certainty which it should be. I haven't looked yet, but the Maildir doesn't make this configurable? Can you set the mailbox path or something? (Just curious, I'd like to get this marked stable soon).
The maildir is a directory that almost everywhere in the world has the name of Maildir, but in gentoo, it was renamed to .maildir :( It seems that gentoo developers thought this was better, but didn't care about compatibility... shame on them.
Well, I'm configuration agnostic in this case so it doesn't really matter to me. I don't have a large system to maintain so it's not difficult to change. Also, I looked in Life with qmail and the maildir example there uses Maildir. Not that I looked hard but I haven't find a way to change the path to INBOX from within pine. The maildir name/path is defined in maildir.h but the #ifdef NO_MAILDIR_FIDDLE part early in maildir.c doesn't use that definition for some reason, or perhaps I'm just not knowledgeable enough. Anyway, the important thing is that whatever the configuration is, it is consistent over all packages that supports the maildir format.
Yeah Max, that was my problem too. I just made a symlink from Maildir to .maildir and that seems to work so far, at least i could see my mail ;-) I'll see if it works alright, when I have a little more time again.
I've tried the -r3 ebuild but pine complains that Maildir (my users have the "traditional" style Maildirs) is not a selectable folder. We're talking qmail Maildirs here, right, i.e. a dir that contains cur, new and tmp as sub-folders which in turn conatin one file per mail. I've checked the ebuild and indeed it says that it includes the maildir patch. Any ideas?
It's all in the source! Search the patch for NO_MAILDIR_FIDDLE and you'll see that it by default is not possible do explicitly select the maildir, it should only be accessed via the INBOX alias. And the patch provided by the r3 ebuild should link INBOX with Maildir.
I don't know if this is relevant, but I noticed a while ago that pine would not accept any directory containing the string "maildir". So now I have my maildir in ~/.mail/incoming. .pinerc contains: inbox-path=/.mail/incoming/inbox folder-collections=.mail/saved/[] incoming-folders=Vegastrike /.mail/incoming/vegastrike And Max, my offer still stands; if you need a temporary account to test it out, just let me know.
I think it's time to kill this one. Maurice, I can't reproduce the behaviour you describe, unless you actually mean "Maildir" as being non selectable/creatable. In that case I think it is supposed to be that way (see comment 25). The qustion of whether the patch should link INBOX with "Maildir" or with ".maildir" remains, though.
Kill away, Anders. It's been quite a while since I last used pine, because I switched to mutt when it turned out bug #23232 wasn't going to be solved (see comment #9 onwards of said bug).
Created attachment 30545 [details, diff] patch to change the maildir from "Maildir" to ".maildir" Max or whoever in the net-mail herd, can this one be closed now? If you want, apply this diff to the maildir patch to change the maildir from "Maildir" to ".maildir".
Created attachment 30751 [details] Ebuild that pulls in a new maildir patch from UW. Ebuild based on 4.58-r3 that pulls in a new maildir patch from http://www.math.washington.edu/~chappa/pine/patches/pine4.58/maildir.patch.gz This patch also fixes Bug 23232. See http://www.math.washington.edu/~chappa/pine/info/maildir.html for more info.
Hi, me again. I received an email from Eduardo Chappa who wrote the patch of comment 30. Just to let you know, he had a few concerns that you should be aware of. The patch is very much a work in progress. New bugs may be introduced and so on. There is no guarantee that his website is up 24/7/365. In fact, it is guaranteed not to be up 24/7/365. His website will not last forever. In fact, it may be gone next week. It is impossible to predict. Thus, if and when this patch is used intead of the current one, it would be best if it could be distributed via the official Gentoo mirrors instead of being pulled in from his site. That way a (hopefully) good version of the patch can be used, and there will be no problems with changing md5sums. FWIW, the version I have downloaded has the follwing md5sum and size. MD5 ad7b48c2bb0b74e64a38ce206025ef42 maildir.patch.gz 18757 He also let me know that pine 4.60 is around the corner.
Maildir support now in the normal pine ebuild (4.60).
