Bugzilla Bug 212696

I'm not going to host the baselayout tarball forever - I suggest that the
current svn repo is trimmed to match it and is maintained there.

I'm also not going to request keywords or stable keywords - that's entirely up
to you guys now.

Thanks!

Created an attachment (id=145541) [details]
openrc-0.1.ebuild

Created an attachment (id=145542) [details]
baselayout-2.0.0.ebuild

Where do (upstream, I think) bugs go, now?  Others will probably want to know
too, so having the pointer here should be a good thing.

(In reply to comment #3)
> Where do (upstream, I think) bugs go, now?  Others will probably want to know
> too, so having the pointer here should be a good thing.

http://bugs.marples.name/enter_bug.cgi?product=OpenRC

True, I'll not be actively looking for bugs after it's in portage, but I'm also
happy to be CC'ed here.

(In reply to comment #1)
> Created an attachment (id=145541) [edit] [details]
> openrc-0.1.ebuild

On a side note, this has a broken inherit w/ [[ "${PV}" = "9999" ]], you are
overriding all the previous inherit lines there.

Created an attachment (id=145719) [details]
openrc-0.1.ebuild

updated ebuild with sane inherit and fixed MAKE_ARG vs. MAKE_ARGS

Is this allowed?

if [ "${PV}" = "9999" ]; then
   GIT=git
else
   GIT=
fi
inherit foo ${GIT}

I've updated my git ebuild like so and it seems to work. I've also sucked in
Hollows fix - thanks.

(In reply to comment #7)
> Is this allowed?
> 
> if [ "${PV}" = "9999" ]; then
>    GIT=git
> else
>    GIT=
> fi
> inherit foo ${GIT}
> 

It is.

(In reply to comment #8)
> 
> It is.
> 

Just remove the useless else.

(In reply to comment #9)
> Just remove the useless else.

So package managers clean the working environment then?

(In reply to comment #10)
> (In reply to comment #9)
> > Just remove the useless else.
> 
> So package managers clean the working environment then?
> 

What do you mean? The conditional inherit trick is in devmanual:
http://devmanual.gentoo.org/general-concepts/portage-cache/index.html

> What do you mean? The conditional inherit trick is in devmanual:
> http://devmanual.gentoo.org/general-concepts/portage-cache/index.html

Look at comment #7. Roy has used a variable GIT which should be cleared prior
to the if or inside the else-case. Otherwise, it could be undefined in certain
situations.

Just so the bug is aware, I've been taking this up to get it in the tree on
behalf of base-system. It will hit the tree next week most likely since I will
be out of town this coming weekend. Also I need to finish coordinating with
everyone.

(From update of attachment 145541 [details])
comment #5 is wrong, the code Roy has is correct wrt inherit

(In reply to comment #14)
> (From update of attachment 145541 [details] [edit])
> comment #5 is wrong, the code Roy has is correct wrt inherit

Well, if it's correct, then someone should fix portage to stop spitting
warnings about it. Or more likely you didn't see them since you didn't emerge
the 9999 version.

openrc-0.2 and baselayout-2.0.0 have hit the tree and are ready for use and
consumption.