Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 196096 - sys-block/open-iscsi version-bumping thread: 2.0-870.3 available
Summary: sys-block/open-iscsi version-bumping thread: 2.0-870.3 available
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Mike Doty (RETIRED)
URL: http://www.open-iscsi.org/
Whiteboard:
Keywords:
: 202085 212402 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-10-16 20:49 UTC by Stefan Behte (RETIRED)
Modified: 2009-03-20 16:23 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
open-iscsi-2.0.865.15.ebuild (open-iscsi-2.0.865.15.ebuild,2.52 KB, text/plain)
2008-01-10 08:10 UTC, r01
Details
open-iscsi-2.0.865.15.ebuild (open-iscsi-2.0.865.15.ebuild,1.83 KB, text/plain)
2008-01-10 08:53 UTC, r01
Details
sys-block/open-iscsi-2.0.865.15.ebuild (open-iscsi-2.0.865.15.ebuild,2.01 KB, text/plain)
2008-01-22 09:37 UTC, r01
Details
open-iscsi-2.0.868-r1.ebuild (open-iscsi-2.0.868-r1.ebuild,2.53 KB, text/plain)
2008-03-09 21:54 UTC, Stefan Behte (RETIRED)
Details
iscsid-conf.d for open-iscsi-2.0.868-r1.ebuild (iscsid-conf.d,236 bytes, text/plain)
2008-03-09 21:55 UTC, Stefan Behte (RETIRED)
Details
init.d script for open-iscsi-2.0.868-r1.ebuild (iscsid-init.d,1.49 KB, text/plain)
2008-03-09 21:55 UTC, Stefan Behte (RETIRED)
Details
init.d script for open-iscsi-2.0.868-r1.ebuild (iscsid-conf.d,242 bytes, text/plain)
2008-03-09 22:38 UTC, Stefan Behte (RETIRED)
Details
init.d script for open-iscsi-2.0.868-r1.ebuild (iscsid-init.d,1.59 KB, text/plain)
2008-03-09 22:39 UTC, Stefan Behte (RETIRED)
Details
open-iscsi-2.0.869.ebuild (open-iscsi-2.0.869.ebuild,2.56 KB, text/plain)
2008-03-24 22:58 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.init.d (iscsid-2.0.869.init.d,1.70 KB, text/plain)
2008-03-24 22:59 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.conf.d (iscsid-2.0.869.conf.d,242 bytes, text/plain)
2008-03-24 22:59 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.conf.d (iscsid-2.0.869.conf.d,259 bytes, text/plain)
2008-05-11 16:24 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.2.conf.d (iscsid-2.0.869.2.conf.d,242 bytes, text/plain)
2008-07-05 19:28 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.2.init.d (iscsid-2.0.869.2.init.d,1.76 KB, text/plain)
2008-07-05 19:31 UTC, Stefan Behte (RETIRED)
Details
open-iscsi-2.0.869.2.ebuild (open-iscsi-2.0.869.2.ebuild,2.41 KB, text/plain)
2008-07-05 19:31 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.869.2.init.d (iscsid-2.0.869.2.init.d,2.27 KB, text/plain)
2008-11-06 12:32 UTC, Marcel Pennewiß
Details
open-iscsi-2.0.870.ebuild (open-iscsi-2.0.870.ebuild,2.41 KB, text/plain)
2008-11-07 01:58 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.870.conf.d (iscsid-2.0.870.conf.d,315 bytes, text/plain)
2008-11-07 01:59 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.870.init.d (iscsid-2.0.870.init.d,2.26 KB, text/plain)
2008-11-07 02:04 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.870.conf.d (iscsid-2.0.870.conf.d,314 bytes, text/plain)
2008-11-07 22:14 UTC, Marcel Pennewiß
Details
iscsid-2.0.870.init.d (iscsid-2.0.870.init.d,2.36 KB, text/plain)
2008-11-07 22:15 UTC, Marcel Pennewiß
Details
iscsid-2.0.870.init.d (iscsid-2.0.870.init.d,2.71 KB, text/plain)
2008-12-04 18:29 UTC, Marcel Pennewiß
Details
iscsid-2.0.870.init.d (iscsid-2.0.870.init.d,2.71 KB, text/plain)
2008-12-04 19:31 UTC, Stefan Behte (RETIRED)
Details
open-iscsi-2.0.870.3.ebuild (open-iscsi-2.0.870.3.ebuild,2.85 KB, text/plain)
2009-03-18 23:15 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.870.3-init.d (iscsid-init.d,2.73 KB, text/plain)
2009-03-18 23:18 UTC, Stefan Behte (RETIRED)
Details
iscsid-2.0.870.3.init.d (iscsid-2.0.870.3.init.d,2.62 KB, text/plain)
2009-03-18 23:20 UTC, Stefan Behte (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Behte (RETIRED) gentoo-dev Security 2007-10-16 20:49:03 UTC
I just wanted to say it's available.
Comment 1 Stefan G. Weichinger 2007-12-06 09:41:17 UTC
In a portage-tree near of ... ? I don't see it here in my tree.
Comment 2 Stefan Behte (RETIRED) gentoo-dev Security 2007-12-06 20:14:58 UTC
Uhm, this was meant to be a version bump for sys-block/open-iscsi.
Now, even open-iscsi-2.0-865.15.tar.gz is available.
That version fixes http://bugs.gentoo.org/show_bug.cgi?id=197136

Maybe 
http://bugs.gentoo.org/show_bug.cgi?id=200355
should be included?

I'd really glad to see it in portage! :)

Sorry for my bad english.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-12-12 20:45:09 UTC
*** Bug 202085 has been marked as a duplicate of this bug. ***
Comment 4 r01 2008-01-10 08:10:11 UTC
Created attachment 140592 [details]
open-iscsi-2.0.865.15.ebuild
Comment 5 r01 2008-01-10 08:12:50 UTC
Comment on attachment 140592 [details]
open-iscsi-2.0.865.15.ebuild

the open-iscsi kernel module has been merged into the mainstream kernel, so we should skip compile kernel modules here.
Comment 6 r01 2008-01-10 08:53:07 UTC
Created attachment 140595 [details]
open-iscsi-2.0.865.15.ebuild

the open-iscsi kernel module has been merged into the mainstream kernel, so we should skip compile kernel modules here.
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-01-14 01:29:38 UTC
kingtaco: yours now.
Comment 8 r01 2008-01-22 09:37:22 UTC
Created attachment 141566 [details]
sys-block/open-iscsi-2.0.865.15.ebuild

changelog:

- use CONFIG_CHECK="SCSI_ISCSI_ATTRS ISCSI_TCP" from linux-info.class to check the kernel configuration
- install some other utilities from open-iscsi, (iscsi-iname, fwparam_ibft, ...)
Comment 9 r01 2008-01-23 06:24:14 UTC
from http://www.open-iscsi.org/:

the iscsi support in the kernel before (April 11, 2005) is linux-iscsi, and after that linux-iscsi and open-iscsi merged!

so a better approache to package this is auto detect the kernel version:

1) if the kernel lower than 2.6.23, compile and use the modules shipped with open-iscsi tarball;
2) the kernel version (up with 2.6.23), use the modules from the kernel;

But I have no much machines to test.
Comment 10 Stefan de Konink 2008-01-23 12:05:57 UTC
(In reply to comment #9)
> from http://www.open-iscsi.org/:
> 
> the iscsi support in the kernel before (April 11, 2005) is linux-iscsi, and
> after that linux-iscsi and open-iscsi merged!
> 
> so a better approache to package this is auto detect the kernel version:
> 
> 1) if the kernel lower than 2.6.23, compile and use the modules shipped with
> open-iscsi tarball;
> 2) the kernel version (up with 2.6.23), use the modules from the kernel;
> 
> But I have no much machines to test.
> 


It seems that this package is ALSA like, the modules inside are generally more up to date than the kernel variants.
Comment 11 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-05 23:06:04 UTC
Denis, you patch fails for me:
 * Cannot find $EPATCH_SOURCE!  Value for $EPATCH_SOURCE is:
 *
 *   /root/OVERLAY/sys-block/open-iscsi/files/remove-kernel-and-init-to-makefile.patch
 *   ( remove-kernel-and-init-to-makefile.patch )

 *
 * ERROR: sys-block/open-iscsi-2.0.865.15 failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_unpack
 *             environment, line 3135:  Called epatch 'src_unpack'
 *             environment, line 1432:  Called die
 * The specific snippet of code:
 *                   die "Cannot find \$EPATCH_SOURCE!";
 *  The die message:
 *   Cannot find $EPATCH_SOURCE!
 *
 * If you need support, post the topmost build error, and the call stack if relevant.
 * A complete build log is located at '/var/log/portagelog/sys-block:open-iscsi-2.0.865.15:20080305-221438.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-block/open-iscsi-2.0.865.15/temp/environment'.
 * This ebuild is from an overlay: '/root/OVERLAY/'


Would you attach it?
Also, your version should be based on open-iscsi-2.0.865.12.ebuild and not an older version, Robins version looks much different.

Kingtaco is in away status "on hiatus until sometime in april." :(
Could we get this to run on 2.6.24 at least?
I've got several machines & some time for testing...

http://www.open-iscsi.org/bits/open-iscsi-2.0-868-rc1.tar.gz
works flawless for me, an ~x86 ebuild would be extremly cool...
Comment 12 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 16:38:22 UTC
No one interested in helping out?
I hereby offer 25€ (as a private person, not from my company - we don't use/plan to use iSCSI) via IBAN to the one writing/integrating an ebuild for open-iscsi-2.0.865.15 (or open-iscsi-2.0-868-rc1?) that works with kernel 2.6.24-r3 within 4 weeks from now. (Yes, I really WANT to try it and don't like to manually install the package, this systems runs for years without reinstalling and I don't want to start messing around with manually installed packages...I know, 25€ is not much - it's just meant to be some kind of "thank you for your help/time" present because I am unable to write that ebuild and integrate it myself. This is a bit unusual though, I confess...)

kingtaco is in devaway status so he can't do it and I'd really like to play around with it, though.
Comment 13 Stefan de Konink 2008-03-09 16:42:42 UTC
(In reply to comment #12)
> No one interested in helping out?
> I hereby offer 25€ (as a private person, not from my company - we don't
> use/plan to use iSCSI) via IBAN to the one writing/integrating an ebuild for
> open-iscsi-2.0.865.15 (or open-iscsi-2.0-868-rc1?) that works with kernel
> 2.6.24-r3 within 4 weeks from now. (Yes, I really WANT to try it and don't like
> to manually install the package, this systems runs for years without
> reinstalling and I don't want to start messing around with manually installed
> packages...I know, 25€ is not much - it's just meant to be some kind of
> "thank you for your help/time" present because I am unable to write that ebuild
> and integrate it myself. This is a bit unusual though, I confess...)
> 
> kingtaco is in devaway status so he can't do it and I'd really like to play
> around with it, though.
> 

Do you want the kernel modules or only the tools provided by the package itself?
Comment 14 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 17:07:52 UTC
AFAIK I need the (newer?!) modules in the package for 868-r1 and the modules shipped with 2.6.24-r3 work fine with open-iscsi-2.0.865.15?
I'd prefer open-iscsi-2.0.865.15 with "normal" kernel modules then.

I'm not sure though - I just want to get it to work...
Comment 15 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 21:54:17 UTC
Created attachment 145697 [details]
open-iscsi-2.0.868-r1.ebuild
Comment 16 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 21:55:01 UTC
Created attachment 145699 [details]
iscsid-conf.d for open-iscsi-2.0.868-r1.ebuild
Comment 17 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 21:55:24 UTC
Created attachment 145700 [details]
init.d script for open-iscsi-2.0.868-r1.ebuild
Comment 18 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 21:57:24 UTC
Ok, I confess that it took me a few hours (I'm not writing ebuild that often and ran into very strange problems because of fwparam_ibft), but I guess: I DID IT!

- use flags "modules utils debug": you compile without modules and without utils if you don't set the use-flags!
- changed init.d script a lot, now also uses conf.d/iscsid
- deleted dump() in init.d script
- corrected wrong path for iscsid.conf and initiatorname.iscsi in ebuild
- cleaned up ebuild a lot
- fixes bugs #212402 and #195609
Comment 19 Kamil Kisiel 2008-03-09 22:03:02 UTC
(In reply to comment #18)
> Ok, I confess that it took me a few hours (I'm not writing ebuild that often
> and ran into very strange problems because of fwparam_ibft), but I guess: I DID
> IT!
> 
> - use flags "modules utils debug": you compile without modules and without
> utils if you don't set the use-flags!
> - changed init.d script a lot, now also uses conf.d/iscsid
> - deleted dump() in init.d script
> - corrected wrong path for iscsid.conf and initiatorname.iscsi in ebuild
> - cleaned up ebuild a lot
> - fixes bugs #212402 and #195609
> 

Looks good Craig. Now that we're building iscsi-iname, maybe the ebuild can generate an initiator name using that utility and the hostname as template if one doesn't exist already? Most other distros such as Debian do this.
Comment 20 SpanKY gentoo-dev 2008-03-09 22:32:01 UTC
*** Bug 212402 has been marked as a duplicate of this bug. ***
Comment 21 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 22:38:47 UTC
Created attachment 145703 [details]
init.d script for open-iscsi-2.0.868-r1.ebuild
Comment 22 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 22:39:51 UTC
Created attachment 145704 [details]
init.d script for open-iscsi-2.0.868-r1.ebuild
Comment 23 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 22:41:02 UTC
The new init.d fixes #200355.
Comment 24 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 22:45:15 UTC
Kamil, I didn't see your post, I also integreted it in a new ebuild.

iscsi-iname says for my host:
iqn.2005-03.org.open-iscsi:bd76d419c2e
And I have no clue where it gets that from.

>the hostname as template
What do you mean`
Comment 25 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-09 22:46:21 UTC
Uhm, I meant "in a new init.d script", not "in a new ebuild".
Comment 26 Kamil Kisiel 2008-03-09 22:51:31 UTC
Nevermind, I just looked at the init.d file, the way it does it is fine as is. Thanks :)
Comment 27 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-10 21:15:38 UTC
Added base-system@gentoo.org, maybe one of them can have a look and add it to portage?
Comment 28 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-14 21:50:17 UTC
*bump*
Comment 29 Kamil Kisiel 2008-03-24 17:34:57 UTC
If I can make a recommendation to the config files and the ebuild: append -${PV} to the iscsid-conf.d and iscsid-init.d files, and make the same modification in the ebuild. 
Comment 30 Kamil Kisiel 2008-03-24 18:37:25 UTC
One more correction, regarding my previous comment of the automatically generated IQN. I finally got to testing this ebuild today, and the way it generates the IQN is incorrect and does not match the standard.

If you read the relevant section of RFC3720: http://tools.ietf.org/html/rfc3720#section-3.2.6.3 , you will see that an IQN should be generated with the year the domain name was registered, and then the domain name in reverse. I think this is probably too difficult to implement in the init script as this information may not necessarily be available or accessible through DNS at time of install.

The way Debian has solved this problem is that they use the DNS for debian.org, eg: iqn.YYYY-DD.org.debian:<random string> or something to that effect, since they're the ones shipping the initiator.
Comment 31 Stefan de Konink 2008-03-24 18:54:38 UTC
(In reply to comment #30)
> One more correction, regarding my previous comment of the automatically
> generated IQN. I finally got to testing this ebuild today, and the way it
> generates the IQN is incorrect and does not match the standard.
> 
> If you read the relevant section of RFC3720:
> http://tools.ietf.org/html/rfc3720#section-3.2.6.3 , you will see that an IQN
> should be generated with the year the domain name was registered, and then the
> domain name in reverse. I think this is probably too difficult to implement in
> the init script as this information may not necessarily be available or
> accessible through DNS at time of install.
> 
> The way Debian has solved this problem is that they use the DNS for debian.org,
> eg: iqn.YYYY-DD.org.debian:<random string> or something to that effect, since
> they're the ones shipping the initiator.
> 

So what is wrong with the way we (/I) did it now? It takes your hostname and the day you first start the service... if you want to be clever you should have set it yourself and not trust an automatic (out of the box working) name.
Comment 32 Kamil Kisiel 2008-03-24 19:00:16 UTC
Well, the problem is that the auto generated IQN is not RFC compliant. The date is supposed to be the date in which the domain was first registered, and the name should be the reversed domain. So if I registered example.com in June of 2006, the IQN would start as: iqn.2006-06.com.example

Since it's probably too hard to determine this information automatically, I think we should follow Debian's example and have the auto-generated IQN reflect that of the Gentoo.org domain and begin with the prefix  iqn.1999-10.org.gentoo
Comment 33 Stefan de Konink 2008-03-24 19:11:03 UTC
(In reply to comment #32)
> Well, the problem is that the auto generated IQN is not RFC compliant. The date
> is supposed to be the date in which the domain was first registered, and the
> name should be the reversed domain. So if I registered example.com in June of
> 2006, the IQN would start as: iqn.2006-06.com.example

There is no registration date of example.local, only date of first use. Anyway implement what you want :) I think this is the most clean vendor independent solution.
Comment 34 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-24 22:57:57 UTC
* "IQN-Issue":
>Since it's probably too hard to determine this information automatically
It's not. My solution for generating the IQN did not work correctly, FIXED now (RFC3720 compatible), please note that we're the initiator, not the target.

* Naming of the ebuild was wrong (r1 instead of rc1). FIXED.

* Naming of iscsid-conf.d and iscsid-init.d changed, see #29.


Comment 35 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-24 22:58:37 UTC
Created attachment 147185 [details]
open-iscsi-2.0.869.ebuild
Comment 36 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-24 22:59:21 UTC
Created attachment 147186 [details]
iscsid-2.0.869.init.d
Comment 37 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-24 22:59:55 UTC
Created attachment 147187 [details]
iscsid-2.0.869.conf.d
Comment 38 Mike Doty (RETIRED) gentoo-dev 2008-03-25 02:34:56 UTC
I've added 2.0.868_rc1 to the tree and package.masked it for testing.  When I get my hardware back, I'll test and remove from p.mask then.  Thanks for the ebuild and conf/init.d.
Comment 39 Stefan Behte (RETIRED) gentoo-dev Security 2008-03-25 09:53:03 UTC
Thanks!
Fixed topic from -r1 to _rc1.
Comment 40 Stefan Behte (RETIRED) gentoo-dev Security 2008-05-05 19:07:53 UTC
From http://www.open-iscsi.org/: "The current semi-stable release: open-iscsi-2.0-869.tar.gz"

I've confirmed that the above ebuild for 2.0.868_rc1 which I had modified earlier, works flawlessly for open-iscsi-2.0.869 with Kernel 2.6.25-r1 if re-named accordingly!
This shows that I've written a not-so-crappy ebuild. =)

Mike, it would be cool if you could put this into portage (masked) instead of 2.0.868_rc1! It would be also very cool, if you had your gear back and some time for testing, so we can make people happy! :)

Comment 41 Stefan Behte (RETIRED) gentoo-dev Security 2008-05-05 19:10:20 UTC
I noticed that it's possible to rename the attachments, so I did that. :)
Comment 42 Stefan Behte (RETIRED) gentoo-dev Security 2008-05-07 19:25:04 UTC
Topic changed accordingly (forgot it yesterday, sorry for the bugspam).
Comment 43 Stefan Behte (RETIRED) gentoo-dev Security 2008-05-11 16:21:43 UTC
Comment on attachment 147187 [details]
iscsid-2.0.869.conf.d

><HTML><HEAD/><BODY><PRE># /etc/conf.d/iscsid
>
># config file to use
>CONFIG_FILE=/etc/iscsi/iscsid.conf
>
># you need to specify an initiatorname in the file
>INITIATORNAME_FILE=/etc/iscsi/initiatorname.iscsi
>
># options to pass to iscsid
>OPTS="-i ${INITIATORNAME_FILE} -c ${CONFIG_FILE}"
>
></PRE></BODY></HTML>
Comment 44 Stefan Behte (RETIRED) gentoo-dev Security 2008-05-11 16:24:09 UTC
Created attachment 152853 [details]
iscsid-2.0.869.conf.d

CONFIG_FILE was not used in OPTS (which is the parameter for iscsid in the init.d script)
Comment 45 Bill Lewis 2008-05-20 15:32:49 UTC
FYI - the init script fails to start if...

scsi_transport_iscsi
libiscsi
iscsi_tcp

are built into the kernel rather than as modules.  I rebuilt the kernel with these as modules and so far so good, but originally had them built in to the kernel and the init script fails - dmesg was reporting that the module "scsi_transport_iscsi" could not be found when built as kernel, so something is actually looking for this to be a module.

Thanks for the ebuild!
Comment 46 Stefan Behte (RETIRED) gentoo-dev Security 2008-07-05 19:28:56 UTC
Created attachment 159650 [details]
iscsid-2.0.869.2.conf.d
Comment 47 Stefan Behte (RETIRED) gentoo-dev Security 2008-07-05 19:31:02 UTC
Created attachment 159652 [details]
iscsid-2.0.869.2.init.d
Comment 48 Stefan Behte (RETIRED) gentoo-dev Security 2008-07-05 19:31:40 UTC
Created attachment 159654 [details]
open-iscsi-2.0.869.2.ebuild
Comment 49 Stefan Behte (RETIRED) gentoo-dev Security 2008-07-05 19:39:07 UTC
New version, Changelog:

open-iscsi-2.0.869.2.ebuild:
- versionator change

iscsid-2.0.869.2.init.d:
- uses now modprobe -l to check if a modules exists, if so, it tries to load it (I had to use grep, because modprobe -l does always return 0), should fix #45.

Comment 50 Stefan Behte (RETIRED) gentoo-dev Security 2008-08-28 21:51:03 UTC
I've talked to Mike a few days ago on IRC, we can hope that 2.0.869.2 hits the tree in the near future. :)
Comment 51 Stefan Behte (RETIRED) gentoo-dev Security 2008-09-12 19:31:52 UTC
Uhm, could you update it in the tree? The current version is broken! :(
Comment 52 Stefan Behte (RETIRED) gentoo-dev Security 2008-10-05 01:59:16 UTC
This is not an enhancement, open-iscsi from the tree is broken. Changing to "major loss of function" (I guess a package that does not work at all fits into that category).
Comment 53 Laitr Keiows 2008-10-10 01:13:25 UTC
Version 2.0-870-rc3 available.
Comment 54 Stefan Behte (RETIRED) gentoo-dev Security 2008-10-10 13:36:05 UTC
I'll release an ebuild when it's not -rc anymore.
Comment 55 Stefan Behte (RETIRED) gentoo-dev Security 2008-10-19 21:32:43 UTC
The maintainer does not seem to be active anymore: :(
http://cia.vc/stats/author/kingtaco

base-system or anyone else:
Can this be changed to maintainer-wanted (or what would have to happen so that it can)?!
I'm going to provide new ebuilds as attachment here, anyone might feel free to bump this bug, if a new stable version is out.
Comment 56 Marcel Pennewiß 2008-11-06 12:32:51 UTC
Created attachment 170907 [details]
iscsid-2.0.869.2.init.d

changelog:
add support for autologin to iscsi-targets as in debian-init-file
Comment 57 Stefan Behte (RETIRED) gentoo-dev Security 2008-11-07 01:58:26 UTC
Created attachment 170952 [details]
open-iscsi-2.0.870.ebuild
Comment 58 Stefan Behte (RETIRED) gentoo-dev Security 2008-11-07 01:59:48 UTC
Created attachment 170953 [details]
iscsid-2.0.870.conf.d

Added a switch for starting automatic targets when iscsid is started
Comment 59 Stefan Behte (RETIRED) gentoo-dev Security 2008-11-07 02:04:48 UTC
Created attachment 170955 [details]
iscsid-2.0.870.init.d

- lots of small fixes
- additional error handling when loading modules
- added switch for starting automatic targets when iscsid is started
- when stopping iscsid, all targets are sync()ed and disconnected
- new status() method
- Thanks to Marcel!
Comment 60 Stefan Behte (RETIRED) gentoo-dev Security 2008-11-07 02:06:13 UTC
Well, open-iscsi-2.0-870 is out, the 2.0.869.2 ebuild works fine for 2.0.870 on 2.6.25-gentoo-r8 and 2.6.27-r2 (both x86). Please test!

Quickinstall guide for the lazy ones:
Disable iscsi in the Kernel
export PORTAGE_OVERLAY="~/OVERLAY"
mkdir -p ~/OVERLAY/sys-block/
cp -r /usr/portage/sys-block/open-iscsi ~/OVERLAY/sys-block/
cd sys-block/open-iscsi
wget "http://bugs.gentoo.org/attachment.cgi?id=170955" -O files/iscsid-2.0.870.init.d
wget "http://bugs.gentoo.org/attachment.cgi?id=170953" -O files/iscsid-2.0.870.conf.d
wget "http://bugs.gentoo.org/attachment.cgi?id=170952" -O open-iscsi-2.0.870.ebuild
USE="modules utils" ebuild open-iscsi-2.0.870.ebuild digest merge

Have fun!
Comment 61 Marcel Pennewiß 2008-11-07 22:14:26 UTC
Created attachment 171049 [details]
iscsid-2.0.870.conf.d 

changed AUTOSTARTTARGETS from "true/false" to "yes/no" as is customary
Comment 62 Marcel Pennewiß 2008-11-07 22:15:52 UTC
Created attachment 171050 [details]
iscsid-2.0.870.init.d

uses AUTOSTARTTARGETS from conf.d-file in init-script
Comment 63 Tobias Scherbaum (RETIRED) gentoo-dev 2008-11-17 20:59:40 UTC
2.0.870 is finally in CVS. Thanks to $everyone :)
Comment 64 Marcel Pennewiß 2008-12-04 18:29:47 UTC
Created attachment 174253 [details]
iscsid-2.0.870.init.d

init-script including check if /etc/conf.d/iscsid and INITIATOR_FILENAME is not empty exists. if you did not check this and INITIATOR_FILENAME is empty then grep did not get an file to grep through, which cause an deadlock.
Comment 65 Stefan Behte (RETIRED) gentoo-dev Security 2008-12-04 19:30:10 UTC
        if [[ "x${INITIATORNAME_FILE}" = "x" ]]; then

Will match, even if ${INITIATORNAME_FILE} does not exist.

-e might be better than -f for the filechecks.
Comment 66 Stefan Behte (RETIRED) gentoo-dev Security 2008-12-04 19:31:44 UTC
Created attachment 174255 [details]
iscsid-2.0.870.init.d
Comment 67 Stefan Behte (RETIRED) gentoo-dev Security 2008-12-06 15:10:54 UTC
Could "someone" *cough* commit the new init.d? ;)
Comment 68 Tobias Scherbaum (RETIRED) gentoo-dev 2008-12-06 16:58:10 UTC
(In reply to comment #67)
> Could "someone" *cough* commit the new init.d? ;)
> 

tested the changes and committed as -r1. Thanks guys! :)
Comment 69 Stefan Behte (RETIRED) gentoo-dev Security 2009-03-18 23:15:13 UTC
Created attachment 185469 [details]
open-iscsi-2.0.870.3.ebuild

Clean up with the files/*.init.d and files/*.conf.d situation: if there is a special version for the ${PV}, use that (for downwards compatibility).

Also, do not update /etc/iscsi/initiatorname.iscsi, it's no use.
Comment 70 Stefan Behte (RETIRED) gentoo-dev Security 2009-03-18 23:18:27 UTC
Created attachment 185471 [details]
iscsid-2.0.870.3-init.d

Just create ${INITIATORNAME_FILE}, if it's not there or does not contain the needed ^InitiatorName=iqn... line.
Comment 71 Stefan Behte (RETIRED) gentoo-dev Security 2009-03-18 23:20:01 UTC
Created attachment 185472 [details]
iscsid-2.0.870.3.init.d

Sorry, wrong $Header: line.
Comment 72 Stefan Behte (RETIRED) gentoo-dev Security 2009-03-18 23:22:58 UTC
files/iscsid-2.0.870.init.d-r1 needs to be moved to files/iscsid-2.0.870-r1.init.d

http://bugs.gentoo.org/attachment.cgi?id=185472 has to be saved as files/iscsid-init.d (or files/iscsid-2.0.870.3.init.d but that will fill the filesdir on longterm...)
Comment 73 Tobias Scherbaum (RETIRED) gentoo-dev 2009-03-20 16:23:47 UTC
2.0.870.3 in CVS. Next time file a fresh'n'shiny new bug - please! ;)