Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 659916 (CVE-2018-14036) - <sys-apps/accountsservice-0.6.50: Improper path validation of user icon files allows for spoofing via symlink (CVE-2018-14036)
Summary: <sys-apps/accountsservice-0.6.50: Improper path validation of user icon files...
Status: RESOLVED FIXED
Alias: CVE-2018-14036
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Security
URL: http://www.openwall.com/lists/oss-sec...
Whiteboard: B3 [noglsa cve]
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 06:11 UTC by Florian Schuhmacher
Modified: 2018-11-24 22:14 UTC (History)
2 users (show)

See Also:
Package list:
sys-apps/accountsservice-0.6.50
Runtime testing required: ---
stable-bot: sanity-check+


Attachments
bumped ebuild: accountsservice-0.6.49 (accountsservice-0.6.49.ebuild,1.47 KB, text/plain)
2018-07-07 09:55 UTC, Attila Tóth
no flags Details
upstreams patch addressing the security issue (user_change_icon_file_authorized_cb-fix-insufficient.patch,2.36 KB, patch)
2018-07-07 09:56 UTC, Attila Tóth
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Schuhmacher 2018-07-03 06:11:04 UTC
GNOME AccountsService does not properly validate the filepaths of user icon
files in the user.c:user_change_icon_file_authorized_cb() function. An attacker
could exploit this by providing a crafted path via  D-Bus message and replacing
it with a symlink. Third party applications that trust this path can
potentially read from its location as root and try to interpret it as an image
file.


Upstream Bug:

https://bugs.freedesktop.org/show_bug.cgi?id=107085

Gentoo Security Scout
Florian Schuhmacher
Comment 1 Attila Tóth 2018-07-07 09:55:16 UTC
Created attachment 538680 [details]
bumped ebuild: accountsservice-0.6.49

Note, that current accountsservice in the tree lags behind upstreams. For this reason the proposed patch doesn't apply cleanly.
The ebuild can be bumped with only a simple modification, that the elogind patch is no longer needed.
Comment 2 Attila Tóth 2018-07-07 09:56:19 UTC
Created attachment 538682 [details, diff]
upstreams patch addressing the security issue

Applies cleanly on the bumped version only.
Comment 3 GLSAMaker/CVETool Bot gentoo-dev 2018-08-06 21:13:32 UTC
CVE-2018-14036 (https://nvd.nist.gov/vuln/detail/CVE-2018-14036):
  Directory Traversal with ../ sequences occurs in AccountsService before
  0.6.50 because of an insufficient path check in
  user_change_icon_file_authorized_cb() in user.c.
Comment 4 Larry the Git Cow gentoo-dev 2018-08-17 00:12:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=131c0448ac92a8571ccfff21de931777f9a1405c

commit 131c0448ac92a8571ccfff21de931777f9a1405c
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-08-17 00:01:10 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-08-17 00:12:21 +0000

    sys-apps/accountsservice: security bump to 0.6.50
    
    Bug: https://bugs.gentoo.org/659916
    Package-Manager: Portage-2.3.46, Repoman-2.3.10

 sys-apps/accountsservice/Manifest                  |  1 +
 .../accountsservice/accountsservice-0.6.50.ebuild  | 58 ++++++++++++++++++++++
 2 files changed, 59 insertions(+)
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-18 22:51:10 UTC
ppc stable
Comment 6 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-08-19 01:36:10 UTC
amd64 stable
Comment 7 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-08-19 01:37:13 UTC
amd64 stable
Comment 8 Sergei Trofimovich (RETIRED) gentoo-dev 2018-08-21 19:43:33 UTC
ppc64 stable
Comment 9 Markus Meier gentoo-dev 2018-08-22 04:57:18 UTC
arm stable
Comment 10 Thomas Deutschmann (RETIRED) gentoo-dev 2018-08-24 01:40:46 UTC
x86 stable
Comment 11 Aaron Bauman (RETIRED) gentoo-dev 2018-11-24 22:14:40 UTC
tree is clean