Summary: | realtime-lsm Makefile assumes no KBUILD_OUTPUT variable | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sophie Hamilton <gentoo-bugs> |
Component: | [OLD] Core system | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED WORKSFORME | ||
Severity: | major | CC: | lambacck, maintainer-needed, sound |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
New patch that removes the check that makes the build not work
New ebuild to use patch provided in attachment 70774 this patch fixed it for me |
Description
Sophie Hamilton
2005-06-12 06:12:05 UTC
Created attachment 70774 [details, diff]
New patch that removes the check that makes the build not work
If this patch is used insead of the kmisc.patch-0.8.2_pre... patch then the
config check which is already being done by the ebuild is skipped. With the
check skipped, it will merge successfully.
Created attachment 70775 [details] New ebuild to use patch provided in attachment 70774 [details, diff] Presumably, though, with the check skipped it might be able to be emerged on kernels without the Security Capabilities option compiled as a module? As the warning states, it won't work on such kernels. A better option would seem to be to leave the warning as-is, and dynamically set KERNEL_DIR depending on whether KBUILD_OUTPUT is set or not, I think. I'm not very familiar witht Makefile syntax, however, so I'm not sure how this would be done. Oh, sorry, I didn't notice that the check was done in the ebuild. My bad; that should be a good solution. Please, remove jnc from metadata.xml wrt Bug 64582. Both maintainers listen in metadata.xml retired, whoover picks this up - please remove them. Created attachment 85646 [details, diff]
this patch fixed it for me
this patch fixed it for me
There was already a patch given earlier that fixes it. Your patch wouldn't work for anybody that doesn't use KBUILD_OUTPUT. antarus@kyoto ~/code/pkgcore/bin $ ./pquery --revdep=sys-apps/realtime-lsm antarus@kyoto ~/code/pkgcore/bin $ old Alec needs to follow his own friggin guidelines; adding maintainer-needed to cc. Errr why isn't sound@g.o on this bug? Sound is the maintainer as per metadata, and I'll gladly see to take care of this myself if needed. Is this a bug still at all? I can't see it be a problem now, it doesn't grep over anything directly anymore. Can we just close this? (In reply to comment #11) > Errr why isn't sound@g.o on this bug? Sound is the maintainer as per metadata, Probably because sound was added 6 months ago while thing bug is over two years old? http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/realtime-lsm/metadata.xml?r1=1.5&r2=1.6 Not to mention that this thing is totally not working - see Bug 154892. Been so for years. Since opening this bug, I've reinstalled Gentoo and haven't yet needed to reinstall this, but then I haven't tried to use if for heavy music work at all yet. As such, I can't comment on whether it works now or not. I was pretty sure it worked after the patch that Chris gave in comment #1 and comment #2, though, but my memory is a bit fuzzy there, so I could be wrong. The thing is totally working for me, I got jack working realtime last night by using a (tweaked, I admit, but just to provide a sensible default configuration) realtime-lsm module. I'll see to handle bug #154892, then let's close this bug for now, unless someone has still the problem. Reassigning to sound, no need to treeclean something that works, for now at least. Works for me at least. I don't believe the problem identified in this bug has been fixed, though. I don't use KBUILD_OUTPUT in my setup now at the moment, so I can't easily test it, but the changes from Chris' patch haven't been incorporated and the Makefile still refers to KERNEL_DIR so I'm assuming that this still won't work for those using KBUILD_OUTPUT. |