Bug 928599

Summary:	sys-apps/portage install-qa-check.d/60bash-completion warns about grub helper file
Product:	Portage Development	Reporter:	Mike Gilbert <floppym>
Component:	Unclassified	Assignee:	Portage team <dev-portage>
Status:	RESOLVED FIXED
Severity:	normal	CC:	xxc3ncoredxx
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=526138 https://bugs.gentoo.org/show_bug.cgi?id=928869 https://github.com/gentoo/portage/pull/1316
Whiteboard:
Package list:		Runtime testing required:	---

Description Mike Gilbert gentoo-dev

2024-04-04 20:40:27 UTC

sys-boot/grub-2.12-r3 installs /usr/share/bash-completion/completions/grub. 

Portage emits the following warning:

 * QA Notice: Problems with installed bash completions were found:
 *
 *      grub: does not define any completions (failed to source?).

This file does not define any completions, but is sourced by several other files that do define completions. I believe the warning is not valid.

Comment 1 Oskari Pirhonen 2024-04-06 00:53:51 UTC

Maybe there should be a way to mark something as a helper lib?

Comment 2 Larry the Git Cow gentoo-dev

2024-04-25 02:59:16 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=8bbdc814485d2990630d4217f68830fe1148801c

commit 8bbdc814485d2990630d4217f68830fe1148801c
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-04-24 15:35:32 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-04-24 15:35:32 +0000

    Remove QA warning when no bash completions are found
    
    This triggers unwanted warnings in at least two known cases.
    
    Bug: https://bugs.gentoo.org/928599
    Bug: https://bugs.gentoo.org/928869
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 bin/install-qa-check.d/60bash-completion | 3 ---
 1 file changed, 3 deletions(-)