Bug 928051

Summary:	net-ftp/linksys-tftp: last rites request
Product:	Gentoo Linux	Reporter:	NHO <jy6x2b32pie9>
Component:	Current packages	Assignee:	Embedded Gentoo Team <embedded>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, jy6x2b32pie9, richard, sam
Priority:	Normal	Keywords:	PATCH, PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/36399
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	Update tftpsubs.c to be Standard C compliant. Update tftp.c to be Standard C compliant. Update main.c to be Standard C compliant.

Description NHO 2024-03-28 13:00:59 UTC

This software is written in K&R C.
It's home URL page is dead.
It is used to manage hardware that don't exist any more.
Gentoo is only distribution that bundles this package.
It haven't been mentioned anywhere in internet for at least 8 years.

It also has bugs and would stop building in relative future.

Reproducible: Always

Comment 1 Richard Narron 2024-04-16 22:33:25 UTC

Created attachment 890953 [details, diff]
Update tftpsubs.c to be Standard C compliant.

Comment 2 Richard Narron 2024-04-16 22:34:20 UTC

Created attachment 890954 [details, diff]
Update tftp.c to be Standard C compliant.

Comment 3 Richard Narron 2024-04-16 22:35:16 UTC

Created attachment 890955 [details, diff]
Update main.c to be Standard C compliant.

Comment 4 Richard Narron 2024-04-16 22:51:05 UTC

The attached patches make linksys-tftp Standard C compliant.

I will add these patches to the Slackware port build:

http://slackbuilds.org/repository/15.0/network/linksys-tftp/?search=linksys-tftp

Another way of doing what linksys-tftp does is to use the atftp program with the -P option.

Brand new WRT54GL routers are available on amazon.com.  Ebay has lots of used ones.

Comment 5 Larry the Git Cow gentoo-dev

2024-04-29 05:32:04 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9041943e464b5d219db2101df1eebcab907e4b60

commit 9041943e464b5d219db2101df1eebcab907e4b60
Author:     NHOrus <jy6x2b32pie9@yahoo.com>
AuthorDate: 2024-04-24 10:59:21 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2024-04-29 05:18:39 +0000

    net-ftp/linksys-tftp: Port to C99, fix compile on musl systems
    
    Primary patch by Richard Narron from bug 928051
    Musl fix by me.
    
    Closes: https://bugs.gentoo.org/928051
    Closes: https://bugs.gentoo.org/714212
    Closes: https://bugs.gentoo.org/874582
    Closes: https://bugs.gentoo.org/885699
    Closes: https://bugs.gentoo.org/913577
    Signed-off-by: NHOrus <jy6x2b32pie9@yahoo.com>
    Closes: https://github.com/gentoo/gentoo/pull/36399
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 .../files/linksys-tftp-1.2.1-r4-c99-port.patch     | 572 +++++++++++++++++++++
 net-ftp/linksys-tftp/linksys-tftp-1.2.1-r4.ebuild  |  31 ++
 2 files changed, 603 insertions(+)