Bug 927212 – media-libs/libdv-1.0.0-r4 fails to compile: dv.c:224:90: error: passing argument 5 of _dv_quant_88_inverse_x86 from incompatible pointer type [-Wincompatible-pointer-types]

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2024-03-17 20:37:57 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libdv-1.0.0-r4 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003

[Comment 1 Agostino Sarubbo 2024-03-17 20:37:58 UTC]

Created attachment 887854 [details]
build.log

build log and emerge --info

[Comment 2 Michael Cook 2024-07-19 17:46:38 UTC]

https://koji.fedoraproject.org/koji/buildinfo?buildID=2496481

Fedora did update the libdv-pic patch which is rather old (#121871)

https://bugzilla.redhat.com/show_bug.cgi?id=2261310 relevant RHBZ

[Comment 3 Nuitari 2024-09-17 01:19:59 UTC]

Created attachment 903168 [details, diff]
Fixes the incompatible pointer type in quant.c

The RH patch was missing the fix for quant.c, I've attached mine here. It compiles, but I don't have a way of testing it. 

Signed-off-by: Stephane Bakhos <[e-mail]>

[Comment 4 Kaukov 2024-10-20 01:27:36 UTC]

Created attachment 906393 [details, diff]
Untested patch that fixes the build errors

A patch based on the above suggestions. Fixes the build errors, but I'm not sure of the actual performance/feature impact.

I had to add 2 more changes to `dv.c` as it also had build errors due to the same issue.

[Comment 5 Larry the Git Cow 2025-01-04 16:17:19 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c2b24edc01ad5bee67c6535b9ff25c827c55a13

commit 0c2b24edc01ad5bee67c6535b9ff25c827c55a13
Author:     Sam James <[e-mail]>
AuthorDate: 2025-01-04 16:10:13 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-01-04 16:14:28 +0000

    media-libs/libdv: update EAPI 7 -> 8, better C99 fix, refresh PIC patch
    
    * Drop -std=gnu89 and patch it up (thanks to folks on bug #927212 for digging
      into the history and such)
    
    * Refresh PIC patch with that from Fedora (originally from us, I think)
    
    * ... and tweak the PIC patch for a C99 fix.
    
    Closes: https://bugs.gentoo.org/927212
    Signed-off-by: Sam James <[e-mail]>

 media-libs/libdv/Manifest              |  1 +
 media-libs/libdv/libdv-1.0.0-r6.ebuild | 67 ++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7deee8cade4462ff88a83acfe0a996c158af32a

commit b7deee8cade4462ff88a83acfe0a996c158af32a
Author:     Sam James <[e-mail]>
AuthorDate: 2025-01-04 15:53:08 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2025-01-04 15:54:59 +0000

    media-libs/libdv: misc fixes
    
    * Build with -std=gnu89 (bug #927212)
    
      I'm going to take a look at the patches attached there and may apply
      them in a new revision, but I wanted to get this out with the various
      fixes so far in stable first.
    
    * Force bfd (bug #910291)
    
    * Build with -fno-strict-aliasing -fno-aggressive-loop-optimizations (bug #877709)
    
    Bug: https://bugs.gentoo.org/877709
    Bug: https://bugs.gentoo.org/927212
    Closes: https://bugs.gentoo.org/910291
    Signed-off-by: Sam James <[e-mail]>

 .../libdv/{libdv-1.0.0-r4.ebuild => libdv-1.0.0-r5.ebuild}     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)