Summary: | sys-auth/polkit: fails with test useflag error: implicit declaration of function ‘print_indent’ [-Wimplicit-function-declaration] | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Christopher Fore <csfore> |
Component: | Current packages | Assignee: | Freedesktop bugs <freedesktop-bugs> |
Status: | RESOLVED INVALID | ||
Severity: | normal | Keywords: | PullRequest |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=930715 https://github.com/gentoo/gentoo/pull/36527 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 870412 | ||
Attachments: | build.log |
Description
Christopher Fore
2024-02-24 18:55:50 UTC
Please keep in mind you should not set USE=test manually and it's near-meaningless. You need to do FEATURES=test. (In reply to Sam James from comment #1) > Please keep in mind you should not set USE=test manually and it's > near-meaningless. > > You need to do FEATURES=test. The ebuild has: # https://gitlab.freedesktop.org/polkit/polkit/-/issues/181 for test restriction RESTRICT="!test? ( test ) test" # This seems to be fixed with 121? #if [[ ${PV} == *_p* ]] ; then # RESTRICT="!test? ( test )" #else # # Tests currently don't work with meson in the dist tarballs. See # # https://gitlab.freedesktop.org/polkit/polkit/-/issues/144 # RESTRICT="test" #fi so I'll call this INVALID. (In reply to Sam James from comment #1) > Please keep in mind you should not set USE=test manually and it's > near-meaningless. > > You need to do FEATURES=test. Ah my apologies, I did run into this with FEATURES=test on another box but I saw it hit this when using test in USE to pull in the test deps. While reading this, I did remember that there is an emerge flag to pull in test deps but it had been a while since having to pull in test deps. w.r.t the test error, I think what does needs to be done is removing `$(meson_use test tests)` (or disabling it somehow?) since this will always be set regardless if the test phase is restricted, right? The error itself is in building mocklibc and not *actually* running the tests. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1521587bb323049922809b7756705792564041a7 commit 1521587bb323049922809b7756705792564041a7 Author: Kostadin Shishmanov <kocelfc@tutanota.com> AuthorDate: 2024-05-03 11:37:06 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-03 12:12:54 +0000 sys-auth/polkit: fix tests Reenable tests with FEATURES="test" and backport test build error fix for C99 compilers. Bug: https://bugs.gentoo.org/925440 Signed-off-by: Kostadin Shishmanov <kocelfc@tutanota.com> Closes: https://github.com/gentoo/gentoo/pull/36527 Signed-off-by: Sam James <sam@gentoo.org> sys-auth/polkit/files/polkit-124-c99-fixes.patch | 111 +++++++++++++++++++++++ sys-auth/polkit/polkit-124-r1.ebuild | 13 +-- 2 files changed, 113 insertions(+), 11 deletions(-) |