Bug 925100

Summary:	sys-devel/bison: Add --without-libtextstyle option
Product:	Gentoo Linux	Reporter:	Raul Rangel <rrangel>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	UNCONFIRMED ---
Severity:	normal	CC:	rrangel, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=740754
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	My failed attempt at adding the flag. Working patch! gnulib libtextstyle patch

Description Raul Rangel 2024-02-20 18:52:42 UTC

See https://bugs.gentoo.org/740754#c6

`libtextstyle` is optional for bison. The configure script probes for it and links to the library if available, or doesn't if it's not. Ideally we would guard this behavior behind the `gettext` USE flag so we can conditionally control the `gettext` dependency.

Reproducible: Always

Comment 1 Raul Rangel 2024-02-20 18:54:02 UTC

Created attachment 885534 [details, diff]
My failed attempt at adding the flag.

I think we need to add the flag to `libtextstyle-optional.m4` instead of the `configure.ac`. I'm not sure where `libtextstyle-optional.m4` came from though.

Comment 2 Raul Rangel 2024-02-20 23:50:39 UTC

Created attachment 885556 [details, diff]
Working patch!

I had to modify the file in the `m4` directory, not sure if that's allowed or if those are auto generated.

Comment 3 Raul Rangel 2024-02-21 21:02:48 UTC

Created attachment 885658 [details, diff]
gnulib libtextstyle patch

I sent the following patch to gnulib upstream. The email hasn't shown up in the list archive though: https://lists.gnu.org/archive/html/bug-gnulib/2024-02/index.html

Unfortunately I don't think there is a patch to send to upstream to bison. I think they just need to cut a new release that pulls in the latest gnulib. I'll send a PR for the bison ebuild.

Comment 4 Raul Rangel 2024-02-22 16:28:23 UTC

Just FYI, here is the PR: https://github.com/gentoo/gentoo/pull/35479