Summary: | sci-libs/rocSPARSE-5.7.1-r1 - CMake Error at clients/cmake_install.cmake:46 (file): file INSTALL cannot find rocsparse_common.yaml | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Joseph McElroy <gbug.35p6f> |
Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
Status: | UNCONFIRMED --- | ||
Severity: | normal | CC: | anton, bratzmeister, gentoo, lockalsash |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build log
bugfix for the install step in the case of USE="benchmark -test" rocSPARSE-5.7.1: patch for USE=test hipSPARSE-5.7.1: patch for USE=test |
Description
Joseph McElroy
2024-02-13 23:45:32 UTC
Created attachment 887400 [details, diff]
bugfix for the install step in the case of USE="benchmark -test"
I reproduced this bug with USE="benchmark -test" (kernel 5.15.147, clang 17.0.6, gcc 12.3.1_p20240112). It is caused by additional files (compared to ROCm 5.1.3) which are going to be installed together with benchmark. However, these files are not previously copied to a proper directory (clients/staging) - there is a missing CMake dependency on rocsparse-common, which is present for test, but not for benchmark. I'm attaching a proposed patch, together with patches for USE=test. The benchmark patch (if correct) is probably worth to be reported upstream. USE=test appears to be broken in both rocSPARSE-5.7.1 and hipSPARSE-5.7.1, so I'm fixing it as well. In summary, I'm adding only only the PATCH entries to the ebuilds (see below). I verified that the new and old ebuilds produce identical installation for USE="-benchmark -test", so a revbump is perhaps not necessary. I'm not doing this as pull request since I'm not experienced with CMake, and also I was not sure why the analogs of remove-matrices-unpacking patches were not kept in version 5.7.1, as compared to version 5.1.3. So please review the proposed patches, and modify if necessary. Signed-off-by: Anton Repko <anton@a-repko.sk> =================================================================== --- sci-libs/rocSPARSE/rocSPARSE-5.7.1-r2.ebuild.orig +++ sci-libs/rocSPARSE/rocSPARSE-5.7.1-r2.ebuild @@ -60,8 +60,8 @@ S="${WORKDIR}/rocSPARSE-rocm-${PV}" -PATCHES=( -) +PATCHES=( "${FILESDIR}/${PN}-5.7.1-remove-matrices-unpacking.patch" + "${FILESDIR}/${PN}-5.7.1-cmake-benchmark-deps.patch" ) python_check_deps() { if use test; then --- hipSPARSE-5.7.1.ebuild.orig +++ hipSPARSE-5.7.1.ebuild @@ -51,6 +51,8 @@ S="${WORKDIR}/hipSPARSE-rocm-${PV}" +PATCHES=( "${FILESDIR}/${PN}-5.7.1-remove-matrices-unpacking.patch" ) + src_prepare() { sed -e "s/PREFIX hipsparse//" \ -e "/<INSTALL_INTERFACE/s,include,include/hipsparse," \ Created attachment 887401 [details, diff]
rocSPARSE-5.7.1: patch for USE=test
Created attachment 887402 [details, diff]
hipSPARSE-5.7.1: patch for USE=test
|