Summary: | kde-apps/kate-lib-23.08.4 w/o precompiled headers: apps/lib/ktexteditor_utils.h:97:21: error: ‘QWidgetList’ does not name a type; did you mean ‘QWidget’? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Richard <richard+gentoo-bugzilla> |
Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arsen, remy, roland, sam, scott, stillcompiling |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://invent.kde.org/utilities/kate/-/issues/116 | ||
See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=920845 https://invent.kde.org/utilities/kate/-/merge_requests/1387 https://bugs.gentoo.org/show_bug.cgi?id=921935 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
emerge --info '=kde-apps/kate-lib-23.08.4::gentoo'
emerge -pqv '=kde-apps/kate-lib-23.08.4::gentoo' build.log patch adding the missing includes updated ebuild. |
Description
Richard
2024-01-10 18:18:15 UTC
Created attachment 881865 [details]
emerge --info '=kde-apps/kate-lib-23.08.4::gentoo'
Created attachment 881866 [details]
emerge -pqv '=kde-apps/kate-lib-23.08.4::gentoo'
Created attachment 881867 [details]
build.log
I ran into the same problem...masking the package on my system for now to see if I can work around the brokenness that way. Masking is unfortunately not helping since KDE -> Kate -> hard-depends on it Masking the package was more about getting the rest of an "emerge @world" to complete without error. Adding MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF" to /etc/portage/make.conf will allow kate-lib to build; it basically negates the change made in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3867345f8c2d9f24157508bc6372f479a82cf33f. i reckon they forgot an include, when building with PCH, cmake will auto-'-include' the pch file they generated Me too, except the message in my case is 'unknown type name "QtWidgetList"' and similar for QtUrl. I'm using clang, if that's relevant. that's the same error Arsen Arsenović, you were right. Its a 2 line fix. Took longer to remember how to format the filenames for portage than to make the correction. Created attachment 881995 [details, diff]
patch adding the missing includes
Created attachment 881996 [details]
updated ebuild.
uploaded patch and ebuild. Works on my machine
Same patch is needed / works for kate, kate-addons and kwrite. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=caa998c2d10707501e91293540c25936b5fd8ae9 commit caa998c2d10707501e91293540c25936b5fd8ae9 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 09:21:26 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 09:21:50 +0000 kde-apps/kate-lib: fix no-PCH build Closes: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kate-lib/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++ kde-apps/kate-lib/kate-lib-23.08.4.ebuild | 4 ++ 2 files changed, 62 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6016f0772a62899d691b16037b4ec41289ba9e0e commit 6016f0772a62899d691b16037b4ec41289ba9e0e Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 09:20:24 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 09:21:50 +0000 kde-apps/kwrite: fix no-PCH build Closes: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kwrite/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++++ kde-apps/kwrite/kwrite-23.08.4.ebuild | 4 ++ 2 files changed, 62 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b875567958605ab7edc00b638fcd3769e55a11a6 commit b875567958605ab7edc00b638fcd3769e55a11a6 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 09:19:39 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 09:21:49 +0000 kde-apps/kate-addons: fix no-PCH build Closes: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> .../kate-addons/files/kate-23.08.4-no-pch.patch | 58 ++++++++++++++++++++++ kde-apps/kate-addons/kate-addons-23.08.4.ebuild | 4 ++ 2 files changed, 62 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bde55b940d90885e1b8f51c8e6b4f0d87e6eea97 commit bde55b940d90885e1b8f51c8e6b4f0d87e6eea97 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 09:18:32 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 09:21:49 +0000 kde-apps/kate: fix no-PCH build Closes: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kate/files/kate-23.08.4-no-pch.patch | 58 +++++++++++++++++++++++++++ kde-apps/kate/kate-23.08.4.ebuild | 4 ++ 2 files changed, 62 insertions(+) It's still not working. The error is now different (in kde-apps/kate-addons-23.08.4 now): In file included from /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateprojectview.h:10, from /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateprojectview.cpp:8: /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:5: warning: "QT_VERSION" is not defined, evaluates to 0 [-Wundef] 10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) | ^~~~~~~~~~ /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:18: warning: "QT_VERSION_CHECK" is not defined, evaluates to 0 [-Wundef] 10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) | ^~~~~~~~~~~~~~~~ /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:10:34: error: missing binary operator before token "(" 10 | #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0) | ^ /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:279:92: error: ‘KTextEditor::ModificationInterface’ has not been declared 279 | void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason); | ^~~~~~~~~~~~~~~~~~~~~ /extension/tmp_portage/portage/kde-apps/kate-addons-23.08.4/work/kate-23.08.4/addons/project/kateproject.h:279:136: error: expected ‘,’ or ‘...’ before ‘reason’ 279 | void slotModifiedOnDisk(KTextEditor::Document *document, bool isModified, KTextEditor::ModificationInterface::ModifiedOnDiskReason reason); | ^~~~~~ I can't confirm the last comment by Roland. I just synced, removed the temporary MYCMAKEARGS patch by Scott and built kate, kate-addons and kate-lib. All three built just fine. I can confirm the comment from Roland, on my side kate-addons has the same problem with the QT version check. Alright, could one of you please open a new bug at https://packages.gentoo.org/packages/kde-apps/kate-addons? The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcc58d11dfd83610f3f3df8e98e7f9ebf593b830 commit fcc58d11dfd83610f3f3df8e98e7f9ebf593b830 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 16:58:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 16:58:59 +0000 kde-apps/kate-lib: further no-pch fixes Closes: https://bugs.gentoo.org/921935 Bug: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kate-lib/files/kate-23.08.4-no-pch.patch | 56 ++++++++++++++++++----- 1 file changed, 44 insertions(+), 12 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3ff857b56efb6bb7c011432f5e41544471b5591 commit c3ff857b56efb6bb7c011432f5e41544471b5591 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 16:58:39 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 16:58:39 +0000 kde-apps/kwrite: further no-pch fixes Closes: https://bugs.gentoo.org/921935 Bug: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kwrite/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++------ 1 file changed, 44 insertions(+), 12 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ebfa971a8b829712595c108ab9f3523cead261ca commit ebfa971a8b829712595c108ab9f3523cead261ca Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 16:58:21 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 16:58:21 +0000 kde-apps/kate-addons: further no-pch fixes Closes: https://bugs.gentoo.org/921935 Bug: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> .../kate-addons/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++----- 1 file changed, 44 insertions(+), 12 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb commit fefe28433c4c61ce7f13aaf3fa4aab292e49d4cb Author: Sam James <sam@gentoo.org> AuthorDate: 2024-01-12 16:57:32 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-12 16:57:32 +0000 kde-apps/kate: further no-pch fixes Closes: https://bugs.gentoo.org/921935 Bug: https://bugs.gentoo.org/921720 Signed-off-by: Sam James <sam@gentoo.org> kde-apps/kate/files/kate-23.08.4-no-pch.patch | 56 +++++++++++++++++++++------ 1 file changed, 44 insertions(+), 12 deletions(-) |