Bug 920846

Summary:	cmake.eclass: pass -DFETCHCONTENT_FULLY_DISCONNECTED=ON
Product:	Gentoo Linux	Reporter:	Sam James <sam>
Component:	Eclasses	Assignee:	Gentoo KDE team <kde>
Status:	CONFIRMED ---
Severity:	normal	CC:	base-system, ionen
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/kde/pull/973 https://github.com/gentoo/gentoo/pull/34731 https://github.com/Homebrew/brew/pull/17075 https://gitlab.kitware.com/cmake/cmake/-/issues/25946 https://github.com/Homebrew/brew/issues/17187 https://gitlab.kitware.com/cmake/cmake/-/issues/26149
Whiteboard:
Package list:		Runtime testing required:	---

Description Sam James archtester

2023-12-28 03:28:17 UTC

CMake supports -DFETCHCONTENT_FULLY_DISCONNECTED=ON to stop it from attempting to connect to the network.

We already pass an analogue for this for Meson. We could _maybe_ have some variable which ::gentoo ebuilds shouldn't set if overlays would find it useful to override it, but then they could already do it via mycmakeargs.

Anyway, the reason to do this is:
* better error messages when trying to download something
* faster failure
* not relying on network-sandbox which isn't available on e.g. prefix

Comment 1 Larry the Git Cow gentoo-dev

2024-01-04 10:09:12 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=b279c4b7ebcf150673919f8d1b84565a2662e358

commit b279c4b7ebcf150673919f8d1b84565a2662e358
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:14:53 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-03 22:15:13 +0000

    cmake.eclass: Set FETCHCONTENT_FULLY_DISCONNECTED=ON
    
    Bug: https://bugs.gentoo.org/920846
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)

Comment 2 Larry the Git Cow gentoo-dev

2024-01-10 11:01:27 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca877f01a331bd239db8b6878c7f92fa85e02dae

commit ca877f01a331bd239db8b6878c7f92fa85e02dae
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:14:53 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-10 11:00:52 +0000

    cmake.eclass: Set FETCHCONTENT_FULLY_DISCONNECTED=ON
    
    Closes: https://bugs.gentoo.org/920846
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comment 3 Larry the Git Cow gentoo-dev

2024-07-03 00:54:32 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9b0fbdcf296c0bf013b58637f2a87a5bdc125e52

commit 9b0fbdcf296c0bf013b58637f2a87a5bdc125e52
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-03 00:53:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-03 00:53:20 +0000

    Revert "cmake.eclass: Set FETCHCONTENT_FULLY_DISCONNECTED=ON"
    
    This reverts commit ca877f01a331bd239db8b6878c7f92fa85e02dae.
    
    Unfortunately, the CMake developers learned of Homebrew doing this
    and decided to "block" this functionality because they felt it was abuse.
    
    We now have to implement a "provider" instead...
    
    Bug: https://bugs.gentoo.org/920846
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/cmake.eclass | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)