Bug 920845

Summary:	cmake.eclass: pass -DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON
Product:	Gentoo Linux	Reporter:	Sam James <sam>
Component:	Eclasses	Assignee:	Gentoo KDE team <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	base-system, ionen, negril.nx+gentoo, toolchain
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/kde/pull/973 https://github.com/gentoo/gentoo/pull/34731 https://bugs.gentoo.org/show_bug.cgi?id=921731 https://bugs.gentoo.org/show_bug.cgi?id=921720 https://bugs.gentoo.org/show_bug.cgi?id=921935 https://bugs.gentoo.org/show_bug.cgi?id=921938 https://bugs.gentoo.org/show_bug.cgi?id=921939
Whiteboard:
Package list:		Runtime testing required:	---

Description Sam James archtester

2023-12-28 03:26:21 UTC

We should try pass -DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF in cmake.eclass to avoid more use of PCH.

Our policy in Gentoo is to avoid pch given how buggy it is in compilers.

Comment 1 Larry the Git Cow gentoo-dev

2024-01-04 10:09:12 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=6717d6e786e7db9121eece74dfb3cfebfaed592d

commit 6717d6e786e7db9121eece74dfb3cfebfaed592d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:17:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-03 22:18:31 +0000

    cmake.eclass: Set CMAKE_DISABLE_PRECOMPILE_HEADERS=ON
    
    Bug: https://bugs.gentoo.org/920845
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)

Comment 2 Larry the Git Cow gentoo-dev

2024-01-10 11:01:26 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3867345f8c2d9f24157508bc6372f479a82cf33f

commit 3867345f8c2d9f24157508bc6372f479a82cf33f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-01-03 22:17:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-01-10 11:00:52 +0000

    cmake.eclass: Set CMAKE_DISABLE_PRECOMPILE_HEADERS=ON
    
    Closes: https://bugs.gentoo.org/920845
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/cmake.eclass | 1 +
 1 file changed, 1 insertion(+)