Description
David Duchesne
2023-11-19 11:15:16 UTC
add gtk4 flag while your at it. also looks like allot of deps aren't in tree yet, will probably take a while. Created attachment 875262 [details]
handbrake-1.7.0.ebuild
Created attachment 875263 [details]
handbrake-1.7.0.ebuild
once ffmpeg 6.1 lands in tree I will be able to finish testing
also found some bugs in previous build version
(In reply to Gino McCarty from comment #3) > Created attachment 875263 [details] > handbrake-1.7.0.ebuild > > once ffmpeg 6.1 lands in tree I will be able to finish testing > > also found some bugs in previous build version I think two big problems come from - x265 library: I cannot find r12776 "version" - the libdovi library that isn't in the portage tree Without the former I'm not able to build 1.7.x branch. Iade (In reply to Iade Gesso from comment #4) > (In reply to Gino McCarty from comment #3) > > Created attachment 875263 [details] > > handbrake-1.7.0.ebuild > > > > once ffmpeg 6.1 lands in tree I will be able to finish testing > > > > also found some bugs in previous build version > > I think two big problems come from > - x265 library: I cannot find r12776 "version" > - the libdovi library that isn't in the portage tree > > Without the former I'm not able to build 1.7.x branch. > > > Iade UPDATE Even installing x265-9999 and disabling dolby use flag, I cannot build Handbrake 1.7.x due to some error related to x265 (I will post the error after my system will finish to rebuild all the installed packages). (In reply to Iade Gesso from comment #5) > (In reply to Iade Gesso from comment #4) > > (In reply to Gino McCarty from comment #3) > > > Created attachment 875263 [details] > > > handbrake-1.7.0.ebuild > > > > > > once ffmpeg 6.1 lands in tree I will be able to finish testing > > > > > > also found some bugs in previous build version > > > > I think two big problems come from > > - x265 library: I cannot find r12776 "version" > > - the libdovi library that isn't in the portage tree > > > > Without the former I'm not able to build 1.7.x branch. > > > > > > Iade > > UPDATE > > Even installing x265-9999 and disabling dolby use flag, I cannot build > Handbrake 1.7.x due to some error related to x265 (I will post the error > after my system will finish to rebuild all the installed packages). UPDATE 2: I just created an ebuild for libdovi. You can find it in my small overlay: https://github.com/iadegesso/howl-gentoo-overlay Anyway, even with HandBrake 1.7.3 the build process dies for a mismatching data structure in x265 code... I'm not able to find where I could get the x265 r12776 source code... Created attachment 886545 [details]
Latest (March 2024) 1.7.x proposed .ebuild
(In reply to Iade Gesso from comment #6) > (In reply to Iade Gesso from comment #5) > > (In reply to Iade Gesso from comment #4) > > > (In reply to Gino McCarty from comment #3) > > > > Created attachment 875263 [details] > > > > handbrake-1.7.0.ebuild > > > > > > > > once ffmpeg 6.1 lands in tree I will be able to finish testing > > > > > > > > also found some bugs in previous build version > > > > > > I think two big problems come from > > > - x265 library: I cannot find r12776 "version" > > > - the libdovi library that isn't in the portage tree > > > > > > Without the former I'm not able to build 1.7.x branch. > > > > > > > > > Iade > > > > UPDATE > > > > Even installing x265-9999 and disabling dolby use flag, I cannot build > > Handbrake 1.7.x due to some error related to x265 (I will post the error > > after my system will finish to rebuild all the installed packages). > > UPDATE 2: > > I just created an ebuild for libdovi. You can find it in my small overlay: > https://github.com/iadegesso/howl-gentoo-overlay > > Anyway, even with HandBrake 1.7.3 the build process dies for a mismatching > data structure in x265 code... I'm not able to find where I could get the > x265 r12776 source code... You may need to apply HandBrake's own contrib patches to both media-libs/x265 and media-video/ffmepg (more about this below), and then rebuild x265 and ffmpeg before handbrake. I rebuilt also media-libs/libheif (no custom patches needed, though). NOTE: HandBrake 1.7.3 seems to be not ready yet to support GTK4 (aka 'gtk4' use flag). =media-libs/x265-3.5-r3::gentoo + HandBrake's own contrib patches =media-video/ffmpeg-6.1.1-r4::gentoo + HandBrake's own contrib patches Gentoo's user patches wiki: https://wiki.gentoo.org/wiki//etc/portage/patches https://github.com/HandBrake/HandBrake/releases/download/1.7.3/HandBrake-1.7.3-source.tar.bz2 Put HandBrake-1.7.3/contrib/x265/A04-ambient-viewing-enviroment-sei.patch in /etc/portage/patches/media-libs/x265-3.5 The above patch requires to strip two elements, i.e. `patch -p2 < ...`. You may need to edit the patch and change: - all ' a/source/' in ' a/' - all ' b/source/' in ' b/' Put HandBrake-1.7.3/contrib/ffmpeg/A14-avcodec-add-ambient-viewing-environment-packet-side-.patch HandBrake-1.7.3/contrib/ffmpeg/A15-avformat-mov-add-support-for-amve-ambient-viewing-en.patch in /etc/portage/patches/media-video/ffmpeg-6.1.1 Rebuild both x265 and ffmpeg (I also rebuilt libheif). handbrake-1.7.3.ebuild by Iade Gesso: https://bugs.gentoo.org/attachment.cgi?id=886545 # emerge -v --info handbrake ... media-video/handbrake-1.7.3::localrepo was built with the following: USE="fdk gstreamer gtk3 numa nvenc x265 -dolby -gtk4" ABI_X86="(64) ... Compiling with the 'dolby' use flag enabled (aka media-libs/libdovi), I get 'undefined reference' errors: =media-libs/libdovi-3.2.0: https://github.com/iadegesso/howl-gentoo-overlay/tree/master/media-libs/libdovi /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ./libhb/libhandbrake.a(rpu.o): in function `rpu_work': rpu.c:(.text+0xea): undefined reference to `dovi_parse_unspec62_nalu' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x13d): undefined reference to `dovi_rpu_free' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x1e5): undefined reference to `dovi_write_unspec62_nalu' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x249): undefined reference to `dovi_data_free' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x25d): undefined reference to `dovi_rpu_get_vdr_dm_data' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x357): undefined reference to `dovi_rpu_set_active_area_offsets' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x36d): undefined reference to `dovi_rpu_free_vdr_dm_data' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x385): undefined reference to `dovi_rpu_get_header' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x39a): undefined reference to `dovi_rpu_free_header' /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: rpu.c:(.text+0x40e): undefined reference to `dovi_convert_rpu_with_mode' Thanks, - mehw (In reply to mehw from comment #8) > (In reply to Iade Gesso from comment #6) > > (In reply to Iade Gesso from comment #5) > > > (In reply to Iade Gesso from comment #4) > > > > (In reply to Gino McCarty from comment #3) > > > > > Created attachment 875263 [details] > > > > > handbrake-1.7.0.ebuild > > > > > > > > > > once ffmpeg 6.1 lands in tree I will be able to finish testing > > > > > > > > > > also found some bugs in previous build version > > > > > > > > I think two big problems come from > > > > - x265 library: I cannot find r12776 "version" > > > > - the libdovi library that isn't in the portage tree > > > > > > > > Without the former I'm not able to build 1.7.x branch. > > > > > > > > > > > > Iade > > > > > > UPDATE > > > > > > Even installing x265-9999 and disabling dolby use flag, I cannot build > > > Handbrake 1.7.x due to some error related to x265 (I will post the error > > > after my system will finish to rebuild all the installed packages). > > > > UPDATE 2: > > > > I just created an ebuild for libdovi. You can find it in my small overlay: > > https://github.com/iadegesso/howl-gentoo-overlay > > > > Anyway, even with HandBrake 1.7.3 the build process dies for a mismatching > > data structure in x265 code... I'm not able to find where I could get the > > x265 r12776 source code... > > You may need to apply HandBrake's own contrib patches to both > media-libs/x265 and media-video/ffmepg (more about this below), and then > rebuild x265 and ffmpeg before handbrake. I rebuilt also media-libs/libheif > (no custom patches needed, though). > > NOTE: HandBrake 1.7.3 seems to be not ready yet to support GTK4 (aka 'gtk4' > use flag). > > > =media-libs/x265-3.5-r3::gentoo + HandBrake's own contrib patches > =media-video/ffmpeg-6.1.1-r4::gentoo + HandBrake's own contrib patches > > Gentoo's user patches wiki: https://wiki.gentoo.org/wiki//etc/portage/patches > > https://github.com/HandBrake/HandBrake/releases/download/1.7.3/HandBrake-1.7. > 3-source.tar.bz2 > > Put > HandBrake-1.7.3/contrib/x265/A04-ambient-viewing-enviroment-sei.patch > in > /etc/portage/patches/media-libs/x265-3.5 > > The above patch requires to strip two elements, i.e. `patch -p2 < ...`. You > may need to edit the patch and change: > - all ' a/source/' in ' a/' > - all ' b/source/' in ' b/' > > Put > HandBrake-1.7.3/contrib/ffmpeg/A14-avcodec-add-ambient-viewing-environment- > packet-side-.patch > HandBrake-1.7.3/contrib/ffmpeg/A15-avformat-mov-add-support-for-amve-ambient- > viewing-en.patch > in > /etc/portage/patches/media-video/ffmpeg-6.1.1 > > Rebuild both x265 and ffmpeg (I also rebuilt libheif). > > > handbrake-1.7.3.ebuild by Iade Gesso: > https://bugs.gentoo.org/attachment.cgi?id=886545 > > # emerge -v --info handbrake > ... > media-video/handbrake-1.7.3::localrepo was built with the following: > USE="fdk gstreamer gtk3 numa nvenc x265 -dolby -gtk4" ABI_X86="(64) > ... > > > Compiling with the 'dolby' use flag enabled (aka media-libs/libdovi), I get > 'undefined reference' errors: > > =media-libs/libdovi-3.2.0: > https://github.com/iadegesso/howl-gentoo-overlay/tree/master/media-libs/ > libdovi > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > ./libhb/libhandbrake.a(rpu.o): in function `rpu_work': > rpu.c:(.text+0xea): undefined reference to `dovi_parse_unspec62_nalu' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x13d): undefined reference to `dovi_rpu_free' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x1e5): undefined reference to `dovi_write_unspec62_nalu' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x249): undefined reference to `dovi_data_free' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x25d): undefined reference to `dovi_rpu_get_vdr_dm_data' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x357): undefined reference to > `dovi_rpu_set_active_area_offsets' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x36d): undefined reference to `dovi_rpu_free_vdr_dm_data' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x385): undefined reference to `dovi_rpu_get_header' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x39a): undefined reference to `dovi_rpu_free_header' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > rpu.c:(.text+0x40e): undefined reference to `dovi_convert_rpu_with_mode' > > > Thanks, > - mehw Hi, in my case, after patching x265 and ffmpeg (and rebuilt them correctly), I get the following error (full trace in the attachments): > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: ./libhb/libhandbrake.a(common.o): undefined reference to symbol 'x265_api_query' > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libx265.so.199: error adding symbols: DSO missing from command line > collect2: error: ld returned 1 exit status > make: *** [../test/module.rules:49: HandBrakeCLI] Error 1 > make: Leaving directory '/tmp/portage/media-video/handbrake-1.7.3-r900/work/HandBrake-1.7.3/build' Iade Created attachment 887851 [details] Comment 9 error log Created attachment 887852 [details] Comment 9: emerge --info =media-video/handbrake-1.7.3 (In reply to Iade Gesso from comment #9) > Hi, > in my case, after patching x265 and ffmpeg (and rebuilt them correctly), I > get the following error (full trace in the attachments): > > > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > ./libhb/libhandbrake.a(common.o): undefined reference to symbol > 'x265_api_query' > > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > /usr/lib64/libx265.so.199: error adding symbols: DSO missing from command > line > > collect2: error: ld returned 1 exit status > > make: *** [../test/module.rules:49: HandBrakeCLI] Error 1 > > make: Leaving directory > '/tmp/portage/media-video/handbrake-1.7.3-r900/work/HandBrake-1.7.3/build' > > > Iade Hi, What .ebuild are you using? Are you compiling with `ebuild handbrake-*.ebuild compile` or with `emerge -v --ask handbrake`? If you are using the former, you might miss some dependencies, or not enforcing the right versions... In your error.log there's no '-lx265', which is a requirement for 'x265_api_query', also the 'x265' use flag needs to be enabled along with 'numa' (.ebuild: REQUIRED_USE="numa? ( x265 )"): /usr/bin/g++ -pipe -Wl,-S -Wl,-O1 -Wl,--as-needed -fmessage-length=0 -Wall -Wno-format-truncation -g0 -O3 -mfpmath=sse -msse2 -O2 -pipe -march=haswell -msse4 -msse4.1 -msse4.2 -mcx16 -fomit-frame-pointer -mfpmath=sse -fno-lto -msahf -f\ stack-protector-strong -D_FORTIFY_SOURCE=2 -I./libhb/ -Iinclude -I/usr/include/libxml2 -o HandBrakeCLI -Wl,--start-group test/parsecsv.o test/test.o ./libhb/libhandbrake.a -Llib -lass -lavformat -lavfilter -lavcodec -lavutil -lswresamp\ le -lpostproc -lmp3lame -ldvdnav -ldvdread -lfribidi -lswscale -lvpx -ltheoraenc -ltheoradec -lvorbis -lvorbisenc -logg -lx264 -lbluray -lfreetype -lxml2 -lbz2 -lz -ljansson -lharfbuzz -lopus -lspeex -llzma -ldav1d -lturbojpeg -lzimg -\ lSvtAv1Enc -lfontconfig -lpthread -ldl -lm -lnuma -Wl,--end-group Could you please check the following: $ equery depends x265 * These packages depend on x265: ... media-video/handbrake-1.7.3 (x265 ? >=media-libs/x265-3.5-r2[10bit,12bit,numa?]) ... $ scanelf -l -s x265_api_query | grep x265_api_query ET_DYN x265_api_query /usr/lib64/libx265.so.199 ET_DYN x265_api_query /usr/lib/libx265.so.199 Also, in your error.log I see: /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: warning: libSvtAv1Enc.so.1, needed by /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../lib64/libavcodec.so, may conflict with libSvtAv1Enc.so.2 Could you please also try these: $ eix -Ic media-libs/svt-av1 [I] media-libs/svt-av1 (2.0.0-r100(0/2){tbz2}[1]@03/15/2024): Scalable Video Technology for AV1 (SVT-AV1 Encoder and Decoder) [1] "stefantalpalaru" /var/db/repos/stefantalpalaru $ ls /usr/lib*/libSvtAv1* /usr/lib64/libSvtAv1Dec.so /usr/lib64/libSvtAv1Dec.so.0 /usr/lib64/libSvtAv1Dec.so.0.8.7 /usr/lib64/libSvtAv1Enc.so /usr/lib64/libSvtAv1Enc.so.2 /usr/lib64/libSvtAv1Enc.so.2.0.0 PS: You might need to install >=media-libs/svt-av1-1.7 from the "stefantalpalaru" overlay. Let us know, thanks. Created attachment 887875 [details] media-video/handbrake-1.7.3.ebuild Remember to apply HandBrake's contrib patches to media-video/ffmpeg and media-libs/x265 when compiling >=media-video/handbrake-1.7.0: https://bugs.gentoo.org/917591#c8 Created attachment 887876 [details, diff] media-video/handbrake-1.7.3: custom user's patch x265_api_query-libhb-fix.patch Put custom user's patches in '/etc/portage/patches/media-video/handbrake-1.7.3' when using the attached media-video/handbrake-1.7.3.ebuild: https://bugs.gentoo.org/attachment.cgi?id=887875 Please, also read the comments inside all .patch files. Created attachment 887877 [details, diff]
media-video/handbrake-1.7.3: custom user's patch x265_api_query-test-fix.patch
Created attachment 887878 [details, diff]
media-video/handbrake-1.7.3: custom user's patch build-contrib-include-directory-fix.patch
(In reply to mehw from comment #12) > (In reply to Iade Gesso from comment #9) > > Hi, > > in my case, after patching x265 and ffmpeg (and rebuilt them correctly), I > > get the following error (full trace in the attachments): > > > > > > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > > ./libhb/libhandbrake.a(common.o): undefined reference to symbol > > 'x265_api_query' > > > > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > > /usr/lib64/libx265.so.199: error adding symbols: DSO missing from command > > line > > > collect2: error: ld returned 1 exit status > > > make: *** [../test/module.rules:49: HandBrakeCLI] Error 1 > > > make: Leaving directory > > '/tmp/portage/media-video/handbrake-1.7.3-r900/work/HandBrake-1.7.3/build' > > > > > > Iade > > Hi, > > What .ebuild are you using? > > Are you compiling with `ebuild handbrake-*.ebuild compile` or with `emerge > -v --ask handbrake`? If you are using the former, you might miss some > dependencies, or not enforcing the right versions... > > In your error.log there's no '-lx265', which is a requirement for > 'x265_api_query', also the 'x265' use flag needs to be enabled along with > 'numa' (.ebuild: REQUIRED_USE="numa? ( x265 )"): > > /usr/bin/g++ -pipe -Wl,-S -Wl,-O1 -Wl,--as-needed -fmessage-length=0 -Wall > -Wno-format-truncation -g0 -O3 -mfpmath=sse -msse2 -O2 -pipe -march=haswell > -msse4 -msse4.1 -msse4.2 -mcx16 -fomit-frame-pointer -mfpmath=sse -fno-lto > -msahf -f\ > stack-protector-strong -D_FORTIFY_SOURCE=2 -I./libhb/ -Iinclude > -I/usr/include/libxml2 -o HandBrakeCLI -Wl,--start-group test/parsecsv.o > test/test.o ./libhb/libhandbrake.a -Llib -lass -lavformat -lavfilter > -lavcodec -lavutil -lswresamp\ > le -lpostproc -lmp3lame -ldvdnav -ldvdread -lfribidi -lswscale -lvpx > -ltheoraenc -ltheoradec -lvorbis -lvorbisenc -logg -lx264 -lbluray > -lfreetype -lxml2 -lbz2 -lz -ljansson -lharfbuzz -lopus -lspeex -llzma > -ldav1d -lturbojpeg -lzimg -\ > lSvtAv1Enc -lfontconfig -lpthread -ldl -lm -lnuma -Wl,--end-group > > Could you please check the following: > > $ equery depends x265 > * These packages depend on x265: > ... > media-video/handbrake-1.7.3 (x265 ? > >=media-libs/x265-3.5-r2[10bit,12bit,numa?]) > ... > > $ scanelf -l -s x265_api_query | grep x265_api_query > ET_DYN x265_api_query /usr/lib64/libx265.so.199 > ET_DYN x265_api_query /usr/lib/libx265.so.199 > > > Also, in your error.log I see: > > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: > warning: libSvtAv1Enc.so.1, needed by > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../lib64/libavcodec.so, may > conflict with libSvtAv1Enc.so.2 > > Could you please also try these: > > $ eix -Ic media-libs/svt-av1 > [I] media-libs/svt-av1 (2.0.0-r100(0/2){tbz2}[1]@03/15/2024): Scalable Video > Technology for AV1 (SVT-AV1 Encoder and Decoder) > [1] "stefantalpalaru" /var/db/repos/stefantalpalaru > > $ ls /usr/lib*/libSvtAv1* > /usr/lib64/libSvtAv1Dec.so > /usr/lib64/libSvtAv1Dec.so.0 > /usr/lib64/libSvtAv1Dec.so.0.8.7 > /usr/lib64/libSvtAv1Enc.so > /usr/lib64/libSvtAv1Enc.so.2 > /usr/lib64/libSvtAv1Enc.so.2.0.0 > > PS: You might need to install >=media-libs/svt-av1-1.7 from the > "stefantalpalaru" overlay. > > > Let us know, thanks. Hi, I already patched both x265 and ffmpeg, and I have svt-av1-2.0.0 installed from xarblu-overlay. I emerge the package using emerge -q handbrake, and the ebuild I use is your own for 1.7.0 version renamed into handbrake-1.7.3.ebuild I will try your latest patches. Iade (In reply to Iade Gesso from comment #17) > Hi, > I already patched both x265 and ffmpeg, and I have svt-av1-2.0.0 installed > from xarblu-overlay. > I emerge the package using emerge -q handbrake, and the ebuild I use is your > own for 1.7.0 version renamed into handbrake-1.7.3.ebuild > > I will try your latest patches. > > > Iade Your follow-up is much appreciated. Thank you. (In reply to mehw from comment #18) > (In reply to Iade Gesso from comment #17) > > > Hi, > > I already patched both x265 and ffmpeg, and I have svt-av1-2.0.0 installed > > from xarblu-overlay. > > I emerge the package using emerge -q handbrake, and the ebuild I use is your > > own for 1.7.0 version renamed into handbrake-1.7.3.ebuild > > > > I will try your latest patches. > > > > > > Iade > > Your follow-up is much appreciated. Thank you. Ok, now it builds, but only using gtk3 use flag (with gtk4 it builds but not installs) and disabling dolby use flag. I will test the dolby use flag soon. Thanks, Iade Created attachment 887993 [details, diff] media-video/handbrake-1.7.3: custom user's patch libdovi-ld.patch (In reply to Iade Gesso from comment #19) > Ok, now it builds, but only using gtk3 use flag (with gtk4 it builds but not > installs) and disabling dolby use flag. I will test the dolby use flag soon. > > > Thanks, > > Iade About the 'dolby' use flag, you may need the attached libdovi-ld.patch, since '-ldovi' is required to compile properly. Also, HandBrake v1.7.3 seems to be not ready yet to support GTK4. make/configure.py:1414: # Option hidden as GUI is not currently buildable with GTK4 grp.add_argument( '--enable-gtk4', default=False, action='store_true', help=argparse.SUPPRESS ) (In reply to mehw from comment #20) > Created attachment 887993 [details, diff] [details, diff] > media-video/handbrake-1.7.3: custom user's patch libdovi-ld.patch > > (In reply to Iade Gesso from comment #19) > > Ok, now it builds, but only using gtk3 use flag (with gtk4 it builds but not > > installs) and disabling dolby use flag. I will test the dolby use flag soon. > > > > > > Thanks, > > > > Iade > > About the 'dolby' use flag, you may need the attached libdovi-ld.patch, > since '-ldovi' is required to compile properly. > > Also, HandBrake v1.7.3 seems to be not ready yet to support GTK4. > > make/configure.py:1414: > # Option hidden as GUI is not currently buildable with GTK4 > > grp.add_argument( '--enable-gtk4', default=False, action='store_true', > help=argparse.SUPPRESS ) Ok, it works! Thanks. Iade (In reply to Iade Gesso from comment #21) > Ok, it works! > > Thanks. > > Iade You're welcome ;) https://github.com/HandBrake/HandBrake/commit/ba6c1c1636329d74184dec9a71666a3be166d932 indicates this will need meson as well in order to build the gui. (In reply to Eli Schwartz from comment #23) > https://github.com/HandBrake/HandBrake/commit/ > ba6c1c1636329d74184dec9a71666a3be166d932 indicates this will need meson as > well in order to build the gui. Ok, but the GUI issue is only if I try to build it using GTK4... otherwise, if I stay with GTK3 the GUI is build correctly. Anyway, I will add the missing meson dependency to the experimental .ebuild file. Iade Created attachment 889164 [details]
1.7.3 ebuild with meson dependency
|