Bug 91540

Summary:	kde-base/kdelibs with optional dnotify
Product:	Gentoo/Alt	Reporter:	Diego Elio Pettenò (RETIRED) <flameeyes>
Component:	Other	Assignee:	Gentoo/BSD Team <bsd+disabled>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kde
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	93587
Attachments:	kdelibs-3.4.0-r2.patch

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2005-05-05 01:59:07 UTC

Currently kdelibs forces enabled dnotify, which is a linux-specific thing. As we have kernel_linux useflag now, the attached patch enables it only on linux systems, so that we are able to compile kde on g/fbsd.

I've also added a fam useflag to make optional the fam support, also if that is going to be enabled by quite everyone, having it optional seems a better solution to me.

HTH, Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-05-05 01:59:32 UTC

Created attachment 58113 [details, diff]
kdelibs-3.4.0-r2.patch

Comment 2 Dan Armak (RETIRED) gentoo-dev

2005-05-25 13:34:39 UTC

Where's the kernel_linux flag? It's not in use.desc and repoman says it's 
invalid, and there' no other ebuild in the tree that uses it... Do we actually 
have it, or is it just planned? 
If/when it exists we can apply the dnotify patch. 
 
As for fam, despite the use.defaults entry, a new system won't have it enabled, 
and I wouldn't want to change the effective default behaviour to disabling fam 
support :-/

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev

2005-05-25 13:48:14 UTC

kernel_* is USE_EXPANDed from KERNEL variable in make.defaults. 
 
About fam.. yeah that's also true... maybe that can just be avoided for now.

Comment 4 Gregorio Guidi (RETIRED) gentoo-dev

2005-05-26 01:40:49 UTC

Fixed the kernel_linux thing in kdelibs-3.4.1.  
I agree that we should not add fam unless it becomes a default use flag.