Bug 915097 – app-portage/getuto-1.8 fails tests

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Arthur Zamarin 2023-10-03 05:12:45 UTC]

Created attachment 872073 [details]
build.log

Caught on multiple devboxes. MIght be wrong configuration of container, so keep in mind.

> ++ '[' -z yes ']'
> ++ case "$1" in
> ++ return 0
> ++ hash tput
> +++ tput cuu1
> tput: No value for $TERM and no -T specified
> +++ tput cuf 72
> tput: No value for $TERM and no -T specified
> ++ ENDCOL=
> make: *** [Makefile:7: check] Error 2

[Comment 1 Sam James 2023-10-03 05:14:12 UTC]

Looks like it's failing inside gentoo-functions. Does it pass with gentoo-functions-9999?

[Comment 2 Arthur Zamarin 2023-10-03 05:22:15 UTC]

(In reply to Sam James from comment #1)
> Looks like it's failing inside gentoo-functions. Does it pass with
> gentoo-functions-9999?

It passes now, but I'm unsure if it was the real fix?

The tattoo cluster runs this all in a systemd service run, so maybe it just doesn't have any $TERM defined. I don't think I can test it well without polluting stuff, so unsure.

When running the test suite directly using `ebuild ... test` or `tatt -b ...` it works even with <gentoo-functions-9999, so I guess this is indeed tattoo making life hard.

[Comment 3 Andreas K. Hüttel 2023-10-03 08:55:23 UTC]

(In reply to Arthur Zamarin from comment #2)
> (In reply to Sam James from comment #1)
> > Looks like it's failing inside gentoo-functions. Does it pass with
> > gentoo-functions-9999?
> 
> It passes now, but I'm unsure if it was the real fix?
> 
> The tattoo cluster runs this all in a systemd service run, so maybe it just
> doesn't have any $TERM defined. I don't think I can test it well without
> polluting stuff, so unsure.
> 
> When running the test suite directly using `ebuild ... test` or `tatt -b
> ...` it works even with <gentoo-functions-9999, so I guess this is indeed
> tattoo making life hard.

Well, a relatively easy fix is not to use gentoo-functions if TERM is not defined.

That said, IMHO the bug is in gentoo-functions (which should catch this case).

[Comment 4 Larry the Git Cow 2023-10-03 13:54:03 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89384561bdab75c3719d1cd1794d2e244451cb34

commit 89384561bdab75c3719d1cd1794d2e244451cb34
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2023-10-03 13:53:28 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2023-10-03 13:53:51 +0000

    app-portage/getuto: drop 1.6, 1.7
    
    Closes: https://bugs.gentoo.org/915097
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 app-portage/getuto/Manifest          |  2 --
 app-portage/getuto/getuto-1.6.ebuild | 50 ------------------------------------
 app-portage/getuto/getuto-1.7.ebuild | 50 ------------------------------------
 3 files changed, 102 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc1dc8c57247b242fca2733e854fd45c52bc126a

commit cc1dc8c57247b242fca2733e854fd45c52bc126a
Author:     Andreas K. Hüttel <[e-mail]>
AuthorDate: 2023-10-03 13:53:09 +0000
Commit:     Andreas K. Hüttel <[e-mail]>
CommitDate: 2023-10-03 13:53:48 +0000

    app-portage/getuto: add 1.9
    
    Closes: https://bugs.gentoo.org/915097
    Signed-off-by: Andreas K. Hüttel <[e-mail]>

 app-portage/getuto/Manifest          |  1 +
 app-portage/getuto/getuto-1.9.ebuild | 50 ++++++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)