Bug 911481 – dev-libs/capstone-9999 adds -Werror flag on its own (9999-SYSTEM)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-07-29 19:42:41 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/capstone-9999 adds -Werror flag on its own (9999-SYSTEM).
Discovered on: amd64 (internal ref: 9999_tinderbox)

NOTE:
(9999-SYSTEM) in the summary means that the bug was found on a STANDARD machine that tries the 9999 version of the ebuild. While bugs about 9999 version make sense until certain point, you should see it as a way to know in advance what will have in the future release.
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

[Comment 1 Agostino Sarubbo 2023-07-29 19:42:44 UTC]

Created attachment 866637 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

[Comment 2 Larry the Git Cow 2023-08-28 04:05:45 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8ca69dcc50e60f841b3288e662a388800f6fd58

commit f8ca69dcc50e60f841b3288e662a388800f6fd58
Author:     Mario Haustein <[e-mail]>
AuthorDate: 2023-08-27 16:47:20 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-08-28 04:03:46 +0000

    dev-libs/capstone: don't add -Werror to compiler options
    
    Closes: https://bugs.gentoo.org/911481
    Signed-off-by: Mario Haustein <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/32478
    Signed-off-by: Sam James <[e-mail]>

 dev-libs/capstone/capstone-9999.ebuild             |  7 +++++++
 dev-libs/capstone/files/capstone-9999-werror.patch | 13 +++++++++++++
 2 files changed, 20 insertions(+)