| Summary: | www-client/firefox: specify versioned clang compiler name for compatibility with distcc | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Maciej S. Szmigiero <mail> |
| Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PATCH |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=870085 https://bugs.gentoo.org/show_bug.cgi?id=908993 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | fix | ||
Created attachment 864404 [details, diff]
fix
This looks good, I'll incorporate and test the change on next version bump if that's okay? Same with TB. > I'll incorporate and test the change on next version bump if that's okay?
Sure, thanks.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=03ee26bcb2e7fece7f04f18f39c3cd153f06ce5d commit 03ee26bcb2e7fece7f04f18f39c3cd153f06ce5d Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-07-04 16:30:32 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-07-04 16:32:02 +0000 www-client/firefox: add 115.0 - drop ~ppc64 keyword due to patches not applying before a rebase. Bug: https://bugs.gentoo.org/908297 Bug: https://bugs.gentoo.org/908979 Bug: https://bugs.gentoo.org/908412 Bug: https://bugs.gentoo.org/908992 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 101 +++ www-client/firefox/firefox-115.0.ebuild | 1458 +++++++++++++++++++++++++++++++ 2 files changed, 1559 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5448a004c202c6bd69f3999db480a17537d9a8f commit b5448a004c202c6bd69f3999db480a17537d9a8f Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2023-07-19 07:45:41 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-07-19 07:48:06 +0000 www-client/firefox: add 115.0.3 - note: this is the ESR version. - a great opportunity to push 115-esr into the tree as 115.0.3 only contains Windows-related fixes. This allows syncing 115+:rapid and 115+:esr in the tree when going forward for any ebuild-related updates. - pushed as unkeyworded because this is still a testing version. Keywords will be added when Mozilla encourages esr users to update from 102 into 115. The next major ESR, 115.1.0, will be package.masked. Closes: https://bugs.gentoo.org/903061 Closes: https://bugs.gentoo.org/908992 Closes: https://bugs.gentoo.org/907963 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 101 +++ www-client/firefox/firefox-115.0.3.ebuild | 1406 +++++++++++++++++++++++++++++ 2 files changed, 1507 insertions(+) |
This is the equivalent of #870085 but for www-client/firefox. Clang version override done by the llvm.eclass has no effect on distcc build servers since it overrides the used LLVM version by prepending the path to the chosen version to PATH. This PATH editing happens only on the machine actually running emerge. On the other hand, distcc build servers still run such distributed builds by using what their preferred clang version is (usually the latest one). This breaks in case the version chosen by the llvm.eclass on the machine running emerge isn't the one preferred on the distcc build servers - especially in the LTO case since linking object files generated by different clang versions isn't supported. The fix for this is simple - instead of overriding CC to unversioned "${CHOST}-clang" in the ebuild override it to "${CHOST}-clang-${version_clang}" instead. Same with CXX. I can confirm that with the above change I can successfully build the package in such distcc environment, even with LTO on.