Summary: | sys-libs/libblockdev, sys-apps/nvme-cli, sys-libs/libnvme sparc keyword request | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Gentoo Linux | Reporter: | Nick Bowler <nbowler> | ||||||
Component: | Keywording | Assignee: | Gentoo's Team for Core System packages <base-system> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | normal | CC: | asturm, marecki, matoro_gentoo, sam | ||||||
Priority: | Normal | Keywords: | CC-ARCHES, PullRequest | ||||||
Version: | unspecified | Flags: | nattka:
sanity-check+
|
||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
See Also: |
https://github.com/linux-nvme/libnvme/pull/732 https://github.com/gentoo/gentoo/pull/34304 |
||||||||
Whiteboard: | |||||||||
Package list: |
sys-libs/libblockdev ~sparc
sys-apps/nvme-cli ~sparc
sys-libs/libnvme ~sparc
|
Runtime testing required: | --- | ||||||
Bug Depends on: | |||||||||
Bug Blocks: | 930256 | ||||||||
Attachments: |
|
Description
Nick Bowler
2023-06-18 14:49:27 UTC
Thanks! Sanity check failed:
> sys-apps/nvme-cli-2.4-r2
> depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
> sys-libs/libhugetlbfs:=
> rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
> sys-libs/libhugetlbfs:=
Sanity check failed:
> sys-apps/nvme-cli-2.5
> depend ~sparc stable profile default/linux/sparc/17.0 (8 total)
> sys-libs/libhugetlbfs:=
> rdepend ~sparc stable profile default/linux/sparc/17.0 (8 total)
> sys-libs/libhugetlbfs:=
All sanity-check issues have been resolved libhugetlbfs remains horribly broken w/ newer glibc, so let's mask it here The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a43629357609b4fc45137c24dc47dd68d7947e85 commit a43629357609b4fc45137c24dc47dd68d7947e85 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-07-09 02:30:56 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-07-09 02:31:24 +0000 profiles/arch/base: mask nvme-cli[hugepages] Needs <glibc-2.34. Bug: https://bugs.gentoo.org/806079 Bug: https://bugs.gentoo.org/908793 Signed-off-by: Sam James <sam@gentoo.org> profiles/arch/base/package.use.mask | 4 ++++ profiles/base/package.use.stable.mask | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) Did you run the test suite for libnvme/nvme-cli? glaubitz from Debian mentioned a lot of alignment problems. Fortunatley, they're all fixed in master as upstream recently adopted ubsan. See https://github.com/linux-nvme/libnvme/pull/732. I didn't run the test previously but libnvme-1.5-r2 and nvme-cli-2.5 tests indeed fail: libnvme: Summary of Failures: 2/14 mi-mctp FAIL 0.14s killed by signal 10 SIGBUS 6/14 NBFT-auto-ipv6 FAIL 0.21s exit status 1 7/14 NBFT-dhcp-ipv6 FAIL 0.25s exit status 1 8/14 NBFT-rhpoc FAIL 0.20s exit status 1 9/14 NBFT-static-ipv4 FAIL 0.20s exit status 1 10/14 NBFT-static-ipv4-discovery FAIL 0.20s exit status 1 11/14 NBFT-static-ipv6 FAIL 0.21s exit status 1 Ok: 5 Expected Fail: 2 Fail: 7 Unexpected Pass: 0 Skipped: 0 Timeout: 0 nvme-cli: Summary of Failures: 5/5 argconfig_parse FAIL 0.11s exit status 1 Ok: 4 Expected Fail: 0 Fail: 1 Unexpected Pass: 0 Skipped: 0 Timeout: 0 Not sure what exact features these are testing. This tool clearly has a gigantic number of capabilities so I guess there might be some feature that maybe won't work. I am only using nvme-pci and only really interested in basic administration like retrieving the error logs which all seems to be ok. Created attachment 874613 [details]
sys-libs/libnvme-1.5-r2 build log w/ FEATURES=test
Created attachment 874614 [details]
sys-apps/nvme-cli-2.5 build log w/ FEATURES=test
Wow, that patch actually does fix it. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1aed182daa661b3e80faa5dabe8aa55d742ff2f4 commit 1aed182daa661b3e80faa5dabe8aa55d742ff2f4 Author: Matoro Mahri <matoro_gentoo@matoro.tk> AuthorDate: 2023-12-16 00:21:31 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-12-16 02:43:10 +0000 sys-libs/libnvme: add ubsan fixes patch See: https://github.com/linux-nvme/libnvme/pull/732 Bug: https://bugs.gentoo.org/908793 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: https://github.com/gentoo/gentoo/pull/34304 Signed-off-by: Sam James <sam@gentoo.org> sys-libs/libnvme/Manifest | 1 + sys-libs/libnvme/libnvme-1.6-r2.ebuild | 84 ++++++++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+) sparc done all arches done (In reply to Sam James from bug #910073#c2) > farming sparc out to bug 908793 Seems like that never happened? sparc done all arches done |