Bug 908541

Summary:	sys-fs/fatcat-1.1.1 fails to compile (MUSL-SYSTEM): FatSystem.cpp:93:5: error: lseek64 was not declared in this scope
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Ben Kohler <bkohler>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	903611
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-06-15 14:26:55 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/fatcat-1.1.1 fails to compile (MUSL-SYSTEM).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
(MUSL-SYSTEM) in the summary means that bug was found on a machine that runs MUSL libc but this bug MAY or MAY NOT BE related to musl.

Comment 1 Agostino Sarubbo gentoo-dev

2023-06-15 14:26:57 UTC

Created attachment 863866 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2023-06-15 14:26:58 UTC

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: CMakeFiles/fatcat.dir/src/core/FatSystem.cpp.o 
/var/tmp/portage/sys-fs/fatcat-1.1.1/work/fatcat-1.1.1/src/core/FatSystem.cpp:93:5: error: 'lseek64' was not declared in this scope; did you mean 'lseek'?

Comment 3 Larry the Git Cow gentoo-dev

2023-06-15 15:19:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1afb1f2f7dfb2e4c1588fcb084f9879f3494f111

commit 1afb1f2f7dfb2e4c1588fcb084f9879f3494f111
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2023-06-15 15:17:46 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2023-06-15 15:17:46 +0000

    sys-fs/fatcat: new musl fix, replace old musl fix too
    
    We previously had 1 musl patch for getopt usage, I'm replacing that with
    one from an upstream PR [1], also adding a new patch from that upstream PR.
    
    [1] https://github.com/Gregwar/fatcat/pull/34
    
    Closes: https://bugs.gentoo.org/908541
    
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 sys-fs/fatcat/fatcat-1.1.1.ebuild                  |   6 +-
 .../files/fatcat-1.1.1-musl-1.2.4-fixes.patch      | 107 +++++++++++++++++++++
 sys-fs/fatcat/files/fatcat-include-getopt.patch    |  11 ---
 3 files changed, 111 insertions(+), 13 deletions(-)