Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 906811

Summary: dev-libs/protobuf & co.: version bump
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Status: RESOLVED FIXED    
Severity: normal CC: cjk, gentoo, holger, neb.semqen.ramesses
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/30860
https://github.com/gentoo/gentoo/pull/31893
https://bugs.gentoo.org/show_bug.cgi?id=912819
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 909081, 910284    
Bug Blocks: 867943, 908373    
Attachments: protobuf-22.3.ebuild
protobuf-python-4.22.3.ebuild
protobuf-22.3.ebuild
protobuf-22.3.ebuild

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-05-20 08:53:55 UTC
The current release is 23.1 (4.23.1 for protobuf-py).
Comment 1 Matt Whitlock 2023-06-08 19:19:44 UTC
Created attachment 863583 [details]
protobuf-22.3.ebuild

As I needed protobuf 22.3 for a project, I've taken a first stab at adapting some new protobuf ebuilds. The big change is that the build system is now CMake-based.

There are still some outstanding issues:

* dev-cpp/abseil-cpp does not support multilib, but we need it to.
* I've ripped out the cross-compilation bits. Maybe CMake handles cross-compilation correctly; I don't know.
* I didn't run the unit tests, so I don't know if they pass.
Comment 2 Matt Whitlock 2023-06-08 19:20:04 UTC
Created attachment 863584 [details]
protobuf-python-4.22.3.ebuild
Comment 3 Matt Whitlock 2023-06-08 19:24:51 UTC
Created attachment 863585 [details]
protobuf-22.3.ebuild

I just noticed I left dev-cpp/abseil-cpp out of RDEPEND by accident.
Comment 4 Matt Whitlock 2023-06-08 19:27:51 UTC
Created attachment 863586 [details]
protobuf-22.3.ebuild

Please put me out of my misery. I apologize for the spam. That's what I get for rushing.
Comment 5 Larry the Git Cow gentoo-dev 2023-06-28 08:06:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1b9b0e443dc173d12d0346deb1f06f7685238e6

commit c1b9b0e443dc173d12d0346deb1f06f7685238e6
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-01-31 11:05:43 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-06-28 08:00:01 +0000

    dev-java/protobuf-java: add 3.23.0
    
    Higher versions depend on dev-cpp/abseil-cpp-20230125.3 which is not in
    the tree.
    
    Bug: https://bugs.gentoo.org/906811
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 dev-java/protobuf-java/Manifest                    |   1 +
 ...obuf-java-3.23.0-unittest_retention.proto.patch |  35 +++++
 dev-java/protobuf-java/metadata.xml                |   8 +-
 dev-java/protobuf-java/protobuf-java-3.23.0.ebuild | 165 +++++++++++++++++++++
 4 files changed, 206 insertions(+), 3 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-08-21 15:23:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=61d0b43d739b703ee9f25abefb04ba0bdf1ac158

commit 61d0b43d739b703ee9f25abefb04ba0bdf1ac158
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-08-21 15:03:41 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-21 15:23:21 +0000

    net-libs/grpc: bundle abseil-cpp
    
    abseil isn't *really* intended to be a system library and having a year-old
    pinned dep like this causes havoc for other packages and leads to uninstallable
    combinations (e.g. libreoffice-bin + anything needing grpc).
    
    Please see also the extensive discussion in the linked PRs wrt abseil now
    depending on re2 and the ABI implications of the used C++ std. versions with
    abseil. It's not worth it and there's more downsides to unbundling than not.
    
    Note that we can't rebundle re2 here because the build system unconditionally
    then tries to install it (no toggle unlike for abseil-cpp).
    
    Bug: https://bugs.gentoo.org/906811
    Bug: https://github.com/gentoo/gentoo/pull/31388
    Bug: https://github.com/gentoo/gentoo/pull/31609
    Bug: https://github.com/gentoo/gentoo/pull/31893
    Bug: https://github.com/gentoo/gentoo/pull/32281
    Closes: https://bugs.gentoo.org/908373
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/grpc/Manifest                                  |  1 +
 .../grpc/{grpc-1.52.1.ebuild => grpc-1.52.1-r1.ebuild}  | 17 +++++++++++++----
 2 files changed, 14 insertions(+), 4 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2023-08-21 17:31:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d231d90376246566071cd3bd91ada45d8f57abc

commit 6d231d90376246566071cd3bd91ada45d8f57abc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-07-13 11:49:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-21 17:29:13 +0000

    dev-libs/protobuf: add 21.12
    
    Bug: https://bugs.gentoo.org/909081
    Closes: https://bugs.gentoo.org/906811
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/protobuf/Manifest              |   1 +
 dev-libs/protobuf/protobuf-21.12.ebuild | 105 ++++++++++++++++++++++++++++++++
 dev-libs/protobuf/protobuf-23.3.ebuild  |   2 +-
 3 files changed, 107 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bb07c91ec18d88372147c4da436b7788ee84df6

commit 1bb07c91ec18d88372147c4da436b7788ee84df6
Author:     Mark Conway <mark.conway@themobiusproject.com>
AuthorDate: 2023-06-26 00:46:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-08-21 17:29:13 +0000

    dev-libs/protobuf: version bump to 23.3
    
    Upstream's versioning has change which messes with slot numbers.
    
    Closes: https://bugs.gentoo.org/906811
    Signed-off-by: Mark Conway <mark.conway@themobiusproject.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/protobuf/Manifest                         |   1 +
 .../files/protobuf-23.3-disable-32-bit-tests.patch |  34 +++++++
 .../protobuf-23.3-static_assert-failure.patch      |  11 +++
 dev-libs/protobuf/protobuf-23.3.ebuild             | 107 +++++++++++++++++++++
 4 files changed, 153 insertions(+)