Summary: | Ban portageq as an ebuild-helper | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Ulrich Müller <ulm> |
Component: | Core - Ebuild Support | Assignee: | Portage team <dev-portage> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bertrand, gentoo, ionen |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://dev.gentoo.org/~ulm/pms/head/pms.html#section-12.3.17 | ||
See Also: |
https://github.com/gentoo/portage/pull/1035 https://github.com/gentoo/portage/pull/1037 https://github.com/gentoo/portage/pull/1138 https://github.com/gentoo/portage/pull/1164 https://bugs.gentoo.org/show_bug.cgi?id=916296 https://bugs.gentoo.org/show_bug.cgi?id=916287 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 905355, 906329, 907896, 908602, 916031 | ||
Bug Blocks: | 906128 |
Description
Ulrich Müller
![]() > The last ebuild using portageq was removed from the Gentoo repo on
> 2020-07-27.
Sorry, false positive.
Last usage was in app-doc/eclass-manpages and was removed on 2019-03-14.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=ab538e7750fb85d57a3eb9d9b440848c1f2c074a commit ab538e7750fb85d57a3eb9d9b440848c1f2c074a Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-05-11 17:27:51 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-05-11 20:15:46 +0000 ebuild-helpers/portageq: Deprecate Calling portageq from ebuilds was never allowed. Last usage was removed from Gentoo repository on 2019-03-14. Bug: https://bugs.gentoo.org/906129 Signed-off-by: Ulrich Müller <ulm@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org> bin/ebuild-helpers/portageq | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (In reply to comment #2) > https://gitweb.gentoo.org/proj/portage.git/commit/ > ?id=ab538e7750fb85d57a3eb9d9b440848c1f2c074a > > commit ab538e7750fb85d57a3eb9d9b440848c1f2c074a > Author: Ulrich Müller <ulm@gentoo.org> > AuthorDate: 2023-05-11 17:27:51 +0000 > Commit: Sam James <sam@gentoo.org> > CommitDate: 2023-05-11 20:15:46 +0000 > > ebuild-helpers/portageq: Deprecate > > Calling portageq from ebuilds was never allowed. best_version and has_version call this portageq when sys-apps/portage with USE="-ipc" is used. Maybe revert change in bin/ebuild-helpers/portageq, and instead add portageq() function in bin/phase-helpers.sh, which would call eqawarn and bin/ebuild-helpers/portageq. (In reply to Arfrever Frehtes Taifersar Arahesis from comment #3) > best_version and has_version call this portageq when sys-apps/portage with > USE="-ipc" is used. https://github.com/gentoo/portage/pull/1037 addresses this. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=4bc369c549c34a757c799e3f6df1214cd1da12ef commit 4bc369c549c34a757c799e3f6df1214cd1da12ef Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-05-13 10:35:50 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-05-13 20:13:25 +0000 portageq-wrapper: New wrapper script Move the internal portageq wrapper script out of the ebuild-helpers directory. Call the new script from best_version and has_version in the case when IPC is disabled. The goal is to ban portageq from the ebuild environment after some transition time. Bug: https://bugs.gentoo.org/906129 Fixes: ab538e7750fb85d57a3eb9d9b440848c1f2c074a Signed-off-by: Ulrich Müller <ulm@gentoo.org> NEWS | 4 ++++ bin/ebuild-helpers/portageq | 24 +----------------------- bin/phase-helpers.sh | 2 +- bin/portageq-wrapper | 19 +++++++++++++++++++ 4 files changed, 25 insertions(+), 24 deletions(-) After future deletion of bin/ebuild-helpers/portageq, remember to delete this line in bin/portageq-wrapper, which will no longer be needed: [[ ${path} == */portage/*/ebuild-helpers* ]] && continue The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08be91eebdbff0de0e033efe30c633219a9859ca commit 08be91eebdbff0de0e033efe30c633219a9859ca Author: Sam James <sam@gentoo.org> AuthorDate: 2023-06-01 01:22:47 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-06-01 01:23:18 +0000 sys-apps/portage: add 3.0.48 Closes: https://bugs.gentoo.org/722270 Closes: https://bugs.gentoo.org/879687 Closes: https://bugs.gentoo.org/898232 Closes: https://bugs.gentoo.org/898366 Closes: https://bugs.gentoo.org/905355 Closes: https://bugs.gentoo.org/905358 Closes: https://bugs.gentoo.org/905868 Closes: https://bugs.gentoo.org/906129 Closes: https://bugs.gentoo.org/906156 Signed-off-by: Sam James <sam@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-3.0.48.ebuild | 296 +++++++++++++++++++++++++++++++++ 2 files changed, 297 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=76a7c3c61f6e3779452b6b3675c32bda02c8c88c commit 76a7c3c61f6e3779452b6b3675c32bda02c8c88c Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2023-05-12 17:34:59 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2023-10-21 08:01:25 +0000 portageq: Ban in ebuild scope Closes: https://bugs.gentoo.org/906129 Signed-off-by: Ulrich Müller <ulm@gentoo.org> bin/ebuild-helpers/portageq | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b9128b401def05cac46f9e6d66048e5a0d888b8 commit 2b9128b401def05cac46f9e6d66048e5a0d888b8 Author: Sam James <sam@gentoo.org> AuthorDate: 2023-10-25 05:48:31 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-25 05:48:40 +0000 sys-apps/portage: add 3.0.54 Closes: https://bugs.gentoo.org/905869 Closes: https://bugs.gentoo.org/915551 Closes: https://bugs.gentoo.org/915896 Closes: https://bugs.gentoo.org/916106 Closes: https://bugs.gentoo.org/916108 Closes: https://bugs.gentoo.org/916112 Closes: https://bugs.gentoo.org/916116 Closes: https://bugs.gentoo.org/916139 Closes: https://bugs.gentoo.org/916141 Closes: https://bugs.gentoo.org/916142 Closes: https://bugs.gentoo.org/916149 Closes: https://bugs.gentoo.org/916182 Closes: https://bugs.gentoo.org/916231 Closes: https://bugs.gentoo.org/916235 Closes: https://bugs.gentoo.org/916240 Closes: https://bugs.gentoo.org/916242 Closes: https://bugs.gentoo.org/916245 Closes: https://bugs.gentoo.org/916248 Closes: https://bugs.gentoo.org/899898 Closes: https://bugs.gentoo.org/906129 Closes: https://bugs.gentoo.org/906156 Closes: https://bugs.gentoo.org/916031 Signed-off-by: Sam James <sam@gentoo.org> sys-apps/portage/Manifest | 1 + sys-apps/portage/portage-3.0.54.ebuild | 238 +++++++++++++++++++++++++++++++++ 2 files changed, 239 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=27952b1d753ef4ea9bbd2307f8a9a315ad94557d commit 27952b1d753ef4ea9bbd2307f8a9a315ad94557d Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2023-10-26 14:42:00 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2023-10-26 15:45:14 +0000 Convert portageq helper to a function This keeps it out of PATH in ebuilds to avoid breaking external utilities that call portageq. Bug: https://bugs.gentoo.org/906129 Bug: https://bugs.gentoo.org/916287 Bug: https://bugs.gentoo.org/916296 Signed-off-by: Mike Gilbert <floppym@gentoo.org> NEWS | 4 +++- bin/ebuild-helpers/portageq | 8 -------- bin/phase-helpers.sh | 4 ++++ bin/portageq-wrapper | 1 - 4 files changed, 7 insertions(+), 10 deletions(-) |