Bug 903611 (musl-1.2.4)

Summary:	[Tracker] Breakage with sys-libs/musl-1.2.4 (9999) LFS shims being removed
Product:	Gentoo Linux	Reporter:	Sam James <sam>
Component:	Current packages	Assignee:	Anthony Basile <blueness>
Status:	CONFIRMED ---
Severity:	normal	CC:	herrtimson, immoloism, kelvium, lu_zero, musl, toolchain, vimproved, w12101111
Priority:	Normal	Keywords:	Tracker
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://git.adelielinux.org/adelie/packages/-/issues/1019 https://bugs.gentoo.org/show_bug.cgi?id=471102 https://bugs.gentoo.org/show_bug.cgi?id=876883 https://bugs.gentoo.org/show_bug.cgi?id=920477
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	713854, 905711, 905713, 905994, 905997, 906187, 906190, 906209, 906353, 906355, 906361, 906379, 906603, 906923, 906928, 906930, 906932, 906933, 906987, 907037, 907082, 907096, 907258, 907680, 907752, 907886, 907898, 908398, 908589, 908590, 908661, 908662, 908668, 908671, 908801, 908892, 912284, 915809, 920159, 920174, 920630, 922291, 922293, 922378, 922464, 922535, 923071, 923769, 923772, 923773, 923997, 924104, 924171, 924347, 924503, 924599, 924643, 925155, 925187, 925190, 925234, 925238, 925434, 928569, 928627, 928936, 929072, 929122, 929994, 931062, 931595, 838091, 900871, 903607, 905712, 905714, 905875, 905899, 905900, 905910, 905912, 905913, 905914, 905922, 905930, 905985, 905996, 905998, 905999, 906073, 906151, 906166, 906167, 906362, 906459, 906539, 906541, 906756, 906893, 906894, 906920, 906921, 906922, 906929, 906948, 906949, 906951, 906952, 906953, 906954, 906956, 906989, 907035, 907038, 907039, 907040, 907041, 907042, 907043, 907083, 907085, 907086, 907088, 907089, 907090, 907091, 907092, 907093, 907094, 907098, 907104, 907105, 907167, 907169, 907171, 907174, 907175, 907606, 907679, 907754, 907811, 907887, 908541, 908664, 908670, 911233, 912347, 912830, 913163, 913667, 913668, 915979, 920042, 922289, 922294, 922317, 923901, 924101, 924664, 924878, 925599, 927796, 928948
Bug Blocks:

Description Sam James archtester

2023-03-30 22:38:07 UTC

musl-1.2.4 (9999 right now) will remove/removes the LFS compatibility hacks, like fopen64:
- https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4
- https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b659170e7b9c7db9bc

The gist is that bad configure tests (suffering from -Wimplicit-function-declaration) would build and link successfully because musl provided these symbols as aliases, despite not needing them (musl natively supports both LFS & time64).

To head this off, these aliases are now gone, but remain in libc.so for binary compatibility.

The fix is to just use the regular functions and not anything _LARGEFILE64_SOURCE.

As a workaround, we can pass -D_LARGEFILE64_SOURCE in tricky cases *for one release cycle*. musl will drop that compatibility hack entirely in the next release *after* 1.2.4.

Comment 1 Larry the Git Cow gentoo-dev

2023-05-02 19:11:38 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fff4978abbdd4b55fe85decb9df743786f57c6a

commit 5fff4978abbdd4b55fe85decb9df743786f57c6a
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-05-02 17:51:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-05-02 19:11:10 +0000

    sys-libs/musl: add 1.2.4
    
    Bug: https://bugs.gentoo.org/903611
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-libs/musl/Manifest          |   2 +
 sys-libs/musl/musl-1.2.4.ebuild | 212 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 214 insertions(+)