Bug 903273 – app-xemacs/ebuild-mode-1.63 stable request

• Product: Gentoo Linux
• Status: RESOLVED CANTFIX

[Description Ulrich Müller 2023-03-28 06:18:08 UTC]

Changes since last stable version (1.60):

2023-02-27  Ulrich Müller  <[e-mail]>

	* Version 1.62 released.

	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass):
	Regenerated.

2023-02-21  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-update-copyright): Call lwarn with
	nil as second argument, which works for both GNU Emacs and XEmacs.

	* ebuild-mode.el (ebuild-repo-mode): Check if coding system
	utf-8-unix exists; it doesn't in XEmacs 21.4.

	* gentoo-newsitem-mode.el (gentoo-newsitem-insert-skeleton): Call
	ebuild-mode-time-string, so that the date is in the UTC time zone.
	* glep-mode.el (glep-mode-update-last-modified)
	(glep-mode-insert-skeleton): Ditto.

	* ebuild-mode.el (ebuild-mode-time-string): New compatibility
	function for format-time-string, where XEmacs doesn't support the
	time zone argument. Bug 890933.
	(ebuild-mode-update-copyright, ebuild-mode-insert-skeleton)
	(ebuild-mode-insert-tag-line): Call it.
	(ebuild-mode-update-copyright): Save match data, because setenv
	clobbers it.

2022-12-01  Ulrich Müller  <[e-mail]>

	* Version 1.61 released.

	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass):
	Regenerated.

	* ebuild-mode.el: Add documentation to some functions and
	variables.
	(ebuild-compilation-mode): Reword docstring to avoid an open paren
	at the beginning of a line, which confuses some Emacs versions.

	* ebuild-mode.el (ebuild-mode-restrict-list): Update.

2022-11-30  Ulrich Müller  <[e-mail]>

	* ebuild-mode.texi (ebuild-mode): Document ebuild-mode-run-pkgdev
	and ebuild-mode-run-pkgcheck.

	* ebuild-mode.el (ebuild-compilation-mode): New mode for
	compilation buffers, filters SGR control sequences.
	(ebuild-log-buffer-mode): Default to it.
	(ebuild-mode-run-pkgdev, ebuild-mode-run-pkgcheck): Call compile
	with ebuild-log-buffer-mode.
	(ebuild-mode-process-environment): Don't set NOCOLOR if ansi-color
	is available.

2022-11-28  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-ebuild-history)
	(ebuild-mode-pkgdev-history, ebuild-mode-pkgcheck-history):
	New variables.
	(ebuild-run-command, ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): Use them.

	* ebuild-mode.el (ebuild-mode-process-environment): New custom
	variable. Bug 882055.
	(ebuild-run-command, ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): Use it.

	* ebuild-mode.el (ebuild-mode-ebuild-cmd-complete): New function,
	completes multiple ebuild commands. Bug 882053.
	(ebuild-run-command): Call it.
	(ebuild-mode-menu): Add ebuild-run-command without argument.

2022-11-19  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-run-pkgdev)
	(ebuild-mode-run-pkgcheck): New commands. Bug 881449.
	(ebuild-mode-map, ebuild-mode-menu): Keybindings and menu entries
	for them.
	(ebuild-mode-pkgdev-commands, ebuild-mode-pkgcheck-commands):
	New variables.
	(ebuild-mode-get-completion-function): New function, split off
	from ebuild-mode-ekeyword-complete.
	(ebuild-mode-ekeyword-complete): Call it.
	(ebuild-mode-command-complete): New function.

2022-11-18  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-repo-mode): Fix byte-compile warning
	in XEmacs.

	* ebuild-mode.el (ebuild-mode-collect-and-split): Renamed from
	ebuild-mode-collect-equal-cdrs. Split the car of an element if its
	length is above the limit.
	(ebuild-mode-font-lock-keywords): Split the list of eclass
	keywords here, rather than in keyword-generation.sh.
	* keyword-generation.sh: Don't split the list into parts.
	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass): Updated.

2022-07-31  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-insert-skeleton): Drop unnecessary
	backslash escapes.

	* ebuild-mode.el (ebuild-repo-mode): Set nxml-attribute-indent.

2022-06-05  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-repo-mode): Indent XML with tabs or two
	spaces. Set indent-tabs-mode accordingly.
	(ebuild-mode-xml-indent-tabs): New custom variable.

2022-06-03  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-arch-list): Add loong to default.

	* ebuild-mode.el (ebuild-mode-modify-keywords): Use cons rather
	than append when adding a new keyword.

Test plan: <https://wiki.gentoo.org/wiki/Project:Emacs/Test_plans>

Thanks in advance.

[Comment 1 Ulrich Müller 2023-05-13 07:35:57 UTC]

Please stabilise version 1.63 instead.

2023-03-26  Ulrich Müller  <[e-mail]>

	* Version 1.63 released.

	* ebuild-mode-keywords.el (ebuild-mode-keywords-eclass):
	Regenerated.

2023-03-24  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-repo-mode): Don't override variables if
	they already have a buffer-local binding.

2023-03-20  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-find-workdir): New function.
	Thanks to Pascal Jäger for the idea.
	(ebuild-mode-portage-tmpdir): New custom variable.
	(ebuild-mode-map, ebuild-mode-menu): Keybinding and menu entry.

2023-02-28  Ulrich Müller  <[e-mail]>

	* ebuild-mode.el (ebuild-mode-process-environment): Set NO_COLOR
	in addition, see https://no-color.org/. Drop redundant test for
	XEmacs.

[Comment 2 Ulrich Müller 2023-06-17 18:08:04 UTC]

Ping. It's almost 3 months now.

[Comment 3 Mats Lidell 2023-07-05 20:38:20 UTC]

Hi, Sorry for checking late. There is at least one remaining xemacs incompatibility that breaks ebuild-mode. That is `local-variable-p` takes two required args. 

(local-variable-p SYMBOL BUFFER &optional AFTER-SET)

[Comment 4 Ulrich Müller 2023-07-05 22:19:15 UTC]

(In reply to Mats Lidell from comment #3)
> Hi, Sorry for checking late. There is at least one remaining xemacs
> incompatibility that breaks ebuild-mode. That is `local-variable-p` takes
> two required args. 
> 
> (local-variable-p SYMBOL BUFFER &optional AFTER-SET)

Right, let's close this then. I'll come up with a fix in ebuild-mode-1.65.

[Comment 5 Larry the Git Cow 2023-07-05 22:24:27 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=64761b573b89795fd2546fcbbebbb58e4efcb789

commit 64761b573b89795fd2546fcbbebbb58e4efcb789
Author:     Ulrich Müller <[e-mail]>
AuthorDate: 2023-07-05 22:20:58 +0000
Commit:     Ulrich Müller <[e-mail]>
CommitDate: 2023-07-05 22:20:58 +0000

    XEmacs compatibility fix
    
    * ebuild-mode.el (ebuild-repo-mode): local-variable-p has two
    required arguments in XEmacs, bug 903273.
    
    Bug: https://bugs.gentoo.org/903273#c3
    Signed-off-by: Ulrich Müller <[e-mail]>

 ChangeLog      |  5 +++++
 ebuild-mode.el | 10 +++++-----
 2 files changed, 10 insertions(+), 5 deletions(-)