Bug 902201

Summary:	dev-java/swt-4.27 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Java team <java>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, fordfrog, gentoo
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/30259
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-03-19 21:33:10 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-java/swt-4.27 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-19 21:33:12 UTC

CC'ing also the author of the commit (f827629c3b99735e623babe93c76624251cd2fd2)

Comment 2 Agostino Sarubbo gentoo-dev

2023-03-19 21:33:13 UTC

Created attachment 858419 [details]
build.log

build log and emerge --info

Comment 3 Larry the Git Cow gentoo-dev

2023-03-21 06:07:17 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dab82896df0e604b23b16da9cfd359d217f76a85

commit dab82896df0e604b23b16da9cfd359d217f76a85
Author:     Volkmar W. Pogatzki <gentoo@pogatzki.net>
AuthorDate: 2023-03-20 12:14:42 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2023-03-21 06:07:13 +0000

    dev-java/swt: No more CFLAGS += -Werror
    
    Closes: https://bugs.gentoo.org/902201
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    Closes: https://github.com/gentoo/gentoo/pull/30259
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../files/swt-4.27-as-needed-and-flag-fixes.patch  | 39 +++++++++++-----------
 1 file changed, 20 insertions(+), 19 deletions(-)