Bug 901275 – x11-wm/fvwm3-1.0.7-r1 has implicit function declarations in configure logs

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2023-03-15 07:58:47 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-wm/fvwm3-1.0.6a has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: ci)

NOTE:
See also: https://bugs.gentoo.org/898488#c4.

[Comment 1 Agostino Sarubbo 2023-03-15 07:58:49 UTC]

Created attachment 857769 [details]
build.log

build log and emerge --info

[Comment 2 Matt Jolly 2023-07-25 21:09:47 UTC]

I didn't see any warnings when bumping to 1.0.7; I'll validate that in the near future and we can drop any legacy versions once the PR has been merged.

[Comment 3 Sam James 2023-07-26 04:12:08 UTC]

The log has:
```
 * QA Notice: Found the following implicit function declarations in configure logs:
 *   /var/tmp/portage/x11-wm/fvwm3-1.0.6a/work/fvwm3-1.0.6a/config.log:2420 - close
 *   /var/tmp/portage/x11-wm/fvwm3-1.0.6a/work/fvwm3-1.0.6a/config.log:2424 - unlink
 * Check that no features were accidentally disabled.
```

https://github.com/fvwmorg/fvwm3/blob/main/acinclude.m4#L990 seems to use both close() and unlink() without the proper includes, so that still needs fixing.

[Comment 4 Agostino Sarubbo 2023-07-26 06:50:12 UTC]

ci has reproduced this issue with version 1.0.7 - Updating summary.

[Comment 5 Agostino Sarubbo 2023-08-06 07:10:45 UTC]

ci has reproduced this issue with version 1.0.7-r1 - Updating summary.

[Comment 6 Larry the Git Cow 2023-10-17 06:37:49 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37f573a1bef76b79894855a60fba7053ba40ae5f

commit 37f573a1bef76b79894855a60fba7053ba40ae5f
Author:     Matt Jolly <[e-mail]>
AuthorDate: 2023-10-17 06:11:08 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2023-10-17 06:37:46 +0000

    x11-wm/fvwm3: drop 1.0.7-r1
    
    Closes: https://bugs.gentoo.org/901275
    Signed-off-by: Matt Jolly <[e-mail]>
    Signed-off-by: Joonas Niilola <[e-mail]>

 x11-wm/fvwm3/Manifest              |   1 -
 x11-wm/fvwm3/fvwm3-1.0.7-r1.ebuild | 168 -------------------------------------
 2 files changed, 169 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6eb1cccd1b7165e4708372833e0779a3d2ad795f

commit 6eb1cccd1b7165e4708372833e0779a3d2ad795f
Author:     Matt Jolly <[e-mail]>
AuthorDate: 2023-10-17 05:50:56 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2023-10-17 06:37:46 +0000

    x11-wm/fvwm3: add 1.0.8
    
    - add python 3.12
    
    Closes: https://bugs.gentoo.org/915473
    Bug: https://bugs.gentoo.org/901275
    Signed-off-by: Matt Jolly <[e-mail]>
    Signed-off-by: Joonas Niilola <[e-mail]>

 x11-wm/fvwm3/Manifest                              |   1 +
 ...m3-1.0.8-implicit-function-decl-configure.patch |  18 +++
 x11-wm/fvwm3/fvwm3-1.0.8.ebuild                    | 172 +++++++++++++++++++++
 x11-wm/fvwm3/fvwm3-9999.ebuild                     |   2 +-
 4 files changed, 192 insertions(+), 1 deletion(-)