Bug 900382

Summary:	sys-apps/sed-4.9 has implicit function declarations in configure logs (CLANG-17-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:	fixed in 4.9-r1
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	906027
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-03-08 14:05:08 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/sed-4.9 has implicit function declarations in configure logs (CLANG-17-SYSTEM).
Discovered on: amd64 (internal ref: hardened_tinderbox)

NOTE:
(CLANG-17-SYSTEM) in the summary means that the bug was found on a machine that runs clang-17 but this bug MAY or MAY NOT BE related to the new compiler
See also: https://bugs.gentoo.org/898488#c4.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-08 14:05:11 UTC

Created attachment 856818 [details]
build.log

build log and emerge --info

Comment 2 connor-gh 2023-11-23 06:54:49 UTC

The functions in question are alignof (_Alignof), MIN (macro), and free is attempting to be used without a prototype (!!!). The latter - the only actual issue - can be solved by adding #include <stdlib.h> to the file or by including the prototype, but that isn't our job.

Comment 3 connor-gh 2023-11-23 06:55:16 UTC

It's also relatively clear that if a system has malloc(), *very rarely* will it not have free().

Comment 4 Eli Schwartz gentoo-dev

2023-11-23 07:54:53 UTC

All the instances of `free` are caused by autoconf builtin logic, and is fixed by adding `eautoreconf` to src_prepare. The other solution is waiting for upstream to release a new dist tarball.

Comment 5 Larry the Git Cow gentoo-dev

2024-05-19 16:02:44 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93f46f4f8dfd02fc6bc515d6f8293a65dccfa154

commit 93f46f4f8dfd02fc6bc515d6f8293a65dccfa154
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-05-17 06:05:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-19 16:01:43 +0000

    sys-apps/sed: regenerate autoconf to get a Modern C fix in
    
    There are also some suppressions that are going to be added to portage
    itself for gnulib checks that are *expected* to fail. Backported to
    sys-apps/portage.
    
    [sam: Revbump.]
    
    Closes: https://bugs.gentoo.org/900382
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/sed/{sed-4.9.ebuild => sed-4.9-r1.ebuild} | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)