Bug 898782

Summary:	dev-vcs/cvs-1.12.12-r14 has implicit function declarations in configure logs (GCC-13-SYSTEM)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	906027
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-03-02 09:12:15 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-vcs/cvs-1.12.12-r14 has implicit function declarations in configure logs (GCC-13-SYSTEM).
Discovered on: amd64 (internal ref: gcc13_tinderbox)

NOTE:
(GCC-13-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler
See also: https://bugs.gentoo.org/898488#c4.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-02 09:12:17 UTC

Created attachment 855656 [details]
build.log

build log and emerge --info

Comment 2 Larry the Git Cow gentoo-dev

2024-05-20 21:58:12 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ef52b34d6d49b9b4d41d19dd6df290da5b7179eb

commit ef52b34d6d49b9b4d41d19dd6df290da5b7179eb
Author:     Eli Schwartz <eschwartz93@gmail.com>
AuthorDate: 2024-05-20 02:02:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-20 21:56:54 +0000

    dev-vcs/cvs: fix all kinds of Modern C issues
    
    This package release is an extra-vintage 2005 with extra gnulib on top.
    
    Among numerous other issues, the broken autoconf standard macros managed
    to break the STDC_HEADERS check, resulting in cvs thinking that there
    are no available standard headers, and not bothering to include them.
    Ouch!
    
    To fix this, we:
    - fix a broken AM_GNU_GETTEXT_VERSION macro to stop autopoint erroring
    - rerun eautoreconf, to fix various standard macros with c99 fixes
    - add some m4 patches that partially backport gnulib fixes (I think hope
      and pray, since I stopped looking at them after a bit due to the
      inability to backport)
    
    Also, while we are at it, throw in a broken shell quoting fix.
    
    Closes: https://bugs.gentoo.org/898782
    Closes: https://bugs.gentoo.org/882225
    Closes: https://bugs.gentoo.org/870835
    Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-vcs/cvs/cvs-1.12.12-r15.ebuild                 | 109 ++++++++++++++++++
 ...uoting-around-potentially-empty-shell-var.patch |  30 +++++
 dev-vcs/cvs/files/0001-gettext-autoreconf.patch    |  25 +++++
 dev-vcs/cvs/files/c99-roundup.patch                | 122 +++++++++++++++++++++
 4 files changed, 286 insertions(+)