| Summary: | sys-devel/patch-2.7.6-r5 has implicit function declarations in configure logs | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | correabuscar+gentoo_bugs, eschwartz |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://lists.gnu.org/archive/html/bug-patch/2024-05/msg00000.html | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 906027, 941869 | ||
| Attachments: | build.log | ||
|
Description
Agostino Sarubbo
2023-03-01 11:44:05 UTC
Created attachment 855404 [details]
build.log
build log and emerge --info
Unrelated to musl. https://github.com/coreutils/gnulib/commit/3c136a2cc38d71083f123231a8b9ad4b01930789 /* Android 4.3 declares fchownat() in <sys/stat.h> instead. */ #include <sys/stat.h> And gets mkdir() as a side effect... nice. Some time ago I asked for a new release to fix this by updating gnulib and re-releasing the project: https://lists.gnu.org/archive/html/bug-patch/2024-05/msg00000.html Alpha is now out: https://lists.gnu.org/archive/html/bug-patch/2024-11/msg00000.html The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf5d73cc18f72f1d5375f32568fc2a1bc9aac8fd commit cf5d73cc18f72f1d5375f32568fc2a1bc9aac8fd Author: Eli Schwartz <eschwartz@gentoo.org> AuthorDate: 2024-11-03 20:47:03 +0000 Commit: Eli Schwartz <eschwartz@gentoo.org> CommitDate: 2024-11-03 20:47:03 +0000 sys-devel/patch: add 2.7.6_p20241103 New alpha release after 7 years. https://lists.gnu.org/archive/html/bug-patch/2024-05/msg00000.html https://lists.gnu.org/archive/html/bug-patch/2024-11/msg00000.html Bug: https://bugs.gentoo.org/898598 Signed-off-by: Eli Schwartz <eschwartz@gentoo.org> Acked-by: Sam James <sam@gentoo.org> sys-devel/patch/Manifest | 2 + sys-devel/patch/patch-2.7.6_p20241103.ebuild | 76 ++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f52e76ae543f555f598e2e786b434c0610584ca commit 2f52e76ae543f555f598e2e786b434c0610584ca Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2024-11-19 22:29:42 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2024-11-19 22:29:42 +0000 sys-devel/patch: revbump, fix implicit mkdir in configure This is a bit of a hack since I'm only patching configure but not its gnulib source. However, the bug is fixed upstream... See-also: https://github.com/coreutils/gnulib/commit/3c136a2cc38d71083f123231a8b9ad4b01930789 Closes: https://bugs.gentoo.org/898598 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> .../patch/files/patch-2.7.6-configure-mkdir.patch | 14 ++++ sys-devel/patch/patch-2.7.6-r6.ebuild | 85 ++++++++++++++++++++++ 2 files changed, 99 insertions(+) (In reply to Eli Schwartz from comment #3) > https://github.com/coreutils/gnulib/commit/ > 3c136a2cc38d71083f123231a8b9ad4b01930789 > > /* Android 4.3 declares fchownat() in <sys/stat.h> instead. */ > #include <sys/stat.h> > > > And gets mkdir() as a side effect... nice. The patch we applied in 2f52e76ae543f555f598e2e786b434c0610584ca misses the changes to lib/unistd.in.h from https://github.com/coreutils/gnulib/commit/3c136a2cc38d71083f123231a8b9ad4b01930789. (In reply to Sam James from comment #7) > (In reply to Eli Schwartz from comment #3) > > https://github.com/coreutils/gnulib/commit/ > > 3c136a2cc38d71083f123231a8b9ad4b01930789 > > > > /* Android 4.3 declares fchownat() in <sys/stat.h> instead. */ > > #include <sys/stat.h> > > > > > > And gets mkdir() as a side effect... nice. > > The patch we applied in 2f52e76ae543f555f598e2e786b434c0610584ca misses the > changes to lib/unistd.in.h from > https://github.com/coreutils/gnulib/commit/ > 3c136a2cc38d71083f123231a8b9ad4b01930789. the Android hunk shouldn't matter but we should include it for completeness. The other configure check part might matter. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=26a8a019b6665b80a970188bba49846554797b4b commit 26a8a019b6665b80a970188bba49846554797b4b Author: Sam James <sam@gentoo.org> AuthorDate: 2025-02-05 16:24:46 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-02-05 16:51:08 +0000 sys-devel/patch: refine mkdir configure patch; fix test failure with -DNDEBUG * Add another hunk for another configure test (that only fires in some cases) and also add a hunk for Android (which might be needed for people doing Prefix). Noticed this whlie looking into something that ended up being related. * Fix test failure with -DNDEBUG, reported by Michał Górny <mgorny@gentoo.org> at https://github.com/conda-forge/patch-feedstock/issues/11. Closes: https://bugs.gentoo.org/898598 Signed-off-by: Sam James <sam@gentoo.org> .../patch-2.7.6-configure-mkdir-spruced-up.patch | 38 ++++++++++ .../patch-2.7.6-ndebug-assert-hash-table.patch | 37 ++++++++++ sys-devel/patch/patch-2.7.6-r7.ebuild | 86 ++++++++++++++++++++++ 3 files changed, 161 insertions(+) |
