Bug 895428

Summary:	app-misc/openrgb-0.8-r1 fails to compile (GCC-13-SYSTEM): SteelSeriesMouseController.h:40:17: error: uint8_t was not declared in this scope
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Patrick McLean <chutzpah>
Status:	RESOLVED FIXED
Severity:	normal	CC:	admnd, alexey+gentoo, xgqt
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	865117
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2023-02-19 14:49:27 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-misc/openrgb-0.8-r1 fails to compile (GCC-13-SYSTEM).
Discovered on: amd64 (internal ref: gcc13_tinderbox)

NOTE:
(GCC-13-SYSTEM) in the summary means that the bug was found on a machine that runs gcc-13 but this bug MAY or MAY NOT BE related to the new compiler

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-19 14:49:29 UTC

Created attachment 853066 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Adrien Dessemond 2023-03-28 22:45:22 UTC

uint8_t / uint16_t related errors are due to a missing #include, this one is even suggested by GCC itself in the error :)

Looking at the upstream repository, the file has been fixed for GCC-13 in the 'master' branch (no version tag, yet). See:

https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/SteelSeriesController/SteelSeriesRivalController.cpp

Comment 3 Larry the Git Cow gentoo-dev

2023-03-28 23:07:31 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1435fff38b1905f33b72a2f2a300e96cb2ea26d0

commit 1435fff38b1905f33b72a2f2a300e96cb2ea26d0
Author:     Maciej Barć <xgqt@gentoo.org>
AuthorDate: 2023-03-28 22:53:44 +0000
Commit:     Maciej Barć <xgqt@gentoo.org>
CommitDate: 2023-03-28 23:07:28 +0000

    app-misc/openrgb: patch for GCC 13
    
    Bug: https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/1743
    Closes: https://bugs.gentoo.org/895428
    Signed-off-by: Maciej Barć <xgqt@gentoo.org>

 app-misc/openrgb/files/openrgb-0.8-gcc-13.patch | 36 +++++++++++++++++++++++++
 app-misc/openrgb/openrgb-0.8-r1.ebuild          |  4 ++-
 2 files changed, 39 insertions(+), 1 deletion(-)

Comment 4 Maciej Barć gentoo-dev

2023-03-28 23:07:49 UTC

(In reply to Adrien Dessemond from comment #2)
> uint8_t / uint16_t related errors are due to a missing #include, this one is
> even suggested by GCC itself in the error :)
> 
> Looking at the upstream repository, the file has been fixed for GCC-13 in
> the 'master' branch (no version tag, yet). See:
> 
> https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/
> SteelSeriesController/SteelSeriesRivalController.cpp

Thanks! :D