Summary: | app-text/foliate: Migrate from net-libs/webkit-gtk:4 to :4.1 if possible | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matt Turner <mattst88> |
Component: | Current packages | Assignee: | Andrey Grozin <grozin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | pacho, poncho |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 893668 | ||
Attachments: | allow WebKit2 4.1 |
Description
Matt Turner
![]() What's the difference between the slots 4, 4.1 and 5? I see the same versions 2.38.{2,3,4} in all of them. In my system I have 2 packages depending on webkit-gtk: wxGTK[webkit] and foliate. Both depend on webkit-gtk:4. Is it the most widely used slot? (In reply to Andrey Grozin from comment #1) > What's the difference between the slots 4, 4.1 and 5? I see the same > versions 2.38.{2,3,4} in all of them. That's answered in bug 893668#c0. > In my system I have 2 packages depending on webkit-gtk: wxGTK[webkit] and > foliate. Both depend on webkit-gtk:4. Is it the most widely used slot? I expect many users do not have webkit-gtk:4 -- I do not, for example, on a stable GNOME system. The difference between 4 and 4.1 is what version of libsoup they use, and the older libsoup (2.4) is deprecated. FWIW, bug 893718 is about moving wxGTK to webkit-gtk:4.1, but it is apparently not possible yet. Upstream issue is at https://github.com/johnfactotum/foliate/issues/931 Created attachment 854808 [details, diff]
allow WebKit2 4.1
I would go ahead on patching foliate-2 as upstream is also happy with it (while they are now focusing on the future foliate-3) https://github.com/johnfactotum/foliate/issues/931#issuecomment-1470122714 In any case, webkit-gtk:4 cannot be deprecated before the problem of wxGTK is resolved (bug #893718). I need wxGTK[webkit] because wxmaxima depends on it, and I use wxmaxima. If foliate will depend on webkit-gtk:4.1, I'll have to have both webkit-gtk:4 and webkit-gtk:4.1. I'd really hate such a situation: webkit-gtk compiles for several hours, and compiling both slots would be a nightmare. (In reply to Andrey Grozin from comment #6) > In any case, webkit-gtk:4 cannot be deprecated before the problem of wxGTK > is resolved (bug #893718). I need wxGTK[webkit] because wxmaxima depends on > it, and I use wxmaxima. If foliate will depend on webkit-gtk:4.1, I'll have > to have both webkit-gtk:4 and webkit-gtk:4.1. I'd really hate such a > situation: webkit-gtk compiles for several hours, and compiling both slots > would be a nightmare. You can make it depend on either, like games-util/lutris does: > || ( > net-libs/webkit-gtk:4[introspection] > net-libs/webkit-gtk:4.1[introspection] > ) (In reply to Matt Turner from comment #7) > (In reply to Andrey Grozin from comment #6) > > In any case, webkit-gtk:4 cannot be deprecated before the problem of wxGTK > > is resolved (bug #893718). I need wxGTK[webkit] because wxmaxima depends on > > it, and I use wxmaxima. If foliate will depend on webkit-gtk:4.1, I'll have > > to have both webkit-gtk:4 and webkit-gtk:4.1. I'd really hate such a > > situation: webkit-gtk compiles for several hours, and compiling both slots > > would be a nightmare. > > You can make it depend on either, like games-util/lutris does: > > > || ( > > net-libs/webkit-gtk:4[introspection] > > net-libs/webkit-gtk:4.1[introspection] > > ) (Obviously that would require a slightly different patch) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0d3eaa0f05e4044f2b7075c5ef0fab419bdb5d0 commit d0d3eaa0f05e4044f2b7075c5ef0fab419bdb5d0 Author: Andrey Grozin <grozin@gentoo.org> AuthorDate: 2023-05-14 10:59:38 +0000 Commit: Andrey Grozin <grozin@gentoo.org> CommitDate: 2023-05-14 10:59:38 +0000 app-text/foliate: DEPEND on webkit-gtk:4.1 disable automagick tests Closes: https://bugs.gentoo.org/893682 Closes: https://bugs.gentoo.org/728508 Signed-off-by: Andrey Grozin <grozin@gentoo.org> app-text/foliate/files/foliate-validate.patch | 31 ++++++++++++++ app-text/foliate/files/foliate-webkit.patch | 13 ++++++ app-text/foliate/foliate-2.6.4-r3.ebuild | 59 +++++++++++++++++++++++++++ 3 files changed, 103 insertions(+) |