Bug 878893 – sci-libs/libcifpp-3.0.0 fails to compile (lto): <artificial>:(.text+0x269b): undefined reference to std::tuple<cif::Row, bool> cif::Category::emplace<cif::Item const>(cif::Item const, cif::Item const)

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Agostino Sarubbo 2022-10-31 16:31:06 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-libs/libcifpp-3.0.0 fails to compile (lto).
Discovered on: amd64 (internal ref: lto_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 1 Agostino Sarubbo 2022-10-31 16:31:09 UTC]

Created attachment 826239 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-10-31 16:31:12 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


<artificial>:(.text+0x269b): undefined reference to `std::tuple<cif::Row, bool> cif::Category::emplace<cif::Item const*>(cif::Item const*, cif::Item const*)'
FAILED: unit-test 
Using resources not possible since mrc was not found
collect2: error: ld returned 1 exit status

[Comment 3 Larry the Git Cow 2022-12-04 14:50:46 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d578350ffb974dbc7e320a7fe0dd381a6bb81c82

commit d578350ffb974dbc7e320a7fe0dd381a6bb81c82
Author:     Pacho Ramos <[e-mail]>
AuthorDate: 2022-12-04 13:39:19 +0000
Commit:     Pacho Ramos <[e-mail]>
CommitDate: 2022-12-04 14:49:17 +0000

    sci-libs/libcifpp: add 5.0.5
    
    Closes: https://bugs.gentoo.org/881289
    Closes: https://bugs.gentoo.org/878893
    Signed-off-by: Pacho Ramos <[e-mail]>

 sci-libs/libcifpp/Manifest              |  2 ++
 sci-libs/libcifpp/libcifpp-5.0.5.ebuild | 33 +++++++++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)