Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 877501

Summary: kde-frameworks/kimageformats-5.99: Identify backports from 5.100
Product: Gentoo Linux Reporter: Andreas Sturmlechner <asturm>
Component: Current packagesAssignee: Gentoo KDE team <kde>
Status: RESOLVED FIXED    
Severity: normal CC: dnovomesky
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://invent.kde.org/frameworks/kimageformats/-/merge_requests?scope=all&state=merged
See Also: https://bugs.gentoo.org/show_bug.cgi?id=879223
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 876484    

Description Andreas Sturmlechner gentoo-dev 2022-10-17 20:53:27 UTC
Ideally bugfixes only in order to keep the delta as small as possible.

Not a priority would be adding support to unreleased library versions, unless trivial. Should we require e.g. libavif-0.11.0 support in a stable kimageformats version, we can think about backporting it as that happens.
Comment 1 Daniel Novomeský 2022-10-18 07:37:17 UTC
This small commit enables building also with libavif-0.11.0 :

https://invent.kde.org/frameworks/kimageformats/-/commit/f475a4b24a166d7582163753bc2f4f254257daed

These 2 are already in -r1:
https://invent.kde.org/frameworks/kimageformats/-/commit/350ce1b990460cb2178f369f22fe80803f5645f3

https://invent.kde.org/frameworks/kimageformats/-/commit/1190e53e9b69da6f9663ceb75c4813c5708b7cbd

However those two brought minor glitch, so another one corrected that afterwards:
https://invent.kde.org/frameworks/kimageformats/-/commit/bfb12093ad7a0624aa0b779bacf1377bd86c551d

The 4 above are from src/imageformats/avif.cpp file.


The same problem mentioned in https://bugs.kde.org/show_bug.cgi?id=460085 (which was observed using AVIF format) could happen also with JXL format.

Fixes for JPEG XL are not committed yet, work in progress.
Comment 2 Larry the Git Cow gentoo-dev 2022-10-18 21:37:41 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=959799bb81f7b422193a758a05a90607cbb0394e

commit 959799bb81f7b422193a758a05a90607cbb0394e
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-10-18 21:34:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-10-18 21:37:30 +0000

    kde-frameworks/kimageformats: More AVIF fixes, support 0.11.0
    
    Backporting upstream commits:
    bfb12093ad7a0624aa0b779bacf1377bd86c551d
    f475a4b24a166d7582163753bc2f4f254257daed
    
    Bug: https://bugs.gentoo.org/877501
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/kimageformats-5.99.0-avif-0.11.0.patch   | 51 ++++++++++++++++
 .../files/kimageformats-5.99.0-avif-perf-3.patch   | 70 ++++++++++++++++++++++
 .../kimageformats/kimageformats-5.99.0-r2.ebuild   | 47 +++++++++++++++
 3 files changed, 168 insertions(+)
Comment 5 Daniel Novomeský 2022-10-25 20:06:47 UTC
(In reply to Andreas Sturmlechner from comment #4)
> What about
> https://invent.kde.org/frameworks/kimageformats/-/commit/
> afa7399b366c99be9a549d62b53c5fa10701bb29

That one is also good, just not top urgent.
Comment 6 Larry the Git Cow gentoo-dev 2022-10-26 09:04:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef4a48f6af400cd2416951cda2611804ee4e7e3

commit 5ef4a48f6af400cd2416951cda2611804ee4e7e3
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-10-26 09:03:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-10-26 09:04:08 +0000

    kde-frameworks/kimageformats: Backport JXL performance fix
    
    Upstream commit d734f2872745dd1ab5aab9dafb144130d7e9fdcc
    
    Bug: https://bugs.gentoo.org/877501
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/kimageformats-5.99.0-jxl-perf.patch      | 116 +++++++++++++++++++++
 .../kimageformats/kimageformats-5.99.0-r3.ebuild   |  48 +++++++++
 2 files changed, 164 insertions(+)
Comment 7 Andreas Sturmlechner gentoo-dev 2022-11-08 20:33:20 UTC
KF-5.99 stable day is approaching fast and I will be closing this bug tomorrow if nothing else crops up. Thanks for the help!