| Summary: | ebuild: games-strategy/tribaltrouble | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Marcelo Goes (RETIRED) <vanquirius> |
| Component: | New packages | Assignee: | Default Assignee for New Packages <maintainer-wanted> |
| Status: | CONFIRMED --- | ||
| Severity: | enhancement | CC: | axs, bacatta, java, mailingdotlist, pacho, ralf, rockoo, team.penguin50 |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://oddlabs.com/download.php?os=linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 169604 | ||
| Bug Blocks: | |||
| Attachments: |
Tribal trouble ebuild
Fixed tribal trouble ebuild Bug output file with stack trace etc. tribaltrouble-1.0.ebuild without java USE A new version of the ebuild with take count of all the previous comments |
||
|
Description
Marcelo Goes (RETIRED)
2005-03-31 14:48:48 UTC
Created attachment 63268 [details]
Tribal trouble ebuild
Comment on attachment 63268 [details] Tribal trouble ebuild You need to put this image in the files directory in the portage tree, it's an icon for Tribal Trouble: http://zecmerquise.free.fr/files/dev/gentoo/tribaltrouble/tribaltrouble.png With this ebuild you have the possibility to use your own JRE instead of the given one, simply add "java" as a useflag when you emerge it. no, we don't put binary files like that in the portage tree. On the mirrors would probably be fine though assuming we have permission to use and distribute the image. Created attachment 63273 [details]
Fixed tribal trouble ebuild
Fixed a bug that I haven't seen before;
If you didn't have the java useflag the ebuild didn't copy the JRE given by
Oddlabs.
Now it's ok
tribal trouble has icon.png in it's package use it .... worked nice width USE="-java" i haven't test yet width the flag activated. You shouldn't specifically depend on sun-jdk, instead use the jdk virtual, ie >=virtual/jdk-1.5. The Java bits looks like it could use some love though. May want to take a look at: http://www.gentoo.org/proj/en/java/java-devel.xml Specifically, you should inherit java-pkg-opt-2 to get optional java support. You should say JAVA=java ... there's a wrapper at /usr/bin/java that takes care of executing the correct java binary from the correct VM. Am I to read it correctly that USE=-java installs its own copy of the JRE? If so... that's pretty bad. You should be using a JRE that's installed on the system. Created attachment 108995 [details]
Bug output file with stack trace etc.
Actually, it's worse. Not only does the d/l package install its own JDK when giving no USE flag, it also uses it. What's more, the program crashes with the output # # An unexpected error has been detected by HotSpot Virtual Machine: # # SIGSEGV (0xb) at pc=0xa940ac10, pid=3773, tid=3085421232 # # Java VM: Java HotSpot(TM) Client VM (1.5.0_04-b05 mixed mode) # Problematic frame: # C 0xa940ac10 # The (lengthy) bug output was appended in the comment above. Installs fine here (with java USEflag). Thank you for sharing this ebuild :D This bug should be removed I think, because tribaltrouble is no longer in the Portage tree. Created attachment 159701 [details, diff] tribaltrouble-1.0.ebuild without java USE Hans de Graaff (treecleaner) wrote: > I don't think tribaltrouble was ever in the tree to begin with. It > should probably be assigned to maintainer-wanted. Looked through the ebuild and removed the option to use a given java compiler. Instead the system jre is always used. Tested it and it installed well. I can't play it on my poorman's computer. Relevant emerge --info: Portage 2.1.4.4 (default-linux/x86/2006.1, gcc-4.1.1, glibc-2.4-r3, 2.6.23-gentoo-r9 i686) ================================================================= System uname: 2.6.23-gentoo-r9 i686 Intel(R) Pentium(R) M processor 1400MHz Timestamp of tree: Sat, 05 Jul 2008 11:00:01 +0000 app-shells/bash: 3.2_p17 dev-java/java-config: 1.3.7, 2.0.33-r1 dev-lang/python: 2.4.4-r6 dev-python/pycrypto: 2.0.1-r6 sys-apps/baselayout: 1.12.9 sys-apps/sandbox: 1.2.18.1-r2 sys-devel/autoconf: 2.13, 2.61-r1 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.18-r1 sys-devel/gcc-config: 1.3.13-r3 sys-devel/libtool: 1.5.24 virtual/os-headers: 2.6.17-r2 ACCEPT_KEYWORDS="~x86" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=i686 -O2 -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" CXXFLAGS="-march=i686 -O2 -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="collision-protect distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch" MAKEOPTS="-j2 (In reply to comment #13) > Created an attachment (id=159701) [edit] > tribaltrouble-1.0.ebuild without java USE Please read the java dev documentation. http://www.gentoo.org/proj/en/java/java-devel.xml Sadly this ebuild is _just wrong_ 1) doesn't inherit from the java eclasses (java-pkg-2 in this case) 2) depends on sun-jdk instead of virtual/jre 3) uses USE flag in DEPEND without declaring it in IUSE 4) doesn't use any of the java functions. Specifically java-pkg_dolauncher would be a good one to start with 5) hardcodes vm to use in script so will break the next time the vm is upgraded. (see 4). 6) installs LICENCE ( licence would be in /usr/portage/licences so doesn't need installing) 7) Use ${S} instead of "cd ${WORKDIR}/tribaltrouble" Thanks for the effort tho :) Created attachment 167221 [details]
A new version of the ebuild with take count of all the previous comments
This ebuild install the game for me but it lacks the lwjgl library. You can find this library on the java-overlay
Updated the bug dependency (replaced the duplicate bug with its original) Does the games herd intend to add this or should it be changed to maintainer-wanted? This package does no more exist in portage tree. I don't think it ever made it to the tree? Also, since this ebuild depends on something that's already InOverlay elsewhere, shouldn't it really be flagged maintainer-wanted? Sources available here: https://github.com/sunenielsen/tribaltrouble This looks kinda cool. Building from source would be nice. I'll add this one to my list as I intend to get at least two other LWJGL games into the tree. *** Bug 612570 has been marked as a duplicate of this bug. *** |
