| Summary: | media-video/mjpegtools ebuild rewrite | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Diego Elio Pettenò (RETIRED) <flameeyes> |
| Component: | New packages | Assignee: | Gentoo Media-video project <media-video> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | media-tv |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 66927, 73068, 74230 | ||
| Attachments: |
Patch for ebuild
Configure patch m4 library files mjpegtools-1.6.2-r3.patch mjpegtools-1.6.2-r3.patch |
||
Created attachment 54460 [details, diff]
Patch for ebuild
Created attachment 54461 [details, diff]
Configure patch
Created attachment 54462 [details]
m4 library files
cmov should be a cflag and NOT parsed from cpuinfo. please make the ebuild lines <80cols could you please try to push the improvements upstream? Created attachment 54519 [details, diff]
mjpegtools-1.6.2-r3.patch
Ok this time with cmov as an useflag instead of grepping it from /proc (better,
as fbsd hasn't the same /proc structure).
I've also restricted all the lines possible to 80 char (or 81 in one case).
Still there's an echo i haven't touched.
As I were there, i've also moved nasm from RDEPEND to DEPEND, and added a few
more docs installed.
I'm not sure if it's possible to contributing upstream as mjpegtools 1.6.2 is
more than one year old, and i wasn't able to find the cvs repository on sf.
Created attachment 54613 [details, diff]
mjpegtools-1.6.2-r3.patch
Ok this time cmov is identified by chost, it's enabled on i686 and x86_64.
This also merges the latest changes by eradicator.
Thanks KingTaco for providing safety on i586 CHOST for Via C3 systems :)
in cvs, thanks for your work |
The attached patch applied over current ebuild fixes the three blocked bugs, adds useflags when needed, make m4 library files added by the attached tarball. The configure patch must be put in ${FILESDIR}, the tar.bz2 should be uploaded to distfiles mirrors. It also fixes a problem with non-gsed implementation, and updates the build depends. HTH, Diego