Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 86692 - media-video/mjpegtools ebuild rewrite
Summary: media-video/mjpegtools ebuild rewrite
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 66927 73068 74230
  Show dependency tree
 
Reported: 2005-03-25 11:41 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-27 12:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for ebuild (mjpegtools-1.6.2-r3.patch,4.23 KB, patch)
2005-03-25 11:42 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
Configure patch (1.6.2-configure.patch,2.53 KB, patch)
2005-03-25 11:43 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
m4 library files (mjpegtools-m4-1.tar.bz2,4.44 KB, application/octet-stream)
2005-03-25 11:44 UTC, Diego Elio Pettenò (RETIRED)
Details
mjpegtools-1.6.2-r3.patch (mjpegtools-1.6.2-r3.patch,4.76 KB, patch)
2005-03-26 06:04 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
mjpegtools-1.6.2-r3.patch (mjpegtools-1.6.2-r3.patch,4.83 KB, patch)
2005-03-27 10:40 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-25 11:41:35 UTC
The attached patch applied over current ebuild fixes the three blocked bugs, adds useflags when needed, make m4 library files added by the attached tarball.

The configure patch must be put in ${FILESDIR}, the tar.bz2 should be uploaded to distfiles mirrors.

It also fixes a problem with non-gsed implementation, and updates the build depends.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-25 11:42:46 UTC
Created attachment 54460 [details, diff]
Patch for ebuild
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-25 11:43:36 UTC
Created attachment 54461 [details, diff]
Configure patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-25 11:44:09 UTC
Created attachment 54462 [details]
m4 library files
Comment 4 Luca Barbato gentoo-dev 2005-03-26 04:38:54 UTC
cmov should be a cflag and NOT parsed from cpuinfo.

please make the ebuild lines <80cols

could you please try to push the improvements upstream?

Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-26 06:04:49 UTC
Created attachment 54519 [details, diff]
mjpegtools-1.6.2-r3.patch

Ok this time with cmov as an useflag instead of grepping it from /proc (better,
as fbsd hasn't the same /proc structure).
I've also restricted all the lines possible to 80 char (or 81 in one case).
Still there's an echo i haven't touched.

As I were there, i've also moved nasm from RDEPEND to DEPEND, and added a few
more docs installed.


I'm not sure if it's possible to contributing upstream as mjpegtools 1.6.2 is
more than one year old, and i wasn't able to find the cvs repository on sf.
Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-27 10:40:46 UTC
Created attachment 54613 [details, diff]
mjpegtools-1.6.2-r3.patch

Ok this time cmov is identified by chost, it's enabled on i686 and x86_64.

This also merges the latest changes by eradicator.

Thanks KingTaco for providing safety on i586 CHOST for Via C3 systems :)
Comment 7 Luca Barbato gentoo-dev 2005-03-27 12:27:49 UTC
in cvs, thanks for your work