| Summary: | media-gfx/inkscape-1.2.1 fails to compile (lto): solve-bezier.cpp:25:7: error: type struct Bernsteins violates the C++ One Definition Rule [-Werror=odr] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
| Component: | Current packages | Assignee: | Andreas K. Hüttel <dilfridge> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ceamac, dilfridge, gentoo, pacho |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: |
https://gitlab.com/inkscape/lib2geom/-/issues/71 https://bugs.gentoo.org/show_bug.cgi?id=310393 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 618550 | ||
| Attachments: |
build.log
build log (1.2.2-r4) |
||
|
Description
Agostino Sarubbo
2022-07-21 08:39:53 UTC
Created attachment 792713 [details]
build.log
build log and emerge --info
Error(s) that match a know pattern in addition to what has been reported in the summary: -- Package 'poppler-cairo', required by 'virtual:world', not found FAILED: lib64/lib2geom.so.1.1.0 /var/tmp/portage/media-gfx/inkscape-1.2.1/work/inkscape-1.2.1/src/3rdparty/2geom/src/2geom/solve-bezier.cpp:25:7: error: type ‘struct Bernsteins’ violates the C++ One Definition Rule [-Werror=odr] Here is a bit of explanation: -Werror=lto-type-mismatch: User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO. For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase. -Werror=odr: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule. -Werror=strict-aliasing: Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. Workarounds: - If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL). - Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr). - Fix it yourself if interested, of course (VALID FOR ALL). - Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing). - Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing). - -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing). See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2 Please test 1.2.2 Created attachment 872207 [details]
build log (1.2.2-r4)
Same issue with 1.2.2-r4. (And 1.3.)
Needs to be reported at https://gitlab.com/inkscape/lib2geom/. (In reply to Sam James from comment #6) > Needs to be reported at https://gitlab.com/inkscape/lib2geom/. Done at https://gitlab.com/inkscape/lib2geom/-/issues/71. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5ebd5b8de96b966562aeed9cc6d899d8c43c08e commit c5ebd5b8de96b966562aeed9cc6d899d8c43c08e Author: Sam James <sam@gentoo.org> AuthorDate: 2024-02-29 02:43:35 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-02-29 02:43:35 +0000 media-gfx/inkscape: filter LTO (ODR) Bug: https://gitlab.com/inkscape/lib2geom/-/issues/71 Closes: https://bugs.gentoo.org/859628 Signed-off-by: Sam James <sam@gentoo.org> media-gfx/inkscape/inkscape-1.2.2-r4.ebuild | 4 +++- media-gfx/inkscape/inkscape-1.3.2.ebuild | 4 +++- media-gfx/inkscape/inkscape-9999.ebuild | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) |
