Bug 849785 – >=dev-python/cryptography-36.0.0: dep dev-python/cffi not pulled in when merging cryptography from binary package

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Osiris 2022-06-05 10:12:29 UTC]

In 65679c86bec8982d7a95220891d2438ffc63a192 (https://gitweb.gentoo.org/repo/gentoo.git/commit/dev-python/cryptography?id=65679c86bec8982d7a95220891d2438ffc63a192) the dependency logic for dev-python/cryptography was "fixed". However, due to the fact the dependency dev-python/cffi is now listed *only* in DEPEND and no longer in RDEPEND, this commit results in dev-python/cffi not being considered as a runtime dependency when installing dev-python/cryptography from a binary package.

https://devmanual.gentoo.org/general-concepts/dependencies/ notices: "Note that when installing from a binary package, only RDEPEND will be checked. It is therefore necessary to include items even if they are also listed in DEPEND."

Please move the dev-python/cffi dependency code back to RDEPEND, so it gets pulled in when emerging dev-python/cryptography from a binary package.

Reproducible: Always

Steps to Reproduce:
1. `emerge --buildpkg dev-python/cryptography`
2. `emerge -C dev-python/cffi`
3. `emerge -pvK dev-python/cryptography`
Actual Results:  
dev-python/cffi not considered for merger.

Expected Results:  
dev-python/cffi being pulled in the depedency graph of dev-python/cryptography.

Workaround: manually installing dev-python/cffi is possible, but not practical e.g. in Continuous Integration situations. Dependencies should just work.

[Comment 1 Sam James 2022-06-05 10:14:34 UTC]

Yep, I know how they work, just a mistake.

[Comment 2 Sam James 2022-06-05 10:15:56 UTC]

(In reply to Sam James from comment #1)
> Yep, I know how they work, just a mistake.

(The mistake was when fixing BDEPEND vs DEPEND, not actually intending to drop it from RDEPEND...)

[Comment 3 Larry the Git Cow 2022-06-05 10:17:34 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c00d4a688a3abf6b9f6cb0635aada62d2f33599b

commit c00d4a688a3abf6b9f6cb0635aada62d2f33599b
Author:     Sam James <[e-mail]>
AuthorDate: 2022-06-05 10:16:14 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2022-06-05 10:17:17 +0000

    dev-python/cryptography: fix CFFI RDEPEND
    
    Closes: https://bugs.gentoo.org/849785
    Fixes: 65679c86bec8982d7a95220891d2438ffc63a192
    Signed-off-by: Sam James <[e-mail]>

 .../{cryptography-37.0.2.ebuild => cryptography-37.0.2-r1.ebuild}   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

[Comment 4 Osiris 2022-06-05 10:21:16 UTC]

> Yep, I know how they work, just a mistake.

Sorry, I wasn't trying to be condescending or otherwise negative, just to clarify it possibly for other readers coming across this bug report too :)

Thank you for the quick fix! Keep up the good work :)