Bug 84228

Summary:	sysfsutils: libsysfs write_attribute bug if attribute is empty
Product:	Gentoo Linux	Reporter:	Dominik Brodowski <linux>
Component:	[OLD] Core system	Assignee:	Greg Kroah-Hartman (RETIRED) <gregkh>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gurligebis, henrik
Priority:	High	Keywords:	InVCS
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	84234
Attachments:	patch for libsysfs-1.2.0 ebuild for sysfsutils-1.2.0-r1

Description Dominik Brodowski 2005-03-05 13:41:46 UTC

The check in libsysfs::write_attribute() which tests whether the value to be written into a sysfs attribute is already there should only trigger if the length of both strings is the same. This patch, already accepted by upstream for sysfsutils-1.4.0, is needed for pcmciautils to work correctly.


Reproducible: Always
Steps to Reproduce:

Comment 1 Dominik Brodowski 2005-03-05 13:42:39 UTC

Created attachment 52742 [details, diff]
patch for libsysfs-1.2.0

Comment 2 Dominik Brodowski 2005-03-05 13:43:25 UTC

Created attachment 52743 [details]
ebuild for sysfsutils-1.2.0-r1

Comment 3 Henrik Brix Andersen 2005-05-15 01:52:09 UTC

Greg, can we get this patch merged into portage? It's the only issue holding back the addition of pcmciautils to portage (bug #84234).

If you want, I can add the patch and do the revision bump of sysfsutils.

Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev

2005-05-16 20:57:06 UTC

Sorry, feel free to do it yourself, haven't had much gentoo specific time
lately :(

Comment 5 Henrik Brix Andersen 2005-05-20 05:54:33 UTC

Added write_attribute() patch to sys-fs/sysfsutils-1.2.0-r1. Thanks.