Summary: | media-gfx/shotwell-0.30.15 error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared here (not in a function); did you mean ‘EXPORT_DIALOG_GET_CLASS’? | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | darkbasic <darkbasic> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | flow |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | PPC64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build.log |
Description
darkbasic
2022-04-23 08:06:38 UTC
Created attachment 773450 [details]
build.log
It's the same with 0.30.16: [334/392] powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.16/src -I../shotwell-0.30.16/vapi -Isrc/plugins -I../shotwell-0.30.16/src/plugins -I. -I../shotwell-0.30.16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c FAILED: src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o powerpc64le-unknown-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.16/src -I../shotwell-0.30.16/vapi -Isrc/plugins -I../shotwell-0.30.16/src/plugins -I. -I../shotwell-0.30.16 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -pipe -mcpu=power9 -mtune=power9 -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c src/shotwell.p/dialogs/ExportDialog.c:146:43: error: ‘EXPORT_DIALOG_DEFAULT_SCALE’ undeclared here (not in a function); did you mean ‘EXPORT_DIALOG_GET_CLASS’? 146 | static gint export_dialog_current_scale = EXPORT_DIALOG_DEFAULT_SCALE; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ | EXPORT_DIALOG_GET_CLASS I think this is a packaging issue because I've tried to reuse the 0.30.14 ebuild and bump it to .15/.16 and it compiles flawlessly. (In reply to darkbasic from comment #3) > I think this is a packaging issue because I've tried to reuse the 0.30.14 > ebuild and bump it to .15/.16 and it compiles flawlessly. Could you try to narrow down which option causes it then? The ebuilds only differ in a patch which got dropped that should be unrelated to this... The transpilled Vala to C code uses EXPORT_DIALOG_DEFAULT_SCALE (ExportDialog.c:146) before it is defined in ExportDialog.c:150. I wonder if this is a Vala transpiller bug. In fact, the dropped patch ("0.30.14-vala-0.52.8-compat.patch") was addressing this very issue: -- private static int current_scale = DEFAULT_SCALE; -+ private static int current_scale = 1200; //FIXME not needed with vala 0.54+ I am not an Vala expert, but if the patch comment is right, then maybe it is a simple matter of the ebuilding missing to declare VALA_MIN_API_VERSION="0.54" Indeed, adding VALA_MIN_API_VERSION="0.54" to the ebuild fixes the issue for me. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=314354a690c683b5a3b1b1ca2f1fcfe0be68f6ed commit 314354a690c683b5a3b1b1ca2f1fcfe0be68f6ed Author: Florian Schmaus <flow@gentoo.org> AuthorDate: 2022-06-07 10:03:05 +0000 Commit: Florian Schmaus <flow@gentoo.org> CommitDate: 2022-06-07 10:06:44 +0000 media-gfx/shotwell: Set VALA_MIN_API_VERSION=0.54 The ebuild for shotwell 0.13.14 contained a patch 0.30.14-vala-0.52.8-compat.patch that made shotwell compile on Vala < 0.54. However this patch was removed with 532f5153c752 ("media-gfx/shotwell: Drop old versions") and not carried over to newer shotwell ebuilds. However, those current ebuilds failed to declare a minimum dependency on Vala 0.54, causing bug #840281. This commit addresses the bug by adding VALA_MIN_API_VERSION=0.54 to the ebuild. Closes: https://bugs.gentoo.org/840281 Signed-off-by: Florian Schmaus <flow@gentoo.org> media-gfx/shotwell/shotwell-0.30.15.ebuild | 1 + media-gfx/shotwell/shotwell-0.30.16.ebuild | 1 + 2 files changed, 2 insertions(+) |