Summary: | www-client/seamonkey-2.53.11 fails to build with media-libs/dav1d-1.0.0 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Attila Tóth <atoth> |
Component: | Current packages | Assignee: | Myckel Habets <gentoo-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, mozilla |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/24744 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 835807 | ||
Attachments: |
seamonkey-2.53.11-dav1d-1.0.0.patch
Updated conditional patch. |
Description
Attila Tóth
2022-03-23 06:31:44 UTC
Created attachment 767613 [details, diff]
seamonkey-2.53.11-dav1d-1.0.0.patch
Unconditional patch to handle the situation.
Thank you for the patch. I've taken the liberty to make it conditional, so that it should support current stable and unstable media-libs/dav1d. Please feel free to test it and comment if there are any issues. Created attachment 767641 [details, diff]
Updated conditional patch.
(In reply to Myckel Habets from comment #3) > Created attachment 767641 [details, diff] [details, diff] > Updated conditional patch. Oo this would've been a much cleaner solution for firefox/thunderbird as well if it works. (In reply to Joonas Niilola from comment #4) > (In reply to Myckel Habets from comment #3) > > Created attachment 767641 [details, diff] [details, diff] [details, diff] > > Updated conditional patch. > > Oo this would've been a much cleaner solution for firefox/thunderbird as > well if it works. Feel free to adjust and use it. This patch helps with Gentoo having a stable and unstable version. I already send it to Seamonkey upstream and they accepted it in their patch queue with the remark that it will be removed when they backport the FF patch: https://hg.mozilla.org/mozilla-central/rev/7c43b7cf95c4 This mostly contains changes involving the fact that they bundle the dav1d library, and not so much the the changed API. Could you make a PR with your patch? (In reply to Sam James from comment #6) > Could you make a PR with your patch? Sure, working on it. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f6f6ba1d2749d8a62db6b1f8fc0c4f50a5a07129 commit f6f6ba1d2749d8a62db6b1f8fc0c4f50a5a07129 Author: Myckel Habets <gentoo-bugs@habets-dobben.nl> AuthorDate: 2022-03-25 14:00:08 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-03-26 13:26:27 +0000 www-client/seamonkey: bump version to 2.53.11-r1 * Add patch to support media-libs/dav1d-1.0.0. Closes: https://bugs.gentoo.org/835828 Signed-off-by: Myckel Habets <gentoo-bugs@habets-dobben.nl> Closes: https://github.com/gentoo/gentoo/pull/24744 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/seamonkey/Manifest | 1 + www-client/seamonkey/seamonkey-2.53.11-r1.ebuild | 553 +++++++++++++++++++++++ 2 files changed, 554 insertions(+) |