Summary: | media-sound/fluidsynth-2.3.3 calls cc directly | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | Gentoo Sound Team <sound> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | fordfrog, watermanpaint |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/34989 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 921338 | ||
Bug Blocks: | 243502 | ||
Attachments: |
build.log
1-CMakeError.log 1-CMakeOutput.log 2-CMakeOutput.log |
Description
Agostino Sarubbo
2022-02-24 10:21:04 UTC
Created attachment 765751 [details]
build.log
build log and emerge --info
Created attachment 765752 [details]
1-CMakeError.log
1-CMakeError.log
Created attachment 765753 [details]
1-CMakeOutput.log
1-CMakeOutput.log
Created attachment 765754 [details]
2-CMakeOutput.log
2-CMakeOutput.log
Error(s) that match a know pattern: -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) No CMAKE_C_COMPILER could be found. -- Package 'libinstpatch-1.0', required by 'virtual:world', not found ci has reproduced this issue with version 2.2.6 - Updating summary. ci has reproduced this issue with version 2.2.7 - Updating summary. ci has reproduced this issue with version 2.2.8 - Updating summary. ci has reproduced this issue with version 2.2.9 - Updating summary. ci has reproduced this issue with version 2.3.0 - Updating summary. ci has reproduced this issue with version 2.3.1 - Updating summary. ci has reproduced this issue with version 2.3.2 - Updating summary. ci has reproduced this issue with version 2.3.2-r1 - Updating summary. ci has reproduced this issue with version 2.3.2-r2 - Updating summary. ci has reproduced this issue with version 2.3.3 - Updating summary. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79268f1ce9c8e1e24a3f2d1ae539a696711e8587 commit 79268f1ce9c8e1e24a3f2d1ae539a696711e8587 Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2024-01-23 09:57:29 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2024-01-23 09:57:29 +0000 media-sound/fluidsynth: dropped obsolete 2.3.3 Bug: https://bugs.gentoo.org/921338 Closes: https://bugs.gentoo.org/833979 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/fluidsynth/Manifest | 1 - media-sound/fluidsynth/fluidsynth-2.3.3.ebuild | 121 ------------------------- 2 files changed, 122 deletions(-) This is not fixed yet. The issue seems to be the hacky cmake implementation to choose a CBUILD compiler for building the "make_tables" binary. src/CMakeLists.txt adds instructions for the "make_tables" binary: ExternalProject_Add(gentables [...] CONFIGURE_COMMAND "${CMAKE_COMMAND}" -DCMAKE_VERBOSE_MAKEFILE=${CMAKE_VERBOSE_MAKEFILE} -G "${CMAKE_GENERATOR}" -B "${GENTAB_BDIR}" "${GENTAB_SDIR}" [...] INSTALL_COMMAND ${GENTAB_BDIR}/make_tables.exe "${FluidSynth_BINARY_DIR}/" ) src/gentables/CMakeLists.txt unsets CC to force cmake to look for a C compiler, hopefully a CBUILD one. Since the CMAKE_C_COMPILER macro is not passed in CONFIGURE_COMMAND, the CMakeDetermineCCompiler.cmake module tries and fails to determine a C compiler. If I'm not mistaken, it first inspects the (unset) CC env var, then tries all of [cc,gcc,cl,bcc,xlc,icx,clang]. thanks. the bug was not updated to the latest version so i thought it's fixed. Upstream bug report: https://github.com/FluidSynth/fluidsynth/issues/1301 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fb429b5ab3758bb6169613749496c2070e3c4d8e commit fb429b5ab3758bb6169613749496c2070e3c4d8e Author: Lucio Sauer <watermanpaint@posteo.net> AuthorDate: 2024-01-25 09:04:34 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2024-01-26 07:57:13 +0000 media-sound/fluidsynth: prevent faulty CMake C compiler detection Manually pass CMAKE_C_COMPILER to subprocess, which relies on insufficient CMake compiler auto-detection to detect a suitable CBUILD C compiler. Closes: https://bugs.gentoo.org/833979 Signed-off-by: Lucio Sauer <watermanpaint@posteo.net> Closes: https://github.com/gentoo/gentoo/pull/34989 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/fluidsynth/fluidsynth-2.3.4-r1.ebuild | 149 ++++++++++++++++++++++ 1 file changed, 149 insertions(+) |