Bug 833091

Summary:	app-arch/libarchive fails test phase when compiled with USE="-zlib"
Product:	Gentoo Linux	Reporter:	unhappy-ending <unhappy-ending>
Component:	Current packages	Assignee:	Michał Górny <mgorny>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein
Priority:	Normal	Keywords:	TESTFAILURE
Version:	unspecified
Hardware:	AMD64
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	test failure test success build.log

Description unhappy-ending 2022-02-10 22:43:37 UTC

libarchive will fail the test phase if you don't have the USE flag zlib enabled for it.

Reproducible: Always

Steps to Reproduce:
1.USE="-zlib" emerge -1 app-arch/libarchive
2.???
3.Profit
Actual Results:  
Test failure

Expected Results:  
Probably expected behavior if it's missing a dependency

I'm not sure exactly why it fails, maybe related to DEFLATE compression used in a gzip and winzip wrapper in some of the tests.

Maybe we can add to the ebuild:

REQUIRED_USE="
 Test? ( zlib )
"

Comment 1 unhappy-ending 2022-02-10 22:44:34 UTC

Created attachment 764810 [details]
test failure

Comment 2 unhappy-ending 2022-02-10 22:44:48 UTC

Created attachment 764811 [details]
test success

Comment 3 unhappy-ending 2022-02-10 22:45:46 UTC

Created attachment 764812 [details]
build.log

Comment 4 Michał Górny archtester

2022-02-10 23:41:13 UTC

Do you have a specific use case for -zlib here?  I'm not sure if this is worth addressing, maybe we should just enable zlib unconditionally.

Comment 5 unhappy-ending 2022-02-11 07:15:38 UTC

I don't have a particular use case, just happened to be testing minimal USE flags and reporting when something doesn't pass testing.

Comment 6 Michał Górny archtester

2022-02-11 09:26:52 UTC

Ok, thanks!  I don't think REQUIRED_USE is the way to go, I'd rather either fix the test suite or remove IUSE=zlib altogether.  I'll try to find some time to look at this today.

Comment 7 unhappy-ending 2022-02-12 03:04:25 UTC

Thank you for your work!

Comment 8 Michał Górny archtester

2022-02-12 10:16:20 UTC

I've submitted fixes for some of the test failures but it looks that in some cases the internal library state gets broken and I don't really want to investigate that deeper.  At this point, an archive library without zlib doesn't sound that useful (and the gzip fallback looks incomplete/broken), so I'm just going to remove the flag.

Comment 9 Larry the Git Cow gentoo-dev

2022-02-12 10:20:41 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ecebf9b6aae9610454f2b94a0fc7bf429ac03d69

commit ecebf9b6aae9610454f2b94a0fc7bf429ac03d69
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-02-12 10:18:42 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-02-12 10:20:38 +0000

    app-arch/libarchive: Enable zlib unconditionally
    
    Building libarchive without zlib support is not being tested properly.
    The library has test failures, and quite possibly also some runtime
    bugs.  Remove the flag and enable zlib unconditionally.
    
    Closes: https://bugs.gentoo.org/833091
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-arch/libarchive/libarchive-3.5.3.ebuild | 6 +++---
 app-arch/libarchive/libarchive-3.6.0.ebuild | 6 +++---
 app-arch/libarchive/metadata.xml            | 7 -------
 3 files changed, 6 insertions(+), 13 deletions(-)