Summary: | app-emulation/libguestfs-1.46.0-r1: pcre-c.c:47:1: error: static declaration of ‘caml_alloc_initialized_string’ follows non-static declaration | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | WGH <wgh> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, sam, Xeha |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | build.log |
Description
WGH
2021-10-24 15:31:13 UTC
Created attachment 746526 [details]
build.log
I think is this is because I disabled ocaml use flag. The build scripts actually check for existence of this function: https://github.com/libguestfs/libguestfs/blob/760d11ecfad1195ee3074bb999c17d086c5533a5/m4/guestfs-ocaml.m4#L216-L232 And if it's defined in ocaml headers, the static inline definition is not emitted: https://github.com/libguestfs/libguestfs-common/blob/19302b64c5f13a1c247ebbb5f9036e115f081675/mlpcre/pcre-c.c#L42-L53 However, if ocaml is disabled, this check is never run. There's a patch for 1.44 in Gentoo that fixes exactly this: https://github.com/gentoo/gentoo/blob/master/app-emulation/libguestfs/files/1.44/0001-Check-for-caml_alloc_initialized_string-existence-ev.patch It wasn't ported to 1.46.0-r1 somehow. Confirming same issue. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89bd42f04001dfe739cc0b15d3d54b20704c4ce6 commit 89bd42f04001dfe739cc0b15d3d54b20704c4ce6 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-10-24 20:24:00 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-10-24 20:24:21 +0000 app-emulation/libguestfs: fix build failure in 1.46.0 Restore patch from 1.44.x branch. Closes: https://bugs.gentoo.org/820053 Signed-off-by: Sam James <sam@gentoo.org> app-emulation/libguestfs/libguestfs-1.46.0-r1.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (In reply to WGH from comment #3) > There's a patch for 1.44 in Gentoo that fixes exactly this: > https://github.com/gentoo/gentoo/blob/master/app-emulation/libguestfs/files/ > 1.44/0001-Check-for-caml_alloc_initialized_string-existence-ev.patch > > It wasn't ported to 1.46.0-r1 somehow. I naively thought it'd been fixed upstream, apologies Upstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2108425 Should be fixed in: https://github.com/libguestfs/libguestfs/commit/adfaf25a12b97b18f8a22d96803cd0920bfd25f7 (development branch) https://github.com/libguestfs/libguestfs/commit/f162e47ecfee711f2c3bcc761de17e502fe7ab5e (stable branch) Note that OCaml is required for building libguestfs. The ./configure --disable-ocaml option only disables the bindings (which is pretty pointless IMHO, but it's there in case you want it). |