Summary: | vmware-workstation fix for new kernels | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Jonathan Heaney <agent_jdh> |
Component: | Current packages | Assignee: | Gentoo VMWare Bug Squashers [disabled] <vmware+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Jonathan Heaney
2005-02-04 08:04:36 UTC
I don't revision bump for any-any-update changes for a reason. http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1 "Likewise, if you fix a compilation problem in the ebuild that was affecting some users, there is no need to bump the revision number, since those for whom it worked perfectly would see no benefit in installing a new revision, and those who experienced the problem do not have the package installed (since compilation failed) and thus have no need for the new revision number to force an upgrade." While it can be argued that a revision bump should be made, in the end, as the maintainer, it is my call. I try not to revision bump things for a patch. That quote from the dev. handbook is a bit ambiguous though w.r.t. vmware - ref. this part "...those who experienced the problem do not have the package installed (since compilation failed)...". That statement does not really apply to vmware as there's no compilation that takes place during the emerge. So you can emerge vmware OK only for the manual configuration after installation to fail. The problem the end user has then is that (s)he has to periodically re-emerge vmware, and run the configuration, to see if the problem has been fixed. Maybe though vmware is again unique due to the fact it can be (and seems to be frequently these days) broken by new kernel versions, and not vmware or the vmware ebuild itself. As the maintainer of course it is up to you - but it seems logical to me that, if the ebuild itself is revised, for whatever reason, then the revision number of the ebuild should be revised as well. Well, I'd updated the 4.5.2 ebuild to vmware-any-any-89 a while back, so this should have been resolved then. |