Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 80728 - vmware-workstation fix for new kernels
Summary: vmware-workstation fix for new kernels
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo VMWare Bug Squashers [disabled]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-04 08:04 UTC by Jonathan Heaney
Modified: 2005-04-08 11:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Heaney 2005-02-04 08:04:36 UTC
vmware-config.pl fails to compile its modules on 2.6.11-rc3-ck1 (and I assume vanilla rc3 as well).

Updating the ebuild to use latest vmware-any-any-update89 from http://ftp.cvut.cz/vmware/ fixes complation here.

Could the ebuild be updated, and maybe a version bump - I've noticed quite a few things have changed in the vmware-workstation ebuild (e.g. any-any-update bumps, permissions issue fixed), without an ebuild revision bump.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2005-02-04 11:51:05 UTC
I don't revision bump for any-any-update changes for a reason.

http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml?part=3&chap=1

"Likewise, if you fix a compilation problem in the ebuild that was affecting some users, there is no need to bump the revision number, since those for whom it worked perfectly would see no benefit in installing a new revision, and those who experienced the problem do not have the package installed (since compilation failed) and thus have no need for the new revision number to force an upgrade."

While it can be argued that a revision bump should be made, in the end, as the maintainer, it is my call.  I try not to revision bump things for a patch.
Comment 2 Jonathan Heaney 2005-02-04 14:19:19 UTC
That quote from the dev. handbook is a bit ambiguous though w.r.t. vmware - ref. this part "...those who experienced the problem do not have the package installed (since compilation failed)...".  That statement does not really apply to vmware as there's no compilation that takes place during the emerge.  So you can emerge vmware OK only for the manual configuration after installation to fail.

The problem the end user has then is that (s)he has to periodically re-emerge vmware, and run the configuration, to see if the problem has been fixed.  Maybe though vmware is again unique due to the fact it can be (and seems to be frequently these days) broken by new kernel versions, and not vmware or the vmware ebuild itself.

As the maintainer of course it is up to you - but it seems logical to me that, if the ebuild itself is revised, for whatever reason, then the revision number of the ebuild should be revised as well.
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2005-04-08 11:50:11 UTC
Well, I'd updated the 4.5.2 ebuild to vmware-any-any-89 a while back, so this should have been resolved then.