Bug 804193

Summary:	sys-apps/openrc rc_cgroup_cleanup does not work
Product:	Gentoo Linux	Reporter:	wolf+gentoo
Component:	Current packages	Assignee:	OpenRC Team <openrc>
Status:	RESOLVED FIXED
Severity:	normal	CC:	gentoo, wolf+gentoo
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description wolf+gentoo 2021-07-25 16:30:04 UTC

It looks like there is a typo in https://github.com/OpenRC/openrc/blob/master/sh/rc-cgroup.sh#L222 , it should be `${cgroup_pids}` instead of the current  version with `()`.

Current code fail on service stop with `cgroup_pids: not found` (since command/function of that name indeed does not exist).

Also, since I'm already reporting this:

    ebegin "starting cgroups cleanup"

The message starts with lowercase `s`, but other messages (`Stopping ...`) are with capital one. It looks out of place when running restart for example:

     * Stopping xx ...                                    [ ok ]
     * starting cgroups cleanup ...                       [ ok ]
     * Starting xx ...                                    [ ok ]

If someone will be touching the file anyway it could be adjusted to `S`.

Comment 1 William Hubbs gentoo-dev

2021-08-20 17:32:26 UTC

This is fixed in 0.43.5.